From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Wed, 10 Mar 2021 13:14:16 +0000 Message-ID: References: <83tupms4mp.fsf@gnu.org> <83eegpspjk.fsf@gnu.org> <83r1kpr03h.fsf@gnu.org> <83mtvdqt53.fsf@gnu.org> <83blbsqyea.fsf@gnu.org> <8335x4qofy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27511"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46256@debbugs.gnu.org, andrewjmoreton@gmail.com, pipcet@gmail.com, akrl@sdf.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 10 14:16:59 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJyhu-0006xj-PE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Mar 2021 14:16:58 +0100 Original-Received: from localhost ([::1]:55362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJyht-0001e1-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Mar 2021 08:16:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJyg2-000141-Rj for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 08:15:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJyg2-0008BG-L1 for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 08:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJyg2-0004T3-Gc for bug-gnu-emacs@gnu.org; Wed, 10 Mar 2021 08:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Mar 2021 13:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.161538206617075 (code B ref 46256); Wed, 10 Mar 2021 13:15:02 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 10 Mar 2021 13:14:26 +0000 Original-Received: from localhost ([127.0.0.1]:49135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJyfR-0004RL-SX for submit@debbugs.gnu.org; Wed, 10 Mar 2021 08:14:26 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:56697 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1lJyfQ-0004R6-77 for 46256@debbugs.gnu.org; Wed, 10 Mar 2021 08:14:24 -0500 Original-Received: (qmail 6189 invoked by uid 3782); 10 Mar 2021 13:14:17 -0000 Original-Received: from acm.muc.de (p4fe15e8b.dip0.t-ipconnect.de [79.225.94.139]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 10 Mar 2021 14:14:17 +0100 Original-Received: (qmail 8631 invoked by uid 1000); 10 Mar 2021 13:14:16 -0000 Content-Disposition: inline In-Reply-To: <8335x4qofy.fsf@gnu.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201974 Archived-At: Hello, Eli. On Tue, Mar 09, 2021 at 18:30:57 +0200, Eli Zaretskii wrote: > > Date: Tue, 09 Mar 2021 14:55:57 +0200 > > From: Eli Zaretskii > > Cc: 46256@debbugs.gnu.org, andrewjmoreton@gmail.com, pipcet@gmail.com > > > From: Andrea Corallo > > > Cc: pipcet@gmail.com, 46256@debbugs.gnu.org, andrewjmoreton@gmail.com > > > Date: Tue, 09 Mar 2021 07:03:01 +0000 > > > > Can you tell why are we loading the same .eln files more than once? > > > I guess `load' was called two times on the same filename. > > Is this likely to happen? Our code generally uses 'require', which > > should avoid that. > Answering my own question here: it can easily happen due to use of > cc-require in cc-*.el files. Alan, why does CC mode use this > technique? what is the purpose of always loading a Lisp file even if > it was already loaded? Are you sure? cc-require is intended just to compile a `require' form (OK, it compiles (progn nil (require 'cc-vars)), but the byte compiler will optimise the progn away). When loading uncompiled cc-*.el, cc-require does fancy things to make sure the cc-*.el is in the "correct" directory, but it shouldn't compile any of this into the *.elc. Maybe there's a bug, somewhere. The code in this area was written by Martin Stjernholm (my predecessor), who was evidently having trouble with "wrong" versions of the *.el files getting loaded. I've had a bit of a look at the thread for bug #46256, but I can't really follow it, at least not without a lot of effort. Might it be that the ..eln compiler is doing things on the .el file? I'm not at all familiar with how the native compilation works, I'm afraid. -- Alan Mackenzie (Nuremberg, Germany).