From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#47074: Replace XPM icons with Unicode codepoints in customize/widgets Date: Sun, 14 Mar 2021 19:37:33 +0000 Message-ID: References: <83a6r9mwgk.fsf@gnu.org> <8335x1mpdk.fsf@gnu.org> <83o8flfu4l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2872"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , 47074@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 14 20:38:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLWZ0-0000f9-Om for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Mar 2021 20:38:11 +0100 Original-Received: from localhost ([::1]:49128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLWYz-0000lN-RB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Mar 2021 15:38:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLWYs-0000l3-DT for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 15:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50927) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLWYs-0007MP-5l for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 15:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lLWYs-00005B-1k for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2021 15:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Mar 2021 19:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47074 X-GNU-PR-Package: emacs Original-Received: via spool by 47074-submit@debbugs.gnu.org id=B47074.161575066432757 (code B ref 47074); Sun, 14 Mar 2021 19:38:01 +0000 Original-Received: (at 47074) by debbugs.gnu.org; 14 Mar 2021 19:37:44 +0000 Original-Received: from localhost ([127.0.0.1]:34240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLWYZ-0008WH-Ui for submit@debbugs.gnu.org; Sun, 14 Mar 2021 15:37:44 -0400 Original-Received: from outbound.soverin.net ([116.202.65.218]:42827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLWYY-0008W4-Ri for 47074@debbugs.gnu.org; Sun, 14 Mar 2021 15:37:43 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 1C03060060; Sun, 14 Mar 2021 19:37:37 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1615750656; bh=uGxZf0TliAfvbT7U4i2vxgiIOex1tlYF+RhJzAf4CHM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BcMZyPPTrrT5WYTEru9G+w/mnPdi8FqJul6RMGfnBN3AC6y4qiOFCwqFJ/KfVZdqd cYJ/PyjwyKPcdDxsEOwONuRY4rR90cYghn7zjE7xIQtrgP39nX1wJcrA8wT+uPdue4 ZrCmujHZiNX51W6DLhPX5j8efO1YBIijHie6XBlpIQo8eFA8LQw+20ZTYZTuH1U+OI ND5vXM75FxdzxqX9T86p7Tedv6IqrlbiddwKhL9M6aEiz2Dw/XDWFI79HaPJYjOVQM kDR8Csp9FX6THBQDrNEbn74sLoVH2CY+TiHDRLtZpSInOvFcTmLNDPo/+2krcYWfvk RwRD7kBRuF8HA== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 0E42B202AF625B; Sun, 14 Mar 2021 19:37:33 +0000 (GMT) Mail-Followup-To: Alan Third , Eli Zaretskii , Stefan Kangas , 47074@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <83o8flfu4l.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202386 Archived-At: On Sun, Mar 14, 2021 at 08:49:30PM +0200, Eli Zaretskii wrote: > > From: Stefan Kangas > > Date: Sun, 14 Mar 2021 13:44:32 -0500 > > Cc: Eli Zaretskii , 47074@debbugs.gnu.org > > > > This is exactly the behavior I was thinking of, yes. It looks and works > > great in some minor testing. > > > > Maybe Lars or Eli have additional comments, but LGTM. > > The only question I have is what will happen if librsvg is older than > 2.48? It will work exactly as it works at the moment. The font size will be set to the librsvg default, which I think is 16 pixels, so the images will default to 16 pixels high. The problem is that librsvg only provided the ability to set a stylesheet in 2.48, for earlier versions we'd have to wrap the SVG, similar to what we do at the moment for resizing, but we'd have to wrap twice with two different wrappers (once to get the original size, and once to generate the resized image). I'm not actually sure whether we can reliably get the size of a wrapped image. I'll have to try it I suppose. It looks like the stylesheet change was only merged in last year, I was forgetting this was added so recently. -- Alan Third