From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#46881: 28.0.50; pdumper dumping causes way too many syscalls Date: Tue, 2 Mar 2021 21:07:52 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17388"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46881@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 22:19:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHCQB-0004Qs-Cb for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 22:19:11 +0100 Original-Received: from localhost ([::1]:53430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHCQA-0002EI-Cv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 16:19:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHCGM-0000EB-4T for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 16:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHCGL-0002Hb-Qk for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 16:09:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHCGL-0005NI-KA for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 16:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46881 X-GNU-PR-Package: emacs Original-Received: via spool by 46881-submit@debbugs.gnu.org id=B46881.161471928820599 (code B ref 46881); Tue, 02 Mar 2021 21:09:01 +0000 Original-Received: (at 46881) by debbugs.gnu.org; 2 Mar 2021 21:08:08 +0000 Original-Received: from localhost ([127.0.0.1]:54354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHCFT-0005MA-6T for submit@debbugs.gnu.org; Tue, 02 Mar 2021 16:08:08 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:36931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHCFN-0005LY-Sc for 46881@debbugs.gnu.org; Tue, 02 Mar 2021 16:08:05 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id AC4E4600F5 for <46881@debbugs.gnu.org>; Tue, 2 Mar 2021 21:07:55 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1614719275; bh=Gn/fFdJQmHej7f8G4cjroZ7nBBxCt7DRt2VL9NyGNpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RB+7EVHCU9wyz/duzQr5DatpVzj+Wg34btNdMPbXYvAaZeEDoFrBQth3cbNnyU+eO DgkbitZB9XGkrk7aRol1PumAk8sOPSisVfjGveXS5Za4A6c/bnQRzrYQDQ3NZEox3E 5nmTaaoKNG/dYYTwtggXYn7PLfy8ELkwNtqDRIXao6j2VnuHrAefqNCRQeQNdwH9q3 QjssipDNBV6c6C+NHVZyMVhIVO6HuOxc3yTjMBW6WGeSCB74iwR5CbzQsRaCopcWNr JUTbfhFuFeNmPqunflg09m3EdwZ2oF55oRe5bLdBGjvEcdxq/OFvOg2/n3e4IzWpXO tZm5VbYky6a4A== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id D1914202AC44B9; Tue, 2 Mar 2021 21:07:52 +0000 (GMT) Mail-Followup-To: Alan Third , Pip Cet , 46881@debbugs.gnu.org Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201240 Archived-At: On Tue, Mar 02, 2021 at 08:45:04PM +0000, Pip Cet wrote: > On Tue, Mar 2, 2021 at 8:35 PM Pip Cet wrote: > > I've looked into the problem, and it seems easy to solve and worth it > > in terms of debuggability and performance. > > Very rough benchmarks, but this seems to be clearly worth it: > > Performance: > With patch: > real 0m3.861s > user 0m3.776s > sys 0m0.085s > > Without patch: > real 0m7.001s > user 0m4.476s > sys 0m2.511s > > Number of syscalls: > With patch: 415442 > Without patch: 2028307 My quick test on macOS by doing: rm src/*.pdmp time make sees it going from ~26s without patch to ~10s with patch, so a considerable improvement. > > Patch will be attached once this has a bug number. > > And here's the patch. Testing would be very appreciated. It appears to work fine here, but I don't know if there's anything specific to test other than just running Emacs. -- Alan Third