unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Utkarsh Singh <utkarsh190601@gmail.com>
Cc: 46301-done@debbugs.gnu.org
Subject: bug#46301: 28.0.50; cc-mode: add support for c++ lambda expression
Date: Mon, 1 Mar 2021 19:34:27 +0000	[thread overview]
Message-ID: <YD1Bw9rjcAKkqLS8@ACM> (raw)
In-Reply-To: <87v9ad4io0.fsf@gmail.com>

Hello, Utkarsh.

On Sat, Feb 27, 2021 at 21:17:11 +0530, Utkarsh Singh wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > I've spent the last couple of days fixing the handling of C-M-a/e in
> > cc-cmds.el.  It took rather more than the four line patch you proposed.
> > ;-)  Could I ask you, please, to apply the following patch (which should
> > apply cleanly to the Emacs master branch), byte compile cc-cmds.el, load
> > it into Emacs, and test it for me on your real source code.  Then please
> > report back whether the bug is in fact fixed, and if not, what is still
> > wrong.  In the event you would like help with the patching or byte
> > compiling, feel free to send me private email.

> Thanks now issue is fixed and code itself looks pretty solid.

Thanks for doing the testing.  I've committed the patch to all the
relevant places, and I'm closing the bug with this post.

> Due to my in-experience in Elisp and comprehensive cc-mode library I was
> unable to deep dive into the patch but I have a questions about it:

> Why non-interactive functions of cc-mode doesn't provide doc-string?

Quite a lot of functions, even non-interactive ones, and variables have
a doc string.  This means that those functions/variables are available
to modes derived from CC Mode, and their interfaces are fixed.  The ones
without doc strings are regarded as "internal" to CC Mode, and their
interfaces can (and do) change at any time.  There's a comment to this
effect burried in the first few hundred lines of cc-engine.el.

A few years ago, an alternative convention started being adopted by
Emacs, where a double hypen is used to indicate an "internal" function
or variable.

> --
> Utkarsh Singh

-- 
Alan Mackenzie (Nuremberg, Germany).





      reply	other threads:[~2021-03-01 19:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 15:47 bug#46301: 28.0.50; cc-mode: add support for c++ lambda expression Utkarsh Singh
2021-02-23 19:19 ` Alan Mackenzie
2021-02-24  4:07   ` Utkarsh Singh
2021-02-25 20:51     ` Alan Mackenzie
2021-02-27 15:47       ` Utkarsh Singh
2021-03-01 19:34         ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YD1Bw9rjcAKkqLS8@ACM \
    --to=acm@muc.de \
    --cc=46301-done@debbugs.gnu.org \
    --cc=utkarsh190601@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).