unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Konstantin Kharlamov <hi-angel@yandex.ru>
Cc: acm@muc.de, 46400@debbugs.gnu.org
Subject: bug#46400: [BISECTED] Sporadically breaking newline-indentation in c-mode
Date: Fri, 12 Feb 2021 14:56:41 +0000	[thread overview]
Message-ID: <YCaXKddNoAuSrPND@ACM> (raw)
In-Reply-To: <dca05eb5c54be78d166acf23160a5e3336d2b343.camel@yandex.ru>

Hello, Konstantin.

First of all, thanks for taking the trouble to report this bug, and
thanks even more for taking the diagnosis so far.

On Fri, Feb 12, 2021 at 17:08:19 +0300, Konstantin Kharlamov wrote:
> On Wed, 2021-02-10 at 01:13 +0300, Konstantin Kharlamov wrote:
> > I just bisected it to a commit 

> >     3096437593 CC Mode: introduce a new cache for brace structures.  This
> > fixes bug #45248

> > before this commit I couldn't reproduce it, and on this I reproduce it
> > immediately.

> > CCing the commit author.

> So, what's the plan here? Should I send a revert?

No, please don't do that - that was an essential fix for a performance
bug.

> CC: Alan Mackenzie (I know I already CCed, but I figured they might
> not know they were mentioned if they has mail filters for example,
> since I didn't write the name).

Sorry, I should have got back to you sooner, but I wanted to have
something to show.

I don't think the bug was introduced by the commit you cite, more likely
that commit triggered the bug which was lying in wait elsewhere.

I've been working on this bug for several hours, so far, and have found
that the "c-state-cache" (which records the positions of certain braces,
brackets and parentheses) becomes corrupt while running your `test'
function.  I'm trying to track down where and how this corruption
happens.

Also relevant is that the bug seems to be being triggered by the
apostrophe in

    bar("Couldn't open %s", to);
               ^

..  At least, if I take that apostrophe away, I don't see the bug
symptoms any more.

So, please bear with me some while longer.  I am working on the bug.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2021-02-12 14:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 12:45 bug#46400: Sporadically breaking newline-indentation in c-mode Konstantin Kharlamov
2021-02-09 22:13 ` bug#46400: [BISECTED] " Konstantin Kharlamov
2021-02-12 14:08   ` Konstantin Kharlamov
2021-02-12 14:56     ` Alan Mackenzie [this message]
2021-02-12 15:46       ` Konstantin Kharlamov
2021-02-17 21:59       ` Konstantin Kharlamov
2021-02-18 11:21         ` Alan Mackenzie
2021-02-23 11:26           ` Alan Mackenzie
     [not found]           ` <YDTmW5Fi8xBc0Wja@ACM>
2021-02-23 11:32             ` Konstantin Kharlamov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCaXKddNoAuSrPND@ACM \
    --to=acm@muc.de \
    --cc=46400@debbugs.gnu.org \
    --cc=hi-angel@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).