From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#45792: 28.0.50; regression in commit c7c154bb, minibuffer is not closed after opening a file Date: Sat, 30 Jan 2021 18:35:03 +0000 Message-ID: References: <75aca8c3-6c8f-2a66-399e-7116d99c91d3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33516"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45792@debbugs.gnu.org To: Platon Pronko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 30 19:36:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5v6R-0008b6-G9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jan 2021 19:36:11 +0100 Original-Received: from localhost ([::1]:42976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5v6Q-00079i-FO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jan 2021 13:36:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5v6I-00076i-4k for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2021 13:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5v6H-0003or-Tl for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2021 13:36:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l5v6H-0001Fm-Qd for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2021 13:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jan 2021 18:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45792 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: martin rudalics , bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16120317144754 (code B ref -1); Sat, 30 Jan 2021 18:36:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Jan 2021 18:35:14 +0000 Original-Received: from localhost ([127.0.0.1]:55793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5v5W-0001Eb-4p for submit@debbugs.gnu.org; Sat, 30 Jan 2021 13:35:14 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:37020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5v5T-0001ES-0x for submit@debbugs.gnu.org; Sat, 30 Jan 2021 13:35:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5v5S-0006sk-QG for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2021 13:35:10 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:48763 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1l5v5Q-0003Kt-LX for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2021 13:35:10 -0500 Original-Received: (qmail 58463 invoked by uid 3782); 30 Jan 2021 18:35:04 -0000 Original-Received: from acm.muc.de (p2e5d54d6.dip0.t-ipconnect.de [46.93.84.214]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 30 Jan 2021 19:35:04 +0100 Original-Received: (qmail 13038 invoked by uid 1000); 30 Jan 2021 18:35:03 -0000 Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.1; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198956 Archived-At: Hello again, Platon. Terribly sorry to take nearly two weeks to reply. Real life got in the way. On Sun, Jan 17, 2021 at 10:50:32 +0300, Platon Pronko wrote: > Hi! > I'm terribly sorry, apparently I wasted a lot of your time. No problem, but I don't think you did. There were real bugs connected with input methods, and I think your initial scenario highlighted one of these bugs. > I tested (minibufferp) refactoring again and it seems that when I > did that for the previous email I messed something up. When I ran the code today > the issue went away. It hasn't gone away for me. ;-) > Original reason for " *Minibuf-0*" test in dvorak-minor-mode was to > stop emacs --daemon from hanging on startup. (now that you explained about > quail-minibuffer-message and sit-for, I assume that's was the reason why that was happening) Possibly. > But the buffer that was triggering the current issue is called " *Minibuf-1*", so it > passes the test and activate-input-method is called. Yes. > I had no idea that activate-input-method was dangerous when called in > global minor modes, but that's probably just the way it is. I disagree. The fact that it is dangerous is a bug which needs fixing. The fix I have at the moment is not to call the (sit-for 1000000) when the current buffer is a minibuffer. To be honest, I don't understand quail.el very well, but I'm not sure there's anybody still on the development team who understands it any better. > Again, terribly sorry for wasting your time on what turned out to be > a configuration issue. No need to apologise - there were real bugs there. Thanks for the original report! > > Just as a matter of interest, you can write that more easily as > > ./src/emacs -Q -l ~/.emacs.d/init.el. > Thanks, that's a useful shortcut! :-) I'm hoping to commit a patch for the bug over the weekend, sometime. It's been a difficult bug to diagnose. > Best regards, > Platon Pronko -- Alan Mackenzie (Nuremberg, Germany).