From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Herbert J. Skuhra" Newsgroups: gmane.emacs.bugs Subject: bug#54154: Emacs commit ae963e80a79f5a9184daabfc8197f211a39b136d (sieve-manage) Date: Thu, 19 Jan 2023 00:22:44 +0100 Message-ID: References: <87wnhj5nbk.fsf@tetzco.de> <835yd31wk8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15567"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 54154@debbugs.gnu.org, emacs+bug@tetzco.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 19 10:29:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIREP-0003mI-Pa for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Jan 2023 10:29:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIQBp-0003g7-0c; Thu, 19 Jan 2023 03:22:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIQBT-0003db-M5 for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 03:22:12 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIQBS-0003rB-13 for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 03:22:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIQBO-0008Ck-Tr for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 03:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Herbert J. Skuhra" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jan 2023 08:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54154-submit@debbugs.gnu.org id=B54154.167411646231416 (code B ref 54154); Thu, 19 Jan 2023 08:22:02 +0000 Original-Received: (at 54154) by debbugs.gnu.org; 19 Jan 2023 08:21:02 +0000 Original-Received: from localhost ([127.0.0.1]:42460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIQAI-0008A0-LY for submit@debbugs.gnu.org; Thu, 19 Jan 2023 03:21:01 -0500 Original-Received: from mail.bsd4all.net ([94.130.200.20]:51497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIHla-0006ai-FK for 54154@debbugs.gnu.org; Wed, 18 Jan 2023 18:22:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gojira.at; s=mail202005; t=1674084164; bh=5PSpFVBWxTEUkGESCf78zLVQK/rsrM2eUb0WoMZdjFY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=rhj8QwbDGcJLymmTsR8I88Lh/KnOnY8tD44lFJ3erw2byBA0gs2npUFocKSr+6yv1 gHXSjNVDG99koFre8qOkUVXfvk68WN7Y+FSi//rIEj3wiCKq0Aes4qcTOmi2/cP+1L aoabGpva0YfrtNF/lJ9NJApX761O9nCegH2ZmVH87WHYQwhaSxl9r6o2E/cSq03kpx +mS/Gbs2ehCPkivTapdEhFXllLM5DPRFENRKpkUxDkwKaDETe80V8vhoDPcf3No+Ub giy9cZGS31fegXbAIDStQfTWy0sd0FnYEjyU6YE5VMzuup8BaTIOtzoGIZEcpEZ6PJ WyrsOcA+4Obpw== Content-Disposition: inline In-Reply-To: <835yd31wk8.fsf@gnu.org> X-Mailman-Approved-At: Thu, 19 Jan 2023 03:20:53 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253686 Archived-At: On Wed, Jan 18, 2023 at 09:17:59PM +0200, Eli Zaretskii wrote: > > Cc: larsi , 54154@debbugs.gnu.org > > Date: Wed, 18 Jan 2023 19:28:40 +0100 > > From: "Herbert J. Skuhra" > > > > On Wed, Jan 18, 2023 at 10:09:33AM +0100, Kai Tetzlaff wrote: > > > Hello Herbert, > > > > > > it seems that I'm responsible for this issue. Unfortunately, I cannot > > > reproduce it with my imap/sieve server setup. However, if you're willing > > > to provide some additional info, we should hopefully be able to find the > > > bug. > > > > Hello, > > > > this is strange because I can reproduce it easily on different systems: > > > > - master on FreeBSD 13.1-STABLE > > - emacs-29 and master on macOS 12.6.2 > > - master on WLS2/Windows11 (Ubuntu) > > Is this problem still relevant? I thought that Lars closed the bug > report back in September? > > > > Could you re-run the steps above with the following additional steps > > > before 3.: > > > > > > 2a) M-x find-library sieve-manage > > > 2b) M-x eval-buffer > > > 2c) M-x find-library sieve > > > 2d) M-x eval-buffer > > > 2e) M-x toggle-debug-on-error > > > > > > to get a full backtrace and send it to me? > > > > Backtrace attached. > > Thanks. The error is here: > > (defun sieve-manage--append-to-log (&rest args) > "Append ARGS to sieve-manage log buffer. > > ARGS can be a string or a list of strings. > The buffer to use for logging is specifified via > `sieve-manage-log'. If it is nil, logging is disabled." > (when sieve-manage-log > (with-current-buffer (or (get-buffer sieve-manage-log) > (with-current-buffer <<<<<<<<<<<<<<<<<<<<<< > (get-buffer-create sieve-manage-log) > (set-buffer-multibyte nil) > (buffer-disable-undo))) > > And I admit that I don't understand this code. What is it trying to > do? Shouldn't it be just > > (when sieve-manage-log > (with-current-buffer (get-buffer-create sieve-manage-log) > (set-buffer-multibyte nil) > (buffer-disable-undo))) > > Kai, am I missing something? > > Herbert, if you make the change above, does the problem go away? Yes, this change resolves the issue: diff --git a/lisp/net/sieve-manage.el b/lisp/net/sieve-manage.el index 5bee4f4c4a..636c7cbc5b 100644 --- a/lisp/net/sieve-manage.el +++ b/lisp/net/sieve-manage.el @@ -174,11 +174,9 @@ sieve-manage--append-to-log The buffer to use for logging is specifified via `sieve-manage-log'. If it is nil, logging is disabled." (when sieve-manage-log - (with-current-buffer (or (get-buffer sieve-manage-log) - (with-current-buffer - (get-buffer-create sieve-manage-log) + (with-current-buffer (get-buffer-create sieve-manage-log) (set-buffer-multibyte nil) - (buffer-disable-undo))) + (buffer-disable-undo) (goto-char (point-max)) (apply #'insert args)))) Thanks. -- Herbert