bug#54154: Emacs commit ae963e80a79f5a9184daabfc8197f211a39b136d (sieve-manage)

["Herbert J. Skuhra" <herbert@gojira.at>]

[-- Attachment #1: Type: text/plain, Size: 2143 bytes --]

On Wed, Jan 18, 2023 at 10:09:33AM +0100, Kai Tetzlaff wrote:
> Hello Herbert,
> 
> it seems that I'm responsible for this issue. Unfortunately, I cannot
> reproduce it with my imap/sieve server setup. However, if you're willing
> to provide some additional info, we should hopefully be able to find the
> bug.

Hello, 

this is strange because I can reproduce it easily on different systems:

- master on FreeBSD 13.1-STABLE 
- emacs-29 and master on macOS 12.6.2
- master on WLS2/Windows11 (Ubuntu)

> "Herbert J. Skuhra" writes:
> > I think commit ae963e80a79f5a9184daabfc8197f211a39b136d is causing the
> > following issue: 
> >
> > 1. build master or emacs-29
> > 2. run emacs -Q
> > 3. M-x sieve-manage and enter imap server.
> In my case, after entering the server address, I do get prompted for a
> username followed by a password prompt.
> 
> > The following error is displayed:
> >   sieve-manage: Connecting to <imap server>...
> >   sieve-manage--message: Wrong type argument: stringp, t
> > 4. Repeat step 3 and this time sieve-manage will connect and prompt for username/password
> As I wrote above, I already get these prompts after 3. So somehow, my
> setup is different from the one you're using. What imap server are you using?
> Is the connection to the server using SSL/TLS (in my case it is)?

I use imap.mailbox.org and the connection is encrypted (using STARTTLS).
But tcpdump doesn't capture any packets when I run sieve-manage for the
first time.

> Could you re-run the steps above with the following additional steps
> before 3.:
> 
> 2a) M-x find-library sieve-manage
> 2b) M-x eval-buffer
> 2c) M-x find-library sieve
> 2d) M-x eval-buffer
> 2e) M-x toggle-debug-on-error
> 
> to get a full backtrace and send it to me?

Backtrace attached.

On Wed, Jan 18, 2023 at 10:09:33AM +0100, Kai Tetzlaff wrote:
> Hello Herbert,
> 
> a small update: Please also send the content of the '*sieve-manage-log*'
> buffer.

There is no *sieve-manage-log* buffer after running sieve-manage for the
first time.

> (I also added a - hopefully working - email address for Lars.)

Sorry, copy&paste error. :-( 

Thanks.

-- 
Herbert

[-- Attachment #2: sieve-manage.txt --]
[-- Type: text/plain, Size: 3047 bytes --]

Debugger entered--Lisp error: (wrong-type-argument stringp t)
  set-buffer(t)
  (save-current-buffer (set-buffer (or (get-buffer sieve-manage-log) (save-current-buffer (set-buffer (get-buffer-create sieve-manage-log)) (set-buffer-multibyte nil) (buffer-disable-undo)))) (goto-char (point-max)) (apply #'insert args))
  (progn (save-current-buffer (set-buffer (or (get-buffer sieve-manage-log) (save-current-buffer (set-buffer (get-buffer-create sieve-manage-log)) (set-buffer-multibyte nil) (buffer-disable-undo)))) (goto-char (point-max)) (apply #'insert args)))
  (if sieve-manage-log (progn (save-current-buffer (set-buffer (or (get-buffer sieve-manage-log) (save-current-buffer (set-buffer (get-buffer-create sieve-manage-log)) (set-buffer-multibyte nil) (buffer-disable-undo)))) (goto-char (point-max)) (apply #'insert args))))
  sieve-manage--append-to-log("sieve-manage: Connecting to imap.mailbox.org..." "\n")
  (let ((ret (apply #'message (concat "sieve-manage: " format-string) args))) (sieve-manage--append-to-log ret "\n") ret)
  sieve-manage--message("Connecting to %s..." "imap.mailbox.org")
  (save-current-buffer (set-buffer (or buffer (sieve-manage-make-process-buffer))) (progn (setq sieve-manage-server (or server sieve-manage-server)) (setq sieve-manage-stream (or stream sieve-manage-stream sieve-manage-default-stream)) (setq sieve-manage-auth (or auth sieve-manage-auth))) (sieve-manage--message "Connecting to %s..." sieve-manage-server) (sieve-manage-open-server sieve-manage-server sieve-manage-port sieve-manage-stream (current-buffer)) (if (sieve-manage-opened (current-buffer)) (progn (if (and (null sieve-manage-auth) (not (eq sieve-manage-state 'auth))) (progn (catch '--cl-block-nil-- (let (...) (while tail ...))) (if sieve-manage-auth nil (sieve-manage--error "Couldn't figure out authenticator for server")))) (sieve-manage-erase) (current-buffer))))
  sieve-manage-open("imap.mailbox.org" nil)
  (set (make-local-variable 'sieve-manage-buffer) (sieve-manage-open server port))
  (or (set (make-local-variable 'sieve-manage-buffer) (sieve-manage-open server port)) (error "Error opening server %s" server))
  (set-buffer (or (set (make-local-variable 'sieve-manage-buffer) (sieve-manage-open server port)) (error "Error opening server %s" server)))
  (save-current-buffer (set-buffer (or (set (make-local-variable 'sieve-manage-buffer) (sieve-manage-open server port)) (error "Error opening server %s" server))) (sieve-manage-authenticate))
  sieve-open-server("imap.mailbox.org" nil)
  (if (sieve-open-server server port) (sieve-refresh-scriptlist) (message "Could not open server %s" server))
  sieve-manage("imap.mailbox.org")
  funcall-interactively(sieve-manage "imap.mailbox.org")
  call-interactively(sieve-manage record nil)
  command-execute(sieve-manage record)
  execute-extended-command(nil "sieve-manage" "sieve-man")
  funcall-interactively(execute-extended-command nil "sieve-manage" "sieve-man")
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)