From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 59213-done@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#59213: Emacs 29: Edebug fails to instrument a parameter whose name begins with _
Date: Sat, 11 Feb 2023 11:17:24 +0000 [thread overview]
Message-ID: <Y+d5RPAesoTuvdEb@ACM> (raw)
In-Reply-To: <jwvh6vt9ohn.fsf-monnier+emacs@gnu.org>
Hello, Stefan.
On Fri, Feb 10, 2023 at 17:05:32 -0500, Stefan Monnier wrote:
[ .... ]
> > What do you think?
> I think that's good enough for `emacs-29`, yes.
I've committed the fix (with modifications) to master, as requested by
Eli, and I'm closing the bug with this post.
> I don't like the use of a dynbound variable to control this, but it's
> not clear how to do better. One thing that occurred to me right now is
> that we could mark the Edebug closures themselves, e.g. by replacing
> (function (lambda () ,@forms))
> with
> (function (lambda () :closure-dont-trim-context ,@forms))
> and then have `cconv-make-interpreted-closure` look for this
> tell-tale sign.
Interesting. Isn't there a good chance this would foul up programs which
analyse the structure of a closure? (A bit like
testcover-analyze-coverage analyses the calling structure of
edebug-enter).
> A few minor comments about your patch below.
[ .... ]
> Hmm... any reason why we can't just replace
> (if (null lexvars)
> with
> (if (or cconv-dont-trim-unused-variables (null lexvars))
> and be done with it?
No, no reason at all. I think I was concerned to preserve the macro
expansion, but seeing as how that wouldn't even be in the uninstrumented
form, this is clearly not a valid concern. So I modified the patch to do
that before committing it.
Thanks!
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2023-02-11 11:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 9:35 bug#59213: Emacs 29: Edebug fails to instrument a parameter whose name begins with _ Alan Mackenzie
2022-11-14 2:48 ` Michael Heerdegen
2022-11-14 3:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-14 10:28 ` Alan Mackenzie
2022-11-14 12:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-14 12:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-10 18:51 ` Alan Mackenzie
2023-02-10 22:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-11 7:26 ` Eli Zaretskii
2023-02-13 3:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-13 12:54 ` Eli Zaretskii
2023-02-11 11:17 ` Alan Mackenzie [this message]
2023-02-14 21:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-14 22:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-18 18:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-18 18:46 ` Alan Mackenzie
2023-02-20 22:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-15 13:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+d5RPAesoTuvdEb@ACM \
--to=acm@muc.de \
--cc=59213-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).