From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#60025: [PATCH] Add go-ts-mode and go-mod-ts-mode Date: Thu, 15 Dec 2022 19:45:45 +0000 Message-ID: References: <5HEX4A0JH8fd_VGG1FbzJ8QtBZXlHLKtuAGgc_TUHvzKCzU2Q3PYbbi3rUWeLOBoJzg0qsQgVhwGZCF86A2Xg--I2ep5d1KjKoUoHrxXpqA=@rjt.dev> <87zgbpznfa.fsf@thornhill.no> <7fPZo7wRGoWPnr5djOSL0gsOE-Q15-l2y-INvJ7z5QXOpXmV_ct4soqgJTYtHZ6EReO3ROGRS_VYnKkYNH6j1CghKfMbRXMmanEB-eaANjk=@rjt.dev> <87y1r9w2sx.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1460"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , Eli Zaretskii , 60025@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 15 20:46:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5uBc-00008m-DF for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Dec 2022 20:46:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5uBE-0005aK-08; Thu, 15 Dec 2022 14:46:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5uB8-0005Zf-UH for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 14:46:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5uB8-00052a-J8 for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 14:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5uB8-0002pz-Eq for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 14:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60025-submit@debbugs.gnu.org id=B60025.167113355910899 (code B ref 60025); Thu, 15 Dec 2022 19:46:02 +0000 Original-Received: (at 60025) by debbugs.gnu.org; 15 Dec 2022 19:45:59 +0000 Original-Received: from localhost ([127.0.0.1]:44554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5uB5-0002pj-FY for submit@debbugs.gnu.org; Thu, 15 Dec 2022 14:45:59 -0500 Original-Received: from mail-40136.proton.ch ([185.70.40.136]:56265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5uB2-0002gS-QK for 60025@debbugs.gnu.org; Thu, 15 Dec 2022 14:45:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1671133549; x=1671392749; bh=5grOQ/tjRQeP5N+O63mOGeTQeH/5ssM5PqUXcGbXYkk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=jsJ0Dhx73fOv0aETgjH4a2bfudGU+5P+dWWtqXGNfG9dGYM2RDeRopGMct36JTaOp y9zHLWvPHfxRObybcc1Y2Bv1UtwAt3CdPsCqbBj9NeLIYA+xJ1dfCS8jYYwF8S8JQX EGsVkCx57CTAehbhpQpsLicOBI1qxBPOHJj32kq84Kg5kQ5IV7d27z5kYShnrAyfYG In+HjF7tX1kQgUSZV3qSTaBiLQE7uOTrysNcw4+ZdM6UL/0Ym8dAHDkdPuKBrLCAFq f/OqN/Et3EnpDVkS5AJcgXJeqkpd77kPUDFo4FULLfoUyS5nlsUtbJq6ssAxmDZ805 /2ZGdk/fDvS8w== In-Reply-To: Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251143 Archived-At: On Thursday, December 15th, 2022 at 13:06, Theodor Thornhill wrote: >=20 > On 15 December 2022 17:40:54 CET, Randy Taylor dev@rjt.dev wrote: >=20 > > Which rules should I add? >=20 >=20 > I like to set no-indent in a comment so that indentation commands don't f= ormat. That should be fillings job, imo :) I don't know if I agree with that since the indentation commands should for= mat comments if they are formatted incorrectly.=20 Fillings as in auto-fill-mode and the fill commands? I'm not familiar with = those, beyond invoking fill-region and whatnot every now and then. I don't = think any of that stuff is on by default though, right? It all requires man= ual invocation? >=20 > > I see these rules in some of the ts modes: > > ((and (parent-is "comment") comment-end) comment-start -1) > > ((parent-is "comment") comment-start-skip 0) > >=20 > > What are they matching? When could a comment be a parent? >=20 >=20 > In some languages comment has a parent which is a comment. Just use inspe= ct-mode inside of a comment and see what makes sense :) c-ts-mode has those queries and I was never able to get a comment node as a= parent so I guess they were either copy-pasted mistakenly or I am missing = the magical invocation? Aside from the aforementioned queries, I don't see any other comment-relate= d indentation queries in any of the modes, and I can't think of any that sh= ould be introduced, at least for these modes. Patch OK to install otherwise?