From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#45502: [PATCH] Prettier key bindings in NS menu entries Date: Wed, 30 Dec 2020 13:09:02 +0000 Message-ID: References: <02937096-EAF5-4B74-A1C7-CCE6E64C67E3@acm.org> <99CD03DA-DF1F-4C2C-A2FA-DFD7DF3B2750@acm.org> <0F1B9914-2668-4775-822A-49A36D4A9F3F@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29247"; mail-complaints-to="usenet@ciao.gmane.io" To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 45502@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 30 14:10:38 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kubFM-0007US-LM for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 14:10:36 +0100 Original-Received: from localhost ([::1]:45722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kubFL-0007Ce-MX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Dec 2020 08:10:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37178) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kubEo-0007CE-Oj for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 08:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kubEn-0006sp-Th for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 08:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kubEn-0004Gc-NG for bug-gnu-emacs@gnu.org; Wed, 30 Dec 2020 08:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Dec 2020 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45502-submit@debbugs.gnu.org id=B45502.160933376516350 (code B ref 45502); Wed, 30 Dec 2020 13:10:01 +0000 Original-Received: (at 45502) by debbugs.gnu.org; 30 Dec 2020 13:09:25 +0000 Original-Received: from localhost ([127.0.0.1]:42125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kubED-0004Fd-78 for submit@debbugs.gnu.org; Wed, 30 Dec 2020 08:09:25 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:48037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kubEB-0004FL-Ba for 45502@debbugs.gnu.org; Wed, 30 Dec 2020 08:09:24 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 3A21C6008F; Wed, 30 Dec 2020 13:09:17 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1609333756; bh=gz/N+hS5BhwA7cu80DpgQfswH7MPhzqJ9+rmfjy1eQU=; h=Date:From:To:Subject:References:In-Reply-To:From; b=B5drKeFbkUSLn+08UCiz1IJUf1t1IrnIO5tulCtU3vzxYUfau6XM7F9qA4hL53rQ3 MNDaW3425rY5I+5Q0KgFn7sIAdHo606dYacRemRpeZMRAGJ3JJF85wL2itFFQuXSS7 K2fxsU9OSmz+NK9R5+CO2prhJYZuZxHYYVL7dAIkjsqpCknpIlAIzW96HYlvtQroOs NziFUkGKqEK3TJCGgrmMdiQEC33KWLPsObjTwqhR2s34khJ5Rhin0dhMcT+cUw993R 8VYQMyndbtQ7Jd1X6YTKmUZZUZg3h8LI7dfrgW9XPEd9sxM0Jj4akIkY8t4D1s0Wpm NqgUN0p1EYTdQ== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 2CD95202959EA2; Wed, 30 Dec 2020 13:09:02 +0000 (GMT) Mail-Followup-To: Alan Third , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 45502@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197025 Archived-At: On Wed, Dec 30, 2020 at 12:46:52PM +0000, Alan Third wrote: > Oh, I noticed that the Mark menu in dired has the Help menu search > entry. I guess I've missed something somewhere. I wondered if that was > set somewhere but couldn't see any reference to it so assumed macOS > was doing something clever when it saw a "Help" top level submenu... Ah, got it! modified src/nsmenu.m @@ -365,6 +365,9 @@ else submenu = [menu addSubmenuWithTitle: wv->name]; + if ([[submenu title] isEqualToString:@"Help"]) + [NSApp setHelpMenu:submenu]; + if (deep_p) [submenu fillWithWidgetValue: wv->contents]; -- Alan Third