From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#45502: [PATCH] Prettier key bindings in NS menu entries Date: Tue, 29 Dec 2020 15:50:34 +0000 Message-ID: References: <02937096-EAF5-4B74-A1C7-CCE6E64C67E3@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37731"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45502@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 29 16:53:04 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuHJ2-0009io-3J for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 16:53:04 +0100 Original-Received: from localhost ([::1]:44832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuHJ1-0002Cu-55 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 10:53:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuHH5-0001Pq-M4 for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 10:51:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuHH3-0000JP-TD for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 10:51:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuHH3-0007oY-QY for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 10:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Dec 2020 15:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45502-submit@debbugs.gnu.org id=B45502.160925704830009 (code B ref 45502); Tue, 29 Dec 2020 15:51:01 +0000 Original-Received: (at 45502) by debbugs.gnu.org; 29 Dec 2020 15:50:48 +0000 Original-Received: from localhost ([127.0.0.1]:39975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuHGq-0007nx-Cg for submit@debbugs.gnu.org; Tue, 29 Dec 2020 10:50:48 -0500 Original-Received: from outbound.soverin.net ([116.202.65.218]:53819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuHGm-0007nc-D5 for 45502@debbugs.gnu.org; Tue, 29 Dec 2020 10:50:46 -0500 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id E78966008F; Tue, 29 Dec 2020 15:50:37 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1609257037; bh=arDTpxcRmUKU5Pn6CYy87JuLXnTM9vgkNY0+RFgRRfg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ickwxBAv2f43MEWd5WH3YP531jpbeJ2oLCC0z39A43F7PN+MGSCUrqGQ+kGWGaLZZ DRnh+8/GPrVvtRJXhJUiwgLR6SoSmOE12InSUq2OOzQI6jQ7Oz7O25lPJq8+wSxx8f NApZ45YRkzrvFVoa0o3g7VGB72HpfNXNQQn00NC2Qa6DeTiphk0+xHXcLNJ3wUfPZ/ EMGXHnKE0Julvys0UHLkq1OD9q0MCSbw8lx+x8WBsqagUn86E8KVQBtWlX5RGYYmlX BMF071wI0BKEK9ZxAcYX/NcYl8S5hsW9q3N5ni03sjFp3Y/ZKzozHd4ylV/HC3zeZ8 KRPAKx6oAXYGw== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id 2CCAB20294EE56; Tue, 29 Dec 2020 15:50:35 +0000 (GMT) Mail-Followup-To: Alan Third , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 45502@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196944 Archived-At: On Tue, Dec 29, 2020 at 03:41:03PM +0100, Mattias Engdegård wrote: > 29 dec. 2020 kl. 14.53 skrev Alan Third : > > > Looks good. As I understand it GNUstep doesn't need this fix, so > > please make it Cocoa only. > > Will do, but what do you mean by not needing it -- does it do any > harm, given that GNUstep menus do not appear to be working anyway? I > have no GNUstep system to try it on so I don't know if it will even > build. As far as I'm aware GNUstep is able to display the bindings correctly no matter how many characters they have, so we don't need the work-around. And I'm hoping that we'll be able to get GNUstep menus working again in the future. I think the problem is something to do with drawing the frame rather than a problem with building the menus. But I could be wrong. > > There's also the problem that we allow setting the left and right > > modifiers separately, so option or command may not match both keys. > > That's true. Maybe a hybrid like M-↓ or C-⌫ is still fine though > since the symbols are very recognisable -- I'll give it a go. Yes, I think so. -- Alan Third