unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 45502@debbugs.gnu.org, "Daniel Martín" <mardani29@yahoo.es>
Subject: bug#45502: [PATCH] Prettier key bindings in NS menu entries
Date: Tue, 29 Dec 2020 15:50:34 +0000	[thread overview]
Message-ID: <X+tQSuwIN12UDrad@breton.holly.idiocy.org> (raw)
In-Reply-To: <BF245E93-882A-416A-A8DA-863D0CDEF422@acm.org>

On Tue, Dec 29, 2020 at 03:41:03PM +0100, Mattias Engdegård wrote:
> 29 dec. 2020 kl. 14.53 skrev Alan Third <alan@idiocy.org>:
> 
> > Looks good. As I understand it GNUstep doesn't need this fix, so
> > please make it Cocoa only.
> 
> Will do, but what do you mean by not needing it -- does it do any
> harm, given that GNUstep menus do not appear to be working anyway? I
> have no GNUstep system to try it on so I don't know if it will even
> build.

As far as I'm aware GNUstep is able to display the bindings correctly
no matter how many characters they have, so we don't need the
work-around. And I'm hoping that we'll be able to get GNUstep menus
working again in the future.

I think the problem is something to do with drawing the frame rather
than a problem with building the menus. But I could be wrong.

> > There's also the problem that we allow setting the left and right
> > modifiers separately, so option or command may not match both keys.
> 
> That's true. Maybe a hybrid like M-↓ or C-⌫ is still fine though
> since the symbols are very recognisable -- I'll give it a go.

Yes, I think so.
-- 
Alan Third





  reply	other threads:[~2020-12-29 15:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 14:23 bug#45502: [PATCH] Prettier key bindings in NS menu entries Mattias Engdegård
2020-12-28 18:36 ` Alan Third
2020-12-29 12:02   ` Mattias Engdegård
2020-12-29 13:53     ` Alan Third
2020-12-29 14:41       ` Mattias Engdegård
2020-12-29 15:50         ` Alan Third [this message]
2020-12-29 17:34           ` Mattias Engdegård
2020-12-29 21:24             ` Alan Third
2020-12-29 22:53               ` Mattias Engdegård
2020-12-29 23:49                 ` Alan Third
2020-12-30 12:19                   ` Mattias Engdegård
2020-12-30 12:46                     ` Alan Third
2020-12-30 13:09                       ` Alan Third
2020-12-30 15:53                         ` Mattias Engdegård
2020-12-30 13:12                       ` Mattias Engdegård
2020-12-28 22:46 ` Unknown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X+tQSuwIN12UDrad@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=45502@debbugs.gnu.org \
    --cc=mardani29@yahoo.es \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).