From: Alan Third <alan@idiocy.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 44333@debbugs.gnu.org,
Viktor Kharitonovich <viktor.kharitonovich@gmail.com>
Subject: bug#44333: 27.1; macOS menu bar 2-clicks
Date: Fri, 25 Dec 2020 17:26:49 +0000 [thread overview]
Message-ID: <X+Yg2S1k6HVBx2o2@breton.holly.idiocy.org> (raw)
In-Reply-To: <40B4784A-74FF-4021-B51C-2E80801483BE@acm.org>
On Fri, Dec 25, 2020 at 05:06:15PM +0100, Mattias Engdegård wrote:
> 23 dec. 2020 kl. 21.33 skrev Alan Third <alan@idiocy.org>:
>
> > OK, I've had a go at this and tried removing EVERYTHING related to the
> > delayed menu stuff and, as you say, it seems fine, but I barely ever
> > use the menus, so I could be missing something.
>
> Thank you, I tried exactly the same thing. While it works, there are
> annoying delays in dropping down the menus -- sometimes they come
> down immediately, but more often than not I get a delay of 100-300
> ms. Do you experience them too?
>
> In any case, it's a lot better than the previous double-clutch
> menus. I rarely use the menus either but partly because they were so
> annoying; I find them useful for discovering functionality and keys
> in packages. Getting rid of the delays would be nice, though.
I don't see how the delays can be new as the menus would have to be
recalculated under the old code anyway...
It is quite noticeable, though...
I notice this in the Apple docs[1]:
If populating the menu will take a long time, implement
numberOfItemsInMenu: and menu:updateItem:atIndex:shouldCancel:
instead.
I wonder if that's possible for us. ns_update_menubar is a big,
complicated function that I've not been over in depth to work out what
it's doing, so I don't know if it would be practical to break it up
like I suspect using those two methods would require.
> > For the record, the menu code (or maybe it's the toolbar, but I
> > suspect the menus) kills GNUstep builds stone dead as soon as you try
> > typing anything. It looks from the debugger like Emacs is still
> > running, but it just won't update the screen. Turning off the menus
> > appears to fix it.
>
> Maybe we could make the change conditional on GNUstep?
Sorry, I was unclear. This is an older problem. I'm not sure when it
was introduced.
[1] https://developer.apple.com/documentation/appkit/nsmenudelegate/1518235-menuneedsupdate?language=objc
--
Alan Third
next prev parent reply other threads:[~2020-12-25 17:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 17:53 bug#44333: 27.1; macOS menu bar 2-clicks Viktor Kharitonovich
2020-10-30 22:42 ` Alan Third
2020-10-31 14:08 ` Mattias Engdegård
2020-10-31 15:01 ` Alan Third
2020-11-01 10:50 ` Mattias Engdegård
2020-11-01 17:28 ` Alan Third
2020-12-23 20:33 ` Alan Third
2020-12-25 16:06 ` Mattias Engdegård
2020-12-25 17:26 ` Alan Third [this message]
2020-12-25 19:20 ` Alan Third
2020-12-25 22:28 ` Mattias Engdegård
2020-12-26 17:07 ` Alan Third
2020-12-26 17:42 ` Mattias Engdegård
2020-12-26 21:52 ` Alan Third
2020-12-27 16:56 ` Alan Third
2020-12-27 17:14 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+Yg2S1k6HVBx2o2@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=44333@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=viktor.kharitonovich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).