From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls Date: Sun, 10 Nov 2024 21:10:35 +0000 Message-ID: References: <86bjyookld.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16058"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acidbong@tilde.club, 74277@debbugs.gnu.org, Yuan Fu To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 10 22:11:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tAFDT-000431-Gy for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Nov 2024 22:11:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAFDB-0006Ej-QY; Sun, 10 Nov 2024 16:11:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAFD5-0006EU-IV for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 16:11:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAFD5-0006rP-6v for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 16:11:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=pPw4rpa2FS3aEFCl++oaFcqTeuWXGVEv7lBLsa0mFtw=; b=cz1XvS5EIUa0vTh2fa8vDl1mi+U1J7h/5vzOhTauH5Dd0EvQbc8bSKdDc/BLnPbPoaFSU4xpZ+/igHjnCsM7T3KEv8J/kZa/vcKe5hCiGEIDLCkUoP/d0Y7ad7gK9fniO7ylBtQXr/rgX2u2baoIacbG+i2xoswssp2lQPlFlMuaDGCAjHXGyKcn+DvwfHdkRVG1zu5edIp86dxGE2LtEVyK7ZwnHtwAiEseBs9LxfrGL1REDy3PiJ1jVVqqyAwcHrUwX2pe89m5fwS5OHF0BKdrcUO8PkVxp1rooF/yY1MZGUhE9SGTatsjRHST8GpKD22pgvGTh8/nxgfb4ykSug==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAFD3-00063J-SS for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2024 16:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Nov 2024 21:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74277 X-GNU-PR-Package: emacs Original-Received: via spool by 74277-submit@debbugs.gnu.org id=B74277.173127305123247 (code B ref 74277); Sun, 10 Nov 2024 21:11:01 +0000 Original-Received: (at 74277) by debbugs.gnu.org; 10 Nov 2024 21:10:51 +0000 Original-Received: from localhost ([127.0.0.1]:56866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAFCt-00062t-36 for submit@debbugs.gnu.org; Sun, 10 Nov 2024 16:10:51 -0500 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:29187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAFCo-00062Z-UO for 74277@debbugs.gnu.org; Sun, 10 Nov 2024 16:10:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1731273040; x=1731532240; bh=pPw4rpa2FS3aEFCl++oaFcqTeuWXGVEv7lBLsa0mFtw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=SI0r2GJqHRTgDp2jGxCw8NIhT3T0jjbnzZnDQtBNmKM1ZqAKegomiwx+22aCv4+cu GAlPAM4dNzpprYfhTju+NY3zpeJKpfoUSKyB3szunnhLupyNb3Slu2/6JW50R2Y9ve 4ysek6Iz8jhPHKLJG5nG78lBzaNeOTcsQjp+86ZKadZe1ygrp6/2/Dx2fo17KaQuHP gVEz1AP1ST+GFA9gvGz6Am+9v0np06tLiPCe4ABggaKXAUOfbWcwG2AuMI1ORhWNd7 VcJmebPL+DM6G/ihsu9Nk37fMnNL0m1SVXFIItFmD/r+l94hwGiXkxhZ6zGBpZrM+V j8E+6b0/VHWRA== In-Reply-To: <86bjyookld.fsf@gnu.org> Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 91f7767ddf5ce42310ccf57422c6937bfbfd67be X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295205 Archived-At: On Saturday, November 9th, 2024 at 03:52, Eli Zaretskii wrot= e: >=20 >=20 > > Date: Fri, 08 Nov 2024 20:24:07 +0000 >=20 > > From: acidbong--- via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" bug-gnu-emacs@gnu.org > >=20 > > rust-ts-mode highlights function calls when they're used in an > > assignment or as statements, but not in string formatting: > >=20 > > `println!("Some line and {}", some_function(a, b)) # ^^^^^^^^^^^^^ this= is not getting highlighted` > >=20 > > This is how it looks in Emacs (treesit-level is 4 btw): > > https://matrix.envs.net/_matrix/media/r0/download/envs.net/66652827fc75= 45e57d2eef263ee28ef6bc2ef1c01854976160883015680 > >=20 > > This is how it looks in Neovim (with treesitter highlighting on): > > https://matrix.envs.net/_matrix/media/r0/download/envs.net/382a104ee3e6= e4dacabebfa7f84f4b9b7231b1171854976151936565248 > >=20 > > ----------------------------------- >=20 >=20 > Thanks. >=20 > Randy/Yuan, any suggestions or fixes? This was discussed briefly awhile back, but it's basically going to require special handling because macro invocations don't give us the usual dead simple way of doing it. Maybe it's easy enough to see if the identifier has parentheses immediately following it... I probably won't have a chance to take a crack at it anytime soon, so if anyone wants to beat me to it, feel free.