From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Simon Lang Newsgroups: gmane.emacs.bugs Subject: bug#41766: Make it possible to change regexp to identify and highlight grep matches via customization Date: Wed, 10 Jun 2020 21:11:09 +0000 Message-ID: References: <87h7vkihci.fsf@tcd.ie>,<833674710g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_002_VI1PR10MB2800B2C5F05EE46D4D71180080830VI1PR10MB2800EURP_" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="60436"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "41766@debbugs.gnu.org" <41766@debbugs.gnu.org>, "dgutov@yandex.ru" , "juri@linkov.net" To: Eli Zaretskii , "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 10 23:12:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jj814-000Ff3-RF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jun 2020 23:12:10 +0200 Original-Received: from localhost ([::1]:58934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj813-0001vd-Dj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jun 2020 17:12:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj80w-0001t6-3h for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 17:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52174) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jj80v-0005rH-Q4 for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 17:12:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jj80v-00043T-K5 for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 17:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simon Lang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jun 2020 21:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41766 X-GNU-PR-Package: emacs Original-Received: via spool by 41766-submit@debbugs.gnu.org id=B41766.159182348015525 (code B ref 41766); Wed, 10 Jun 2020 21:12:01 +0000 Original-Received: (at 41766) by debbugs.gnu.org; 10 Jun 2020 21:11:20 +0000 Original-Received: from localhost ([127.0.0.1]:35487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj80F-00042L-JS for submit@debbugs.gnu.org; Wed, 10 Jun 2020 17:11:19 -0400 Original-Received: from mail-oln040092073049.outbound.protection.outlook.com ([40.92.73.49]:37766 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj80D-000427-D3 for 41766@debbugs.gnu.org; Wed, 10 Jun 2020 17:11:18 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iksSSu8RIyNvOfOCH38Z63CgDWPe4kdz/WCdRBEj+8FeDYEzKAgVNqgx5/7mw03sOojQOrk8dfJXPL7hZJcvbxynsWWgc72YJzuVW8YrDb8pjPfm9nSqY5PKSsZH66cTdcjjwZLdp7tcArW6wbjBu8Nrg1ILf+xYPlaHScVlrNOpOA/sj1onTAd9/GRxkPNCYeGUaUVJR945jsa0N8ANYGf2G2bFTnbyPVYJzxwcNE01xewakQu5aa/XnLjoVcSP9kSR3ZMbSj9yKHcrURxdI3RwhDb6Uihfj8Hgqx7v3ZwD1DtCqhTfcNLTOeOK/s1CL+sBV42SGt3iOrTUBvmKFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SnNsvgTqkTLh3BMQzoZykEaeUdc8oO/nqVMsBWcIEfw=; b=QcvWeNkLilzmKW36aaEc/SHMSb+gTRcCAhQRXoYVM8Zbk8EPywELMHm2AMN+GPLgki5oP3uFev5vePsZdFQzS5xcNXbvcT9/gjgwPYnPWYC5RKdNPyBZmLu7biNtslGb+qfim5FNHirg5Liq89Fm20ljYsvZVV0RYg+TxoJroRSmpWE6uVyCgODfq4DA1FbLBsIw3UWRr6PvQh94bK57I1wiP3aUD3zc6uqu93PgeaY/KiqLlsUJaDu52B8oNsJWibliBs3sZIYwM4AONVM3jOrdeWCvVrFm2FFlBBgt42EkJ2dt/9Cf0k1p08FyKx6PIbkEKAp2kv7KgOTykZmQwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SnNsvgTqkTLh3BMQzoZykEaeUdc8oO/nqVMsBWcIEfw=; b=XI8Z52t+a3fPMA0sQlFS7BLARBok2JCTAwJhugVczt7IbJ5oL6pyE9tk0EtIIMhxJ3ouhQENOnHLw+v2d3pi/luGbTT1CddDsm6/4h6Y8MaXfLHSZ3vJF46YRexSVRPp9mffmEOXsM53Cz+6Z5RlyhgH5K2q21bQg9eWDj8KFC6m8JPuL3BOZvHXSDI7NcJEoiHHShEOPC79z4ZMtINiQFudYTLUCqhk+9vNRaTd3/vv7qJKG3rdTeC/iDBEJ+b0/DpOVqJR1mpZj2noZzpkYy1GWSoR7cK4YmDaizdgV7gLjUapv46/BDlzHxR2LUrIW4OOwMIhqKOMh9EBS+OBOw== Original-Received: from HE1EUR04FT022.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0d::4c) by HE1EUR04HT022.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0d::180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Wed, 10 Jun 2020 21:11:10 +0000 Original-Received: from VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:7e0d::43) by HE1EUR04FT022.mail.protection.outlook.com (2a01:111:e400:7e0d::281) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18 via Frontend Transport; Wed, 10 Jun 2020 21:11:10 +0000 Original-Received: from VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM ([fe80::c45e:a27a:903e:c357]) by VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM ([fe80::c45e:a27a:903e:c357%7]) with mapi id 15.20.3066.023; Wed, 10 Jun 2020 21:11:09 +0000 Thread-Topic: bug#41766: Make it possible to change regexp to identify and highlight grep matches via customization Thread-Index: AQHWPc/RG0xiM+LeYUGktgGhL6/KlKjPcrmAgAB2jTSAAETYFYAALx5ggAH8/gw= In-Reply-To: <833674710g.fsf@gnu.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: yes x-incomingtopheadermarker: OriginalChecksum:7E5F75550FCD9465176FA0D6094037F31CFDE80EEF1F23A2D6832110E9CD3556; UpperCasedChecksum:438FE4B293E08C2D9F637C7AE1419A8285A92273EEEFDB5E23F912255B1F1898; SizeAsReceived:7388; Count:46 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [I7Yo3w0LjZ5Yl2J+XMiH9R92QCLaDxig] x-ms-publictraffictype: Email x-incomingheadercount: 46 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: beb4accd-faec-4b32-a323-08d80d82cc71 x-ms-traffictypediagnostic: HE1EUR04HT022: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ASLjLKPoI28OzlmXQnVlwBSPlRpbAnIseoSmCz5N8JBRRztCF2do42nDXsBHSw6vwDOAlURpjQwOD1LzJbUlm5wVjfeMEsr0RlljYSAlDZwOtjN5WOu0rt8292Oj87kLA3QxzvdAEPuXu9/7ouL9Es2rqKqfpLYHzK3MahEJCYkXtN4DGcHSn0FuVfAl3ZuIZo5ay5s5QIN0688MRG9bHQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR10MB2800.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; x-ms-exchange-antispam-messagedata: FIW/TcgmRE2o/y3//oK8syV96eCgLdnPnQoC1H0ykc2+bwj8dS53hr/VMG3+354PD9evLpkUpb3EHfu7re2fKHOkmwCydqHOmNFOdf1ATR9HC7Lt3ezethL16VRtGnmOYvqpoy+9I5VO4UlBl7Vm3w== x-ms-exchange-transport-forked: True X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: beb4accd-faec-4b32-a323-08d80d82cc71 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2020 21:11:09.8694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR04HT022 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181831 Archived-At: --_002_VI1PR10MB2800B2C5F05EE46D4D71180080830VI1PR10MB2800EURP_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, I now something to the manual, NEWS and changed the doc string + commit msg= as advised. I decided on defcustom in the end because this way it is easy = for the user to figure out what goes wrong in case he/she modifies grep-com= mand and highlighting is missing. Hope that is fine. Pls let me know if there is anything else I need to change. Thanks! ________________________________________ From: Eli Zaretskii Sent: 09 June 2020 15:43 To: Basil L. Contovounesios Cc: Simon.lang@outlook.com; 41766@debbugs.gnu.org; dgutov@yandex.ru; juri@l= inkov.net Subject: Re: bug#41766: Make it possible to change regexp to identify and h= ighlight grep matches via customization > From: "Basil L. Contovounesios" > Date: Tue, 09 Jun 2020 12:55:25 +0100 > Cc: "41766@debbugs.gnu.org" <41766@debbugs.gnu.org>, > Dmitry Gutov , Juri Linkov > > I wonder, though: the default value matches some quite obscure codes > which aren't (and maybe shouldn't be) documented, so is a defcustom > really suitable for this? They are SGR escape sequences that Grep emits to color its output. We should probably mention that in the doc string. --_002_VI1PR10MB2800B2C5F05EE46D4D71180080830VI1PR10MB2800EURP_ Content-Type: application/octet-stream; name="0001-lisp-progmodes-grep.el-grep-match-regexp-New-variabl.patch" Content-Description: 0001-lisp-progmodes-grep.el-grep-match-regexp-New-variabl.patch Content-Disposition: attachment; filename="0001-lisp-progmodes-grep.el-grep-match-regexp-New-variabl.patch"; size=3140; creation-date="Wed, 10 Jun 2020 21:10:23 GMT"; modification-date="Wed, 10 Jun 2020 21:10:23 GMT" Content-Transfer-Encoding: base64 RnJvbSBiY2M4MzllN2M0N2ZhZmI2NmVhYzc1NjIzZDc1ODEyMmI3ZTlmZWQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTaW1vbiBMYW5nIDxzaW1vbi5sYW5nQG91dGxvb2suY29tPgpE YXRlOiBXZWQsIDEwIEp1biAyMDIwIDIyOjAxOjAyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gKiBs aXNwL3Byb2dtb2Rlcy9ncmVwLmVsIChncmVwLW1hdGNoLXJlZ2V4cCk6IE5ldyB2YXJpYWJsZS4K IChncmVwLWZpbHRlcik6IFVzZSBpdC4KCi0tLQogZG9jL2VtYWNzL2J1aWxkaW5nLnRleGkgfCA0 ICsrKysKIGV0Yy9ORVdTICAgICAgICAgICAgICAgIHwgOCArKysrKysrKwogbGlzcC9wcm9nbW9k ZXMvZ3JlcC5lbCAgfCA5ICsrKysrKysrLQogMyBmaWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL2J1aWxkaW5nLnRleGkg Yi9kb2MvZW1hY3MvYnVpbGRpbmcudGV4aQppbmRleCA3MDc0YmQ0NWQ3Li5mYjEzNzM4YmM0IDEw MDY0NAotLS0gYS9kb2MvZW1hY3MvYnVpbGRpbmcudGV4aQorKysgYi9kb2MvZW1hY3MvYnVpbGRp bmcudGV4aQpAQCAtNDMyLDYgKzQzMiwxMCBAQCBtYXJrZXJzIGFyb3VuZCBtYXRjaGVzIGZvciB0 aGUgcHVycG9zZSBvZiBoaWdobGlnaHRpbmcuICBZb3UgY2FuIG1ha2UKIHVzZSBvZiB0aGlzIGZl YXR1cmUgYnkgc2V0dGluZyBAY29kZXtncmVwLWhpZ2hsaWdodC1tYXRjaGVzfSB0bwogQGNvZGV7 dH0uICBXaGVuIGRpc3BsYXlpbmcgYSBtYXRjaCBpbiB0aGUgc291cmNlIGJ1ZmZlciwgdGhlIGV4 YWN0CiBtYXRjaCB3aWxsIGJlIGhpZ2hsaWdodGVkLCBpbnN0ZWFkIG9mIHRoZSBlbnRpcmUgc291 cmNlIGxpbmUuCitIaWdobGlnaHRpbmcgaXMgcHJvdmlkZWQgdmlhIG1hdGNoaW5nIG9mIEFOU0kg ZXNjYXBlIHNlcXVlbmNlcyBlbWl0dGVkCitieSBncmVwLiAgVGhlIG1hdGNoaW5nIG9mIHRoZSBz ZXF1ZW5jZXMgaXMgY29udHJvbGxlZCBieQorQGNvZGV7Z3JlcC1tYXRjaC1yZWdleHB9LCB3aGlj aCBjYW4gYmUgY3VzdG9taXplIHRvIGFjY29tbW9kYXRlCitkaWZmZXJlbnQgZ3JlcCBwcm9ncmFt cy4KIAogICBBcyB3aXRoIGNvbXBpbGF0aW9uIGNvbW1hbmRzIChAcHhyZWZ7Q29tcGlsYXRpb259 KSwgd2hpbGUgdGhlIGdyZXAKIGNvbW1hbmQgcnVucywgdGhlIG1vZGUgbGluZSBzaG93cyB0aGUg cnVubmluZyBudW1iZXIgb2YgbWF0Y2hlcyBmb3VuZApkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9l dGMvTkVXUwppbmRleCBiMGM1MjM2NzJlLi4xMjViN2M3Y2VjIDEwMDY0NAotLS0gYS9ldGMvTkVX UworKysgYi9ldGMvTkVXUwpAQCAtMTc2LDYgKzE3NiwxNCBAQCB3YXMgc2VudC4gIFRvIHJlc3Rv cmUgdGhlIG9yaWdpbmFsIGJlaGF2aW9yIG9mIGRhdGluZyBhIG1lc3NhZ2UKIGZyb20gd2hlbiBp dCBpcyBmaXJzdCBzYXZlZCBvciBkZWxheWVkLCBhZGQgdGhlIHN5bWJvbCAnRGF0ZScgYmFjayB0 bwogdGhpcyB1c2VyIG9wdGlvbi4KIAorKiogR3JlcCBjaGFuZ2VzOgorCisqKiogTmV3IHZhcmlh YmxlICdncmVwLW1hdGNoLXJlZ2V4cCcgbWF0Y2hlcyBncmVwIG1hcmtlcnMgdG8gaGlnaGxpZ2h0 LgorR3JlcCBlbWl0cyBTR1IgQU5TSSBlc2NhcGUgc2VxdWVuY2VzIHRvIGNvbG9yIGl0cyBvdXRw dXQuIFRoZSBuZXcgdmFyaWFibGUKKydncmVwLW1hdGNoLXJlZ2V4cCcgaG9sZHMgdGhlIHJlZ3Vs YXIgZXhwcmVzc2lvbiB0byBtYXRjaCB0aGUgYXBwcm9wcmlhdGUKK21hcmtlcnMgaW4gb3JkZXIg dG8gcHJvdmlkZSBoaWdobGlnaHRpbmcgaW4gdGhlIHNvdXJjZSBidWZmZXIuIFRoZSB2YXJpYWJs ZQorY2FuIGJlIGN1c3RvbWl6ZWQgdG8gYWNjb21tb2RhdGUgb3RoZXIgZ3JlcC1saWtlIHRvb2xz LgorCiAqKiBIZWxwCiAKICsrKwpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvZ3JlcC5lbCBi L2xpc3AvcHJvZ21vZGVzL2dyZXAuZWwKaW5kZXggNzczMWJlNTk2NS4uMzJiN2E1OTdjZiAxMDA2 NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvZ3JlcC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9ncmVw LmVsCkBAIC0xMDAsNiArMTAwLDEzIEBAIFRvIGNoYW5nZSB0aGUgZGVmYXVsdCB2YWx1ZSwgdXNl IFxcW2N1c3RvbWl6ZV0gb3IgY2FsbCB0aGUgZnVuY3Rpb24KICAgOnNldCAjJ2dyZXAtYXBwbHkt c2V0dGluZwogICA6dmVyc2lvbiAiMjIuMSIpCiAKKyhkZWZjdXN0b20gZ3JlcC1tYXRjaC1yZWdl eHAgIlwwMzNcXFswPzE7MzFtXFwoLio/XFwpXDAzM1xcW1swLTldKm0iCisgICJSZWd1bGFyIGV4 cHJlc3Npb24gbWF0Y2hpbmcgZ3JlcCBtYXJrZXJzIHRvIGhpZ2hsaWdodC4KK0l0IG1hdGNoZXMg U0dSIEFOU0kgZXNjYXBlIHNlcXVlbmNlcyB3aGljaCBhcmUgZW1pdHRlZCBieSBncmVwIHRvCitj b2xvciBpdHMgb3V0cHV0LiBUaGlzIHZhcmlhYmxlIGlzIHVzZWQgaW4gYGdyZXAtZmlsdGVyJy4i CisgIDp0eXBlICdyZWdleHAKKyAgOnZlcnNpb24gIjI4LjEiKQorCiAoZGVmY3VzdG9tIGdyZXAt c2Nyb2xsLW91dHB1dCBuaWwKICAgIk5vbi1uaWwgdG8gc2Nyb2xsIHRoZSAqZ3JlcCogYnVmZmVy IHdpbmRvdyBhcyBvdXRwdXQgYXBwZWFycy4KIApAQCAtNTg0LDcgKzU5MSw3IEBAIFRoaXMgZnVu Y3Rpb24gaXMgY2FsbGVkIGZyb20gYGNvbXBpbGF0aW9uLWZpbHRlci1ob29rJy4iCiAgICAgICAo d2hlbiAoPCAocG9pbnQpIGVuZCkKICAgICAgICAgKHNldHEgZW5kIChjb3B5LW1hcmtlciBlbmQp KQogICAgICAgICA7OyBIaWdobGlnaHQgZ3JlcCBtYXRjaGVzIGFuZCBkZWxldGUgbWFya2luZyBz ZXF1ZW5jZXMuCi0gICAgICAgICh3aGlsZSAocmUtc2VhcmNoLWZvcndhcmQgIlwwMzNcXFswPzE7 MzFtXFwoLio/XFwpXDAzM1xcW1swLTldKm0iIGVuZCAxKQorICAgICAgICAod2hpbGUgKHJlLXNl YXJjaC1mb3J3YXJkIGdyZXAtbWF0Y2gtcmVnZXhwIGVuZCAxKQogICAgICAgICAgIChyZXBsYWNl LW1hdGNoIChwcm9wZXJ0aXplIChtYXRjaC1zdHJpbmcgMSkKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAnZmFjZSBuaWwgJ2ZvbnQtbG9jay1mYWNlIGdyZXAtbWF0Y2gtZmFj ZSkKICAgICAgICAgICAgICAgICAgICAgICAgICB0IHQpCi0tIAoyLjIxLjAgKEFwcGxlIEdpdC0x MjIpCgo= --_002_VI1PR10MB2800B2C5F05EE46D4D71180080830VI1PR10MB2800EURP_--