unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Arthur Miller <arthur.miller@live.com>
To: Andrea Corallo <akrl@sdf.org>
Cc: 42010@debbugs.gnu.org, Doug Davis <ddavis@ddavis.io>
Subject: bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el
Date: Tue, 23 Jun 2020 08:44:20 +0200	[thread overview]
Message-ID: <VI1PR06MB45260D7108C356FBB13CEC9E96940@VI1PR06MB4526.eurprd06.prod.outlook.com> (raw)
In-Reply-To: <xjfmu4uu3j1.fsf@sdf.org> (Andrea Corallo's message of "Mon, 22 Jun 2020 22:41:38 +0000")

Andrea Corallo <akrl@sdf.org> writes:

> Doug Davis <ddavis@ddavis.io> writes:
>
>> When running `gnus' with a native compiled Emacs build a message is
>> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
>> is called. I'm not sure what check is possible to see if a function is
>> natively compiled, but perhaps it should be added to this logic in
>> gnus.el:
>>
>>   (unless (byte-code-function-p (symbol-function 'gnus))
>>     (message "You should byte-compile Gnus")
>>     (sit-for 2))
>
> I'll admint that added to my undenaiable laziness I probably skiped this
> for so long cause was giving me a tiny satisfaction :)
>
> Should be fixed by:
>
> 801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
> compilation.
>
> Thanks for the feedback
>
>   Andrea
Just rebuild my Emacs and can confirm it if fixed.

Build time seems to be even faster (on my 67k i7 cpu with -j8 switch).

Awesome, thanks Andrea!





  reply	other threads:[~2020-06-23  6:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22 20:52 bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el Doug Davis
2020-06-22 22:41 ` Andrea Corallo
2020-06-23  6:44   ` Arthur Miller [this message]
2020-06-23  7:48     ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR06MB45260D7108C356FBB13CEC9E96940@VI1PR06MB4526.eurprd06.prod.outlook.com \
    --to=arthur.miller@live.com \
    --cc=42010@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    --cc=ddavis@ddavis.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).