From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu Date: Thu, 09 Mar 2023 02:04:21 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_hCK6mG8OUR9tqz1CuiNzRGkL8oFeUvJOCuvALHBlFU" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7153"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62043@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 09 03:05:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pa5eq-0001dD-LQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Mar 2023 03:05:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pa5eX-0008N1-SD; Wed, 08 Mar 2023 21:05:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pa5eT-0008Mc-VV for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2023 21:05:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pa5eQ-00066I-Gc for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2023 21:05:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pa5eP-0004A3-Vt for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2023 21:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Mar 2023 02:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62043 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62043-submit@debbugs.gnu.org id=B62043.167832748515965 (code B ref 62043); Thu, 09 Mar 2023 02:05:01 +0000 Original-Received: (at 62043) by debbugs.gnu.org; 9 Mar 2023 02:04:45 +0000 Original-Received: from localhost ([127.0.0.1]:50508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pa5e8-00049R-OA for submit@debbugs.gnu.org; Wed, 08 Mar 2023 21:04:44 -0500 Original-Received: from mail-4317.proton.ch ([185.70.43.17]:37421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pa5e5-00049A-6e for 62043@debbugs.gnu.org; Wed, 08 Mar 2023 21:04:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1678327474; x=1678586674; bh=mqeNy+ovk4XaM2whVnJEoyc0Ek7G2gysTR3opMANilk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=mBi1K0v+7z8akz62CSoDcFb8uLiJCqqVZItEWe1u2LwK2bvk+qUtcwhPFFBP35H3u WNBBzZOVSXI0wKUFQU7L6olBXntmIVpRiA7jbhYVablQVjzN8O93Wy13WzBvdnRhtJ joHIBG3yMXqumP33XjPbxVEZ4/dcep9sHckC9SYfsiAzXbZQtQLUGAhYtqy7NJcSVM PF9dE8Ve+nin66CoeJ6yMek4kO5uDzKstVQQuB4m/snLQCn2Y3ZM5FXsX1hawSsh7J 7CnXzAo36juhD3vFRre8cMjJJ7l8zYq1u1iNNXTC7L56fYIEaYTgvOZpBvcQ8AnZfz b4o5AhP9hRjdA== In-Reply-To: Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257575 Archived-At: This is a multi-part message in MIME format. --b1_hCK6mG8OUR9tqz1CuiNzRGkL8oFeUvJOCuvALHBlFU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wednesday, March 8th, 2023 at 18:27, Yuan Fu wrote: >=20 > > On Mar 7, 2023, at 5:49 PM, Randy Taylor dev@rjt.dev wrote: > >=20 > > X-Debbugs-CC: casouri@gmail.com > >=20 > > With {c, c++}-ts-mode, enums appear as structs in imenu. The attached p= atch fixes this. > >=20 > > Example: > > enum Thing { A, B, C }; > >=20 > > Should appear as Enum Thing > > <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch> >=20 >=20 > Thanks! I wonder what determines which categories to merge together and w= hich to not? If we separate Enums, should we also separate Unions? >=20 > Yuan I think they should all be separate actually. Attached a patch that does so= . --b1_hCK6mG8OUR9tqz1CuiNzRGkL8oFeUvJOCuvALHBlFU Content-Type: text/x-patch; name=0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-enums-and-unions-appearing-as-structs-in-c-ts-ba.patch RnJvbSBjOWIzMTA0YTRjY2EyZTkyMWZkNjM0MGE5OTFjNTYwMWMxYWU2YTMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBUdWUs IDcgTWFyIDIwMjMgMjA6Mzg6MTggLTA1MDAKU3ViamVjdDogW1BBVENIXSBGaXggZW51bXMgYW5k IHVuaW9ucyBhcHBlYXJpbmcgYXMgc3RydWN0cyBpbiBjLXRzLWJhc2UtbW9kZSdzCiBpbWVudQoK KiBsaXNwL3Byb2dtb2Rlcy9jLXRzLW1vZGUuZWwgKGMtdHMtYmFzZS1tb2RlKTogU2VwYXJhdGUg ZW51bXMgYW5kIHVuaW9ucyBvdXQKZnJvbSBzdHJ1Y3RzLgotLS0KIGxpc3AvcHJvZ21vZGVzL2Mt dHMtbW9kZS5lbCB8IDYgKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAz IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5lbCBi L2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5lbAppbmRleCBmZGQ5NjJmZjAyMC4uZmY4NmI5ZTA1 NDQgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5lbAorKysgYi9saXNwL3By b2dtb2Rlcy9jLXRzLW1vZGUuZWwKQEAgLTkzMCw5ICs5MzAsOSBAQCBjLXRzLWJhc2UtbW9kZQog ICA7OyBJbWVudS4KICAgKHNldHEtbG9jYWwgdHJlZXNpdC1zaW1wbGUtaW1lbnUtc2V0dGluZ3MK ICAgICAgICAgICAgICAgKGxldCAoKHByZWQgIydjLXRzLW1vZGUtLWRlZnVuLXZhbGlkLXApKQot ICAgICAgICAgICAgICAgIGAoKCJTdHJ1Y3QiICwocnggYm9zIChvciAic3RydWN0IiAiZW51bSIg InVuaW9uIikKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJfc3BlY2lmaWVyIiBl b3MpCi0gICAgICAgICAgICAgICAgICAgLHByZWQgbmlsKQorICAgICAgICAgICAgICAgIGAoKCJF bnVtIiAiXFxgZW51bV9zcGVjaWZpZXJcXCciICxwcmVkIG5pbCkKKyAgICAgICAgICAgICAgICAg ICgiU3RydWN0IiAiXFxgc3RydWN0X3NwZWNpZmllclxcJyIgLHByZWQgbmlsKQorICAgICAgICAg ICAgICAgICAgKCJVbmlvbiIgIlxcYHVuaW9uX3NwZWNpZmllclxcJyIgLHByZWQgbmlsKQogICAg ICAgICAgICAgICAgICAgKCJWYXJpYWJsZSIgLChyeCBib3MgImRlY2xhcmF0aW9uIiBlb3MpICxw cmVkIG5pbCkKICAgICAgICAgICAgICAgICAgICgiRnVuY3Rpb24iICJcXGBmdW5jdGlvbl9kZWZp bml0aW9uXFwnIiAscHJlZCBuaWwpCiAgICAgICAgICAgICAgICAgICAoIkNsYXNzIiAsKHJ4IGJv cyAob3IgImNsYXNzX3NwZWNpZmllciIKLS0gCjIuMzkuMgoK --b1_hCK6mG8OUR9tqz1CuiNzRGkL8oFeUvJOCuvALHBlFU--