From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ramesh Nedunchezian Newsgroups: gmane.emacs.bugs Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Date: Sat, 10 Apr 2021 14:08:50 +0530 Message-ID: References: <87pmz8lc17.fsf@mail.linkov.net> <9453a08f-5014-b4bc-8472-a4c2ff44c687@yandex.ru> <87o8eo38q9.fsf@mail.linkov.net> <7f1b570f-ea1b-5524-59fa-83bb5eaa9abd@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4348"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 Cc: 47566-done@debbugs.gnu.org To: Dmitry Gutov , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 10 10:40:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lV9A8-00010q-ET for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Apr 2021 10:40:16 +0200 Original-Received: from localhost ([::1]:57202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lV9A7-0006MV-Cv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Apr 2021 04:40:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lV99u-0006Lf-Re for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2021 04:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lV99u-0007Im-JB for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2021 04:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lV99u-0005YA-Fe for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2021 04:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ramesh Nedunchezian Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Apr 2021 08:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47566 X-GNU-PR-Package: emacs Original-Received: via spool by 47566-done@debbugs.gnu.org id=D47566.161804395921279 (code D ref 47566); Sat, 10 Apr 2021 08:40:02 +0000 Original-Received: (at 47566-done) by debbugs.gnu.org; 10 Apr 2021 08:39:19 +0000 Original-Received: from localhost ([127.0.0.1]:51406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lV99C-0005X9-Qg for submit@debbugs.gnu.org; Sat, 10 Apr 2021 04:39:19 -0400 Original-Received: from mail-oln040092253035.outbound.protection.outlook.com ([40.92.253.35]:6120 helo=APC01-SG2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lV99A-0005Wt-K8 for 47566-done@debbugs.gnu.org; Sat, 10 Apr 2021 04:39:17 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CNaXBF4lZEkINEuDvU3IFH2W1T0oKzVQaXoF6Vp2fga6BuWFnvvoOETKygYQMA0hRwjAo65YQ182QKAo/jQlwSQp0D9ukGfMAX/m0zI6b7KkzW8EATrpBY7xt6H90GtQ7YdZNUOxddMU0jQzC+NDxl+DPQT32Cu4/x178Om4o3NORPhXY0RGUkXskbeCz8EKwIRLu6TpsGKtkO6SNtEQ0aqIHS+VTfRl8abvm2F4I9rjL5Oq4gN5u8lee6YwFnp5ozelHQrmbur6zDQq9V59LLVymlajEFxZdEVFJPOnrBTIX66BTOQ2egLZk2QQ/KTGNgYiXpSXNcPZyj1ZQ+UeRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zoWWqWtRPD6MNtC8dxbCu1Y/jU73pt4Q0Gt6k7vMYEU=; b=XMmm0bOQ0pUtg2kX3BsdTmIH9pR4Wn/l5ASuY/u7OrRi+YdlN0yG1tEPeQrfTRp4wWf9NQaUoMHSILTV3KRgRGVJyjJmzaNqadX8x1xdBJIn03bOtawu3oz849qZpJy9u4HJNWXrzZu7Y1zQicgN5aVJb4qIQT1jCod13UTiZcjO3YCxc35JowTOQP/09CV2gHx9O99gi+Jb2oXB2Xmg+s24eN8W+XAQkK362qLcNeS1RtLt3IN4wJ14KEP+grWvFI9M7eFcvCYM9RnYO+6dypbfRzu4u0By+Va8qTka/k/RQppszepV3Fxo/1Msd7Vyb6raCaHoRMLTMAQPVzhbcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zoWWqWtRPD6MNtC8dxbCu1Y/jU73pt4Q0Gt6k7vMYEU=; b=CDdPSMxdd84azpYl4m0BXawDhNsd9P+Mv3ZzJmz0zsPHXcnbF0L+eWgiHWX8Gvtyh38GTPPHPkcZng7HqhwFZuy7sfbZDwdqAhcCauYZLb5etXuRJjVBkwWN/yuH22Bhve8fqTGsAy3YG+qC8V9uV8bc4IGjz4MbV+tkG1f9KYKVEjI2h0Y3wW2Wo6nDZ3Cm6+Sjs2z9oaXMBFDoY+jwXZ+/ca7LkRpb75qf+32V+ZPx37CEO261rFws+/hDExxoNDIDx75MORVOBz8rOC0HBHkHH0oO0+wJTSd+KvSOM8sEsQRPwmBiBr60QaSrMSGmk7iN4JVBUTBTwbRwVW/6UQ== Original-Received: from TY2PR0101MB3693.apcprd01.prod.exchangelabs.com (2603:1096:404:800f::16) by TYZPR01MB4015.apcprd01.prod.exchangelabs.com (2603:1096:400:3e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Sat, 10 Apr 2021 08:39:02 +0000 Original-Received: from TY2PR0101MB3693.apcprd01.prod.exchangelabs.com ([fe80::4980:4d7f:474b:de2c]) by TY2PR0101MB3693.apcprd01.prod.exchangelabs.com ([fe80::4980:4d7f:474b:de2c%3]) with mapi id 15.20.4020.018; Sat, 10 Apr 2021 08:38:56 +0000 In-Reply-To: <7f1b570f-ea1b-5524-59fa-83bb5eaa9abd@yandex.ru> Content-Language: en-US X-TMN: [ouGSFi3SBeiSy3gUQ2cWCYrtzfGv59+7vGgjD24v9wbt3fTXvSi8oGP3tJ9AVMULk/S+5eLQw4w=] X-ClientProxiedBy: MAXPR0101CA0035.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::21) To TY2PR0101MB3693.apcprd01.prod.exchangelabs.com (2603:1096:404:800f::16) X-Microsoft-Original-Message-ID: <5bb41686-fa49-3e7f-2bb4-571df9019e47@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from [IPv6:2401:4900:330d:5d93:fc95:fa5e:bce5:8b48] (2401:4900:330d:5d93:fc95:fa5e:bce5:8b48) by MAXPR0101CA0035.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16 via Frontend Transport; Sat, 10 Apr 2021 08:38:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bdb8c24e-db7e-4db9-2bf5-08d8fbfc1450 X-MS-TrafficTypeDiagnostic: TYZPR01MB4015: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AdygAaZL+6P6mdwdqwnxnKSTVmfWoP9834UPloVaO3lA5QiwKNNDOEgE2EN8M/0k+O9fOwNslnfNro4JmMQ5coYOpry/4W5xiVa12fGUCg5PN+uyyhgO3GeUVsWtwNN0D/FzEZYlq77WO8xBrd+HpyaDOOwXygsn1NYsQGvtfXORgS+vk2tePjT7ISi2Z/KgiXiZ39tXhi/VRgaXBfbogk1sHKy/e1JX3xXFdqtMvk5c8173e7oZTsvuv1kHJlqLvuSqA8fnV7UgKkGBek1yFBmg4x2bLL8MoepIHttaVsnsK5hJs3/wY5BtsNDJ/ieWFCXWGUMLuwOw3PgeH2/5aWy/w4+Fs013Tjzcp+O2fCMhAk8BNOfvMpTj+0o/W6KxylU58aMY07luxw77PHbWlnMwJ+ve4J/4mWWSZbNI9xezAYOqibqPaUHXNpkJK7z3 X-MS-Exchange-AntiSpam-MessageData: /+XWVzHJzHoTrjUANRNFUNlI6Wl46wuRYv63WH2c/OXR/tiZ0G1s0tj6PUotRC56pc07bOEyN4vjPmTOWSrkM98vNQwzKs3d9t35ezFmn3/ez21Rl3V6cqGnD/9Xfl1KHFfvgUVJ4MSUsZx8F9PFNmGoLecyq3Tc42CVTRqEknaMbFmqkwooptpvKTc7un85rueK2wOmt26wAfeOo++a+Q== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdb8c24e-db7e-4db9-2bf5-08d8fbfc1450 X-MS-Exchange-CrossTenant-AuthSource: TY2PR0101MB3693.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2021 08:38:56.7120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR01MB4015 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203787 Archived-At: On 10/04/21 7:10 am, Dmitry Gutov wrote: > (*) Though the first impression, in comparison, was that it is too chatty. The hints are definitely helpful for discovery at first, though. > > Maybe something like this would be an improvement? Experimental code warning. > > diff --git a/lisp/repeat.el b/lisp/repeat.el > index b3c58f2f81..e704e4da56 100644 > --- a/lisp/repeat.el > +++ b/lisp/repeat.el > @@ -404,7 +404,7 @@ repeat-post-hook > (key-description repeat-exit-key)) > "")))) > (if (current-message) > - (message "%s [%s]" (current-message) mess) > + (message #("%s [%s]" 3 7 (face deemphasized)) (current-message) mess) > (message mess)))) > > ;; Adding an exit key I created a repeat map for rectangle commands, and the echo area becomes much more chattier. See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=47688. It seems to me that repeat-mode is essentially a poor man's hydra. May be the the symbol that holds the repeat map can specify a `:help'-er property. This `:help'-er can either (a) give a fancy help string which the `repet-mode' can display in a pop-up or (b) the helper itself can prepare the string and arrange for providing a pop-up. What I am saying is let the repeat map provide it's own `:help'-er which the `repeat-mode' can hook in to.