From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ramesh Nedunchezian Newsgroups: gmane.emacs.bugs Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Date: Fri, 2 Apr 2021 11:10:13 +0530 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30621"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 To: 47566@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 02 16:51:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSL8s-0007sR-TY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Apr 2021 16:51:23 +0200 Original-Received: from localhost ([::1]:51504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSL8r-0004jq-Us for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Apr 2021 10:51:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSL8Y-0004iO-Sz for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 10:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49324) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSL8Y-0006f9-IT for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 10:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lSL8Y-0000vQ-Fq for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 10:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ramesh Nedunchezian Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Apr 2021 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47566 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16173750583542 (code B ref -1); Fri, 02 Apr 2021 14:51:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Apr 2021 14:50:58 +0000 Original-Received: from localhost ([127.0.0.1]:60870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSL8I-0000up-AD for submit@debbugs.gnu.org; Fri, 02 Apr 2021 10:50:58 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSCXv-0007cZ-Mw for submit@debbugs.gnu.org; Fri, 02 Apr 2021 01:40:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSCXv-0006g8-Ep for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 01:40:39 -0400 Original-Received: from mail-oln040092253027.outbound.protection.outlook.com ([40.92.253.27]:24829 helo=APC01-SG2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSCXt-0006B7-1I for bug-gnu-emacs@gnu.org; Fri, 02 Apr 2021 01:40:38 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hd7AojeaWhx9EjvE79+Pvr9jzO4RQWd621EGNRtDq+d/02DxLzgMI6UP1PIiQpY+pFf1gw6aRS6hnqyPfJ1oF4e0UBqYYiKMWwuWYPCZYm6R3u0lGVcAxHXFiSwlTf9RDOizL+kkXMHK/7Y5sIHah0J148PPz++ys7CiecYK2AE3skazwxicO8U54uywBqk6ztsvaqs9TKluBrpXIAoksKjzVOw1A7/JI8rVILuxmILVx03O/Ak9MozBeclPjtlb0f7jJDZrLubSNH5qPt/8xDdLPGwm3XcbhgcdM8UCFMMQfaqI/KZsW65HriA5iEXv2XGaxVHhhtUmZFi4BsnW1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bf/SWjqtgF8frIo3Y+CUno5G9zfz042A02PknvsI3TU=; b=ZqadbfbjgK6VEZcpCmQPsVSjSouWCgEmuRm6TZl13Z0MjzvCsGrijzH6bpGSzxL0CKevUnPuwUwFdaNpV44EfKI6B8GkaXAG4CWYr9ZEDqJXxFJfdi+jLUdW/oqAQR5/7yyK5K7qjLvGCjhwHt+rxGdNNsrzE6GMmgwNtkRZKtYCGEsC3cofQfwPCqpg0hrHDavsYo1PeMu8lhyifyDIYWNGnAsxsRnGSR8OEBYT+Aut3VIVEp7ftzPyhXrb071D0Jc+Q6gdSNvsj2t8puwbNsDaFWDbQjMHvjWBgVDSvZEspGMnzLdwLnM/1kB27QCfcAUr8NsjxowIEbZUO/qaDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bf/SWjqtgF8frIo3Y+CUno5G9zfz042A02PknvsI3TU=; b=nf3zXdIU66Nw8+vx6nmhApD8G0pUlr7mODYrURFXkn3M9wbJR5nLR7iPrUq1hQdXXy+6XknPoO1XBBDRYpZewfDIH+d4CbB20Wz7oh+NVicKhAAGQsS7LKyqRV5mJkGKbcnC9mMFX1wwXA85DkwK8NrXghMnXgn9Ov+lRmQ9qqtSYISpwHxX4MbXAu0cJr5Nt97pBWHE/M+uVM64457JoQDtgIEtoys2cdlM1yVJfEboIUFSLenuZ/zFwW2bYZ8nLrKhMNIf87McmMZxdbg76/daO7hkFxWrq/WxCUFlCKrZaEuDXfuZXN9R7kVv+EnzMUbBRm0CqVm0frpLfI02eQ== Original-Received: from TY2PR0101MB3693.apcprd01.prod.exchangelabs.com (2603:1096:404:800f::16) by TY2PR0101MB3118.apcprd01.prod.exchangelabs.com (2603:1096:404:e5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Fri, 2 Apr 2021 05:40:25 +0000 Original-Received: from TY2PR0101MB3693.apcprd01.prod.exchangelabs.com ([fe80::4980:4d7f:474b:de2c]) by TY2PR0101MB3693.apcprd01.prod.exchangelabs.com ([fe80::4980:4d7f:474b:de2c%3]) with mapi id 15.20.3999.029; Fri, 2 Apr 2021 05:40:25 +0000 Content-Language: en-US X-TMN: [9/hwbgWN3Vj4TGmdf0QOo2hr+PiJNeVh] X-ClientProxiedBy: MAXPR0101CA0034.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::20) To TY2PR0101MB3693.apcprd01.prod.exchangelabs.com (2603:1096:404:800f::16) X-Microsoft-Original-Message-ID: <25dc99d8-c9d3-f1da-a6af-1eac71c79210@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from [192.168.43.244] (117.230.15.35) by MAXPR0101CA0034.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28 via Frontend Transport; Fri, 2 Apr 2021 05:40:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e2f45d5-8063-4966-c09e-08d8f599d0a7 X-MS-TrafficTypeDiagnostic: TY2PR0101MB3118: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V75CC3RXgc9OSgdg4f73R+SV3yNDji3eUypIGB7iIXXUQMz5yC1jqNtUxNgp542Oj/zgKnFFWnR9k1+QT2ZCfBcsyKKBHRNEGB+/kWQGM9a/6XtXBN6JfQJDtjO8cQRkdZDX7P1B5YUTkveXGxRPDar2nAgc2S92RG9JBqfEHcEYk8JVr9ZOo3K3HpjFchmU1nKNKOwc6SSMsCoVK91K98rTiq0T1KIVtNv86whkD4vtmVIZLG1KAjrNxogYR1jN8btZqRQajePmy8cjgQafmqu9UzxXFWwjE6YjJi2ZX46458MBGnLcUsx8zF4J3aTtmbUhMJDDb1nnymjGvw+ri37Aq/R7vZ4ygf/BGbj1F3OgYQY9CgRQPoS8E/HF3Kv7tqCz92vYrNkEaXJ812gSHw== X-MS-Exchange-AntiSpam-MessageData: ToOgHpxo5hE/HslbB61ARRXG8Sn8LfTzJC2bQQgUKewLSWE+VusMB7V1zx6htz4p4m2qX0jL6gmgQUqti83fyzhBNdRqjjfI6nolNgZbmRCoF+HVLpqwUbJg2uA18Nc0wcrzNIkX+WTLLIa9/MlK+g== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e2f45d5-8063-4966-c09e-08d8f599d0a7 X-MS-Exchange-CrossTenant-AuthSource: TY2PR0101MB3693.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2021 05:40:25.6752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR0101MB3118 Received-SPF: pass client-ip=40.92.253.27; envelope-from=rameshnedunchezian@outlook.com; helo=APC01-SG2-obe.outbound.protection.outlook.com X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 02 Apr 2021 10:50:44 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203471 Archived-At: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep'. Commentary in `diff-hl' says ;; `diff-hl-mode' highlights uncommitted changes on the side of the ;; window (using the fringe, by default), allows you to jump between ;; the hunks and revert them selectively. ;; Provided commands: ;; ;; `diff-hl-diff-goto-hunk' C-x v = ;; `diff-hl-revert-hunk' C-x v n ;; `diff-hl-previous-hunk' C-x v [ ;; `diff-hl-next-hunk' C-x v ] ;; ;; The mode takes advantage of `smartrep' if it is installed. FWIW, `smartrep' is not part of GNU Emacs or GNU ELPA but available elsewhere. (I install it via MELPA) Now, that `repeat-mode' is part of GNU Emacs, I think this dependency on `smartrep' can be removed. FWIW, this is what I have in my `.emacs'. (progn (defvar diff-hl--repeat-map (let ((map (make-sparse-keymap))) map)) (message "Installed %s" 'diff-hl--repeat-map) (cl-loop for (cmd . key) in '((diff-hl-diff-goto-hunk . "=") (diff-hl-revert-hunk . "n") (diff-hl-previous-hunk . "[") (diff-hl-next-hunk . "]")) do (define-key diff-hl--repeat-map key cmd) (put cmd 'repeat-map 'diff-hl--repeat-map))) ---------------- In GNU Emacs 28.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2021-03-20 built on debian Repository revision: 31544bc908d35bff513450bc4bea1d0283a7ddb0 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12010000 System Description: Debian GNU/Linux bullseye/sid