From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John Cummings Newsgroups: gmane.emacs.bugs Subject: bug#50630: [PATCH] Add tests for insert-directory Date: Sat, 25 Sep 2021 19:00:14 +0000 Message-ID: References: <83bl4gr9gr.fsf@gnu.org> <83pmswpnwh.fsf@gnu.org> <5lfMDzHA2waL6rqBXIu9VVdZiGHqsP3B1wJq3MvU71eZwrdqyi4iXUwuEuldT-SNilGq3jrS88bYp4zKIAo-xD2K8teQdBKQszDYhm52bMc=@rootabega.net> <83mto0pn2e.fsf@gnu.org> <6BkKnxC8vJfxCuBEeMYpDIIMMNM9KoCWH_apnHQQkb3ejH9sD59wOd29-KnV1UGcIJs6DZS0D9wiAKFowJ1kD48m0LNUYaVLVSyEsQ1nGbs=@rootabega.net> <83k0j4pkac.fsf@gnu.org> Reply-To: John Cummings Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14106"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50630@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 21:01:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUCvF-0003UO-45 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 21:01:17 +0200 Original-Received: from localhost ([::1]:37402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUCv8-0006wV-Ji for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 15:01:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUCv0-0006wM-3c for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 15:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51454) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUCuz-0006WW-Pi for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 15:01:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUCuz-0003KB-OQ for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 15:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Cummings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 19:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50630 X-GNU-PR-Package: emacs Original-Received: via spool by 50630-submit@debbugs.gnu.org id=B50630.163259642312725 (code B ref 50630); Sat, 25 Sep 2021 19:01:01 +0000 Original-Received: (at 50630) by debbugs.gnu.org; 25 Sep 2021 19:00:23 +0000 Original-Received: from localhost ([127.0.0.1]:34766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUCuM-0003JA-Vt for submit@debbugs.gnu.org; Sat, 25 Sep 2021 15:00:23 -0400 Original-Received: from mail-4323.protonmail.ch ([185.70.43.23]:52015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUCuL-0003Ix-I8 for 50630@debbugs.gnu.org; Sat, 25 Sep 2021 15:00:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rootabega.net; s=protonmail; t=1632596415; bh=ueZdkugyyPzAw7iyTz9XBtdlf9NrUuAfzljQcOj2pWM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=cYJ7CgJi9Gf3XIuzx7E8fpS0zh1ATgT0iOWaQ/N4sdQRTBu8mM/iDK5pJ4z/hR08f TwdX5ggGvDyDy8FZlfqcHFsOCMfUQdciBC7ZJfHQHIR8+XcMXegIN99N3dzrPJEEfs Ryf8FzkhXgQ7ilzj/cbguj4QJaNbxEPKErV4dccBDOE9UAo7qoq7mYNYSeJPQBBxaT aOAWD4vD50LYJtLHjtSLFqltztiwWe75xi1vT5zqYIGzHN4Gqf/Z07G3g71JssDq02 V1V2eu4lmb0308vh1wkFTf9TxqjTDBKvbyuyAhNreEwWdUVeoScJ+V+8iH43kwau/7 9nSHvtj33a8iw== In-Reply-To: <83k0j4pkac.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215506 Archived-At: Eli Zaretskii wrote: > > > With your recipe, indeed the free space is not always correct. But > > > why is that use case interesting? insert-directory is not a normally > > > a user-visible function. > > > > If being a user-visible function is necessary to consider it interestin= g, > > then I reported this as a bug in the verbose `list-directory' output, > > which is documented in the manual. > > Like I said before: let's pick this up when your test is installed, > and we can run it and debug it if needed. I'd appreciate it if you continued this discussion until we can agree there is actually a bug, or at least something that could be improved. I don't think we need the tests to be merged to be able to do that. In fact, I'd sa= y it's the other way around: if there's a chance that a maintainer might tell me there is no bug, or that whatever I found is not worth changing, I would decide not to invest any more time into it. So are we in agreement about these 3 things below? 1. insert-directory in files.el used to be able to show the incorrect free space for its FILE arg. The same function in ls-lisp.el and tramp-sh.el continues to be able to show the incorrect free space today. 2. The recipes/instructions I sent will be able to confirm this 3. This should be changed because insert-directory should not be able to insert free space info that is not correct for its FILE arg.