From: John Cummings <john@rootabega.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 50630@debbugs.gnu.org
Subject: bug#50630: [PATCH] Add tests for insert-directory
Date: Sat, 25 Sep 2021 19:00:14 +0000 [thread overview]
Message-ID: <SqbS39aV1mg5l26tSuRHoaRrkODFV_0HcOgi70XNXh9nVR5o1xos3O-U3FwyJ4ntsyOCFjl7w-3XBGKj6cAfJ3-7O8niflksk7HXF9SkBOQ=@rootabega.net> (raw)
In-Reply-To: <83k0j4pkac.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> wrote:
> > > With your recipe, indeed the free space is not always correct. But
> > > why is that use case interesting? insert-directory is not a normally
> > > a user-visible function.
> >
> > If being a user-visible function is necessary to consider it interesting,
> > then I reported this as a bug in the verbose `list-directory' output,
> > which is documented in the manual.
>
> Like I said before: let's pick this up when your test is installed,
> and we can run it and debug it if needed.
I'd appreciate it if you continued this discussion until we can agree there
is actually a bug, or at least something that could be improved. I don't
think we need the tests to be merged to be able to do that. In fact, I'd say
it's the other way around: if there's a chance that a maintainer might tell
me there is no bug, or that whatever I found is not worth changing, I would
decide not to invest any more time into it.
So are we in agreement about these 3 things below?
1. insert-directory in files.el used to be able to show the incorrect free
space for its FILE arg. The same function in ls-lisp.el and tramp-sh.el
continues to be able to show the incorrect free space today.
2. The recipes/instructions I sent will be able to confirm this
3. This should be changed because insert-directory should not be able to
insert free space info that is not correct for its FILE arg.
next prev parent reply other threads:[~2021-09-25 19:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 23:00 bug#50630: 28.0.50; list-directory shows free space for current directory, not the specified one John Cummings
2021-09-17 7:07 ` Eli Zaretskii
2021-09-17 10:24 ` John Cummings
2021-09-17 10:36 ` Eli Zaretskii
2021-09-17 17:38 ` bug#50630: [External] : " Drew Adams
2021-09-17 18:04 ` Eli Zaretskii
2021-09-17 20:32 ` John Cummings
2021-09-18 5:56 ` Eli Zaretskii
2021-09-18 10:04 ` John Cummings
2021-09-21 10:57 ` bug#50630: Confirmation of instances in ls-lisp.el and tramp-sh.el John Cummings
2021-09-24 19:58 ` bug#50630: [PATCH] Add tests for insert-directory John Cummings
2021-09-25 1:47 ` Lars Ingebrigtsen
2021-09-25 10:45 ` John Cummings
2021-09-25 11:38 ` Michael Albinus
2021-09-25 12:13 ` John Cummings
2021-09-25 6:10 ` Eli Zaretskii
2021-09-25 11:38 ` John Cummings
2021-09-25 12:30 ` John Cummings
2021-09-25 13:06 ` Eli Zaretskii
2021-09-25 14:29 ` John Cummings
2021-09-25 14:55 ` Eli Zaretskii
2021-09-25 17:15 ` John Cummings
2021-09-25 17:26 ` Eli Zaretskii
2021-09-25 17:37 ` John Cummings
2021-09-25 17:44 ` Eli Zaretskii
2021-09-25 18:01 ` John Cummings
2021-09-25 18:44 ` Eli Zaretskii
2021-09-25 19:00 ` John Cummings [this message]
2021-09-25 19:07 ` Eli Zaretskii
2021-09-25 19:58 ` John Cummings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='SqbS39aV1mg5l26tSuRHoaRrkODFV_0HcOgi70XNXh9nVR5o1xos3O-U3FwyJ4ntsyOCFjl7w-3XBGKj6cAfJ3-7O8niflksk7HXF9SkBOQ=@rootabega.net' \
--to=john@rootabega.net \
--cc=50630@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).