unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "andrés ramírez" <rrandresf@hotmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61432@debbugs.gnu.org
Subject: bug#61432: 28.2; [PATCH] viper-init: disable face support
Date: Sun, 12 Feb 2023 17:54:45 +0000	[thread overview]
Message-ID: <SJ1PR12MB63631BE93539828523E738E8A6DC9@SJ1PR12MB6363.namprd12.prod.outlook.com> (raw)
In-Reply-To: <83r0uwhwd4.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

Hi. Eli.
>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

    Eli> The easiest one is this: (require 'viper-init) (setq viper-minibuffer-vi-face
    Eli> viper-minibuffer-emacs-face) Did you try that?

Yes. without success.

    Eli> What is the "right behavior"?  

The right behaviour is staying as If it were an 'emacs -Q'. minibuffer
faces should stay as by default on vanilla emacs.

    Eli> Which face do you want to avoid seeing?  

I would like minibuffer faces stay as vanilla emacs when activating viper.


[...]


    Eli> Anyway, the above is just a hint: how you can arrange for the viper faces do whatever you
    Eli> like.

Thanks. But I have not being able of having the faces on minibuffer not
changing after activating viper. 

What about a oneline patch?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: mypatch --]
[-- Type: text/x-patch, Size: 602 bytes --]

diff -u /tmp/viper/viper-cmd.el.bak /tmp/viper/viper-cmd.el
--- /tmp/viper/viper-cmd.el.bak	2023-02-12 17:45:05.775987386 +0000
+++ /tmp/viper/viper-cmd.el	2023-02-12 17:06:44.589089504 +0000
@@ -564,7 +564,7 @@
        ))
 
   ;; minibuffer faces
-  (if (viper-has-face-support-p)
+  (if (and (viper-has-face-support-p) (not (and (boundp 'viper-disable-face-support) viper-disable-face-support)))
       (setq viper-minibuffer-current-face
 	    (cond ((eq state 'emacs-state) viper-minibuffer-emacs-face)
 		  ((eq state 'vi-state) viper-minibuffer-vi-face)

Diff finished.  Sun Feb 12 17:45:44 2023

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


Best Regards

  reply	other threads:[~2023-02-12 17:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-11 14:22 bug#61432: 28.2; [PATCH] viper-init: disable face support Andrés Ramírez
2023-02-11 15:38 ` Eli Zaretskii
2023-02-11 16:10   ` andrés ramírez
2023-02-11 16:30     ` Eli Zaretskii
2023-02-11 18:32       ` andrés ramírez
2023-02-11 18:48         ` Eli Zaretskii
2023-02-12 17:54           ` andrés ramírez [this message]
2023-02-12 18:30             ` Eli Zaretskii
2023-02-12 18:53               ` andrés ramírez
2023-02-13 14:00                 ` Robert Pluim
2023-02-13 15:02                   ` andrés ramírez
2023-02-13 17:02                     ` Robert Pluim
2023-02-18 17:01                     ` Eli Zaretskii
2023-02-18 17:01                     ` Eli Zaretskii
     [not found]                       ` <SJ1PR12MB63635DCA5881078AB2D3ED0BA6AB9@SJ1PR12MB6363.namprd12.prod.outlook.com>
2023-02-23 15:09                         ` Robert Pluim
2023-02-23 15:24                           ` andrés ramírez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ1PR12MB63631BE93539828523E738E8A6DC9@SJ1PR12MB6363.namprd12.prod.outlook.com \
    --to=rrandresf@hotmail.com \
    --cc=61432@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).