From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#49534: [External] : Re: bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Date: Tue, 13 Jul 2021 23:04:34 +0000 Message-ID: References: <87czrmrxfv.fsf@gnus.org> <87zguq6mof.fsf@mail.linkov.net> <87o8b53kyg.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4339"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , "49534@debbugs.gnu.org" <49534@debbugs.gnu.org>, "Richard M. Stallman" To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 14 01:05:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3RSq-0000x8-MW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Jul 2021 01:05:20 +0200 Original-Received: from localhost ([::1]:44676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3RSp-0006LJ-Of for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Jul 2021 19:05:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3RSY-0006CC-Ip for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 19:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59088) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3RSY-0002nZ-C2 for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 19:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3RSY-0008CP-8q for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 19:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jul 2021 23:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 49534-submit@debbugs.gnu.org id=B49534.162621748431484 (code B ref 49534); Tue, 13 Jul 2021 23:05:02 +0000 Original-Received: (at 49534) by debbugs.gnu.org; 13 Jul 2021 23:04:44 +0000 Original-Received: from localhost ([127.0.0.1]:42400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3RSG-0008Bk-Cp for submit@debbugs.gnu.org; Tue, 13 Jul 2021 19:04:44 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:7336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3RSB-0008Ba-Q5 for 49534@debbugs.gnu.org; Tue, 13 Jul 2021 19:04:43 -0400 Original-Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16DN1Sui023255; Tue, 13 Jul 2021 23:04:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=ObzEDQnJBd1vupxdRrKHxJaiP/0Q6Qceav2n1nOw3CI=; b=lAN5ahPCLqvB7UUg9tbew/+Bbr7knGeVRV/lu2NyulbFtzLn5gExlSJ190GU7QOr4j0Z aKMyKRWbxcpVoVV6a8+W0svK97giw3y6dFRQ9butuHP6z4vM6r12W1P8UhaWGRj0iH8P s0wM3cucq336XoOKf3mQrvZMNuXQhaiYO3izD3Hq+28rMd+N8OwqW0SGWii48eUssm0P c4AgnuUwA/KoATyHX841vpnz0RcHc+foAwlnk2SpGmToj586zEk23w/dRAsD8hA7G4Z8 IfdhM0ez3FrMWZ3FGGcTDKiTT509QHibIO3i5BVK8/32H8ZYnZYKlv1kHwyjtepA4P3m jQ== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 39rnxdkpj8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Jul 2021 23:04:39 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16DN0XGI055942; Tue, 13 Jul 2021 23:04:38 GMT Original-Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2049.outbound.protection.outlook.com [104.47.57.49]) by userp3030.oracle.com with ESMTP id 39q0p66na4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Jul 2021 23:04:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WbNoeo20W7H9Yq7wPKnuA4yXyR4H/yXVjeuFyXf5tbOwYdbEJv9sV8FYf2Kcrj+wYtofZBgrzclrRfAKTAl/1PvdXKPwAHUJBy8vAXOs0L0grBqEF6MRv0OHrzo7DZmZdDZoih6rKBOuqfmUiYT14WM4m94zKdIqpFZNYKNxhN1/diokQVHNiRe28MqTR8l5WcoN49Y4YnL2cgxGTc3WmJtK6Su13Zz7lPGUFQjcmyeLyoTB3ll9pPIS+1tzEhF2OeA4dyTyU6QdVTw1gpioyJXF5UjQq8bj6sdxauNM6JtylZdqmw5E//cdLfpgl99LG0qC0Ny8LdlazarMrQ3X1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ObzEDQnJBd1vupxdRrKHxJaiP/0Q6Qceav2n1nOw3CI=; b=d3mabZ3mZXj7vjKVNa1vTSDYOdbPVEwRq95P15Q7UAMI3bRsw9ebHoDLmzHloMNrZyzQ/Wkzh17ex3+bAdMy/V6cYQxmqCaweDV9YmNuhp38lcY0zerhqyi4PU8XqMtmAUZsIunvIwHtby1afoJwSZ2reK2y251klPFncMafsP+eseZ1SDUCwidEFjRdFm13h6ZjbxM/evLyr8X0FtwhG2y/7AyM5+58Hc/ffzMhpDKBeOMLsxI5Jm+Lg/Zx6CGKFUozN9Oa4W8TA4NXbCY6ZZdAuy1UXhY7SmN3LTN+hXffyuG4T8W56IXjkXrkuT7lfupCFklCugXi8xaIY7yytQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ObzEDQnJBd1vupxdRrKHxJaiP/0Q6Qceav2n1nOw3CI=; b=MvKx0fl+Amjo5rQX86nH3CHRYyhOulMuwDTuSg+M9auInfwf49C7aXi1yIomopql2P1UtCqJoTPIer6F64pELgTUQ4UZKQicW1JiuETyFvJDg9XENbSW7zak+JfZ85c7Q01tzX9x4nphiivo+pCleen4H9zqgxz7+wqwHx/t8SQ= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BY5PR10MB3826.namprd10.prod.outlook.com (2603:10b6:a03:1ff::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Tue, 13 Jul 2021 23:04:35 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::1d3c:d31b:8add:1958]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::1d3c:d31b:8add:1958%5]) with mapi id 15.20.4308.027; Tue, 13 Jul 2021 23:04:35 +0000 Thread-Topic: [External] : Re: bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Thread-Index: Add3KtHOVbhX4iMwQf2riJuDn1/IigBDCoyWAAEF1CA= In-Reply-To: <87o8b53kyg.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US authentication-results: linkov.net; dkim=none (message not signed) header.d=none;linkov.net; dmarc=none action=none header.from=oracle.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c6a5ffcd-e5a1-48ad-e00c-08d94652950a x-ms-traffictypediagnostic: BY5PR10MB3826: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RIthr8F2MnYzmTaQQnTiJXH8fcD7tjWgh5hbf3rGdCxC60W4I1wI8RJa8prlYo0Zm7+GACJ6xwnriCxcgNXNsiWO/QzzH0eDex7nQ/No4OBmDztf5DILLnLs9vY/bHAEtGJfoJ81KCoSIPb97k79RIL04QL4gdU//PHmw/muROSz3fbWgmIGoPlmAf66Wm7E4rzwnzIG/16SjuWfiKDjEZvk+X1bgU/ip5SC9/O+jiptu8rBQ6N35rVCWk8H6pUD1dixncX8K42NJqwj9IUjQ1t7dHKlgn7UMfDUNke2BFcwbYJmS9EJ1mAtx/rdWi4U7kqr5c9q8LYxv5D6Sn14ZMdyJggSpbJZYUuRBWeQ8JQ0z/MTJJjDGaZqfPzDsDJuTM1MNRrHoaa024GqQE4iitVBrm9FNnd51RHxf47FHgdwrhSIcJ4EgA7bRLFeOSskZEVOxi2xeaEKL8alVqbMKy5IzyvTgOF3cfijIlJPFMjeGk2hyRu50Ek/1DJtUiM2G8J7Agikm6rLuFEh11001wrZhrwGYNWI2JvRrs6nfcXOFYvpkG7928G4/KeilWdlHP+U0fLeu178dLuG0EKYXbpNcRIYlJHShHHrGeWB+RzS+fkTXeFzgfSE6FhH0IpbMGvD0xcCdA6VmLSN2/Hp+19JVewIOKIjr711IPIpZ+nQGRwKBEAvbBngLhxVGKsYQhzpwb5AePUu6HfZ8xMn5w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(366004)(396003)(136003)(39860400002)(346002)(38100700002)(76116006)(26005)(9686003)(316002)(64756008)(54906003)(66476007)(5660300002)(86362001)(66446008)(66556008)(4326008)(55016002)(122000001)(71200400001)(6506007)(7696005)(52536014)(66946007)(8676002)(186003)(478600001)(6916009)(2906002)(33656002)(8936002)(83380400001)(44832011)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: UfZgOf7gndJhpwH39Z1iPpil6rYA7hRDIniih1yHy8X2UTV0Wr/31XsDbnPwhXKDsyZyYoO1X2EXm28rvZw6i1HufjQdMiam20CgW3y8aMXM8kxxoPeWYl/Y3R3L34VQSHDRqj5zUsljfbjUNwMm4cZL10rZ6c2dzlmHdYr11FDeahmsMrpD2ICNhsZoRUxUyE1Y/7Rd8FUzLVmPw4q62HjRXzPJPWnF4sMIq+jj0g0J7T+WJSn6bcO3NxeItsWLXqThrmWrsf6NwGbcQ2rT9J9mcvezkQEuWfTt3hNgiZec64/pN7KnDMz1UzhZDoyCTJm+SQcupLnsKGkkboPIsLov++dV2+IsM5i0inXQJeB3t79+38RrUrUqDzbn3InxiTCVgMK1dLkCayGvhBrZ1x37T1vmkaxzkd5dMAm9G7qI1aPBgCdDHMWOQ5Pgo0RArJ3DkKEWwRXU2VNTXdnXHn6aQc9dBU5thG2ZDC5Q2fS2duj5HprdLSOTzO0UY5QUKz7/wKXm7/OH6ukaUcJNIfhbaomsy/SN+ImgUXK/5QeWLGTA3q4SeHAixEqdTNb3bmRLuX+1te0qCZyaYo9cP4E0UoFIL6HfRDZ+okFlfdQsthf3H4TjJCayJJNtKd2FynKgVGfheJp+WR1TC9bjU3LjPKBKbpiKO6cAzcx9f6ztQqqbzkoqQp+PHGx6KTUuIBhVtc9iTFe2n1SLxyldecSMVXHoFJzVDOe99jwLyQ3hT35pBl10xN3lP5 U+CUUtuuwHSpnfUnCzm99/svyPKJoXmQIdd2l1RenTPb6drO/vakbQejImeE7Gl41MRpaUnZbDePDaBf+1jEwQJfI2RpsSV5ye x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6a5ffcd-e5a1-48ad-e00c-08d94652950a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 23:04:34.9863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ysAbrS3AgtzrBVpCrU1ivHs+S6IO7yf5s4O6VuFoxeoh2/YDBRr7kDm5w41tJAPJS8avNBP/5i6b2ipEue+ycA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3826 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10044 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107130140 X-Proofpoint-GUID: c597n4SJFN0a1Fz0PzQOXmmbDw7LayeO X-Proofpoint-ORIG-GUID: c597n4SJFN0a1Fz0PzQOXmmbDw7LayeO X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209901 Archived-At: > > Your code (in master) removes that boundary test > > altogether (no `bobp' or `eobp' test). Why is > > that the right thing? Is it because the match > > should be allowed to match up to `bobp' or `eobp'? > > If so, why was that test in isearch.el in the > > first place? >=20 > If you think that you found a problem, please provide > a test that exposes it. I'm asking why you removed that boundary test. And peripherally, why it was there to begin with? > > Actually, you do still test for reaching the > > boundary, but only for an empty match and after > > filter failure. Why is that? >=20 > Please provide a test case if you think there is a problem. I'm asking why you test for reaching the boundary, and only for an empty match and after a filter failure. > > And why do you not need to back up a char after > > the loop, if the match was empty the last time > > around and the next time it fails? It'll have > > advanced a char; should it stay there instead > > of backing up? (Dunno, but I supposed not.) >=20 > Please provide more tests that confirm your doubts. I'm asking why you don't need to back up a char after having advanced a char in that case.