unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Kangas <stefan@marxist.se>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: "47047@debbugs.gnu.org" <47047@debbugs.gnu.org>,
	Juri Linkov <juri@linkov.net>
Subject: bug#47047: [External] : Re: bug#47047: 28.0.50; 'help-key-binding' face's background sub-optimal
Date: Wed, 29 Sep 2021 22:21:38 +0000	[thread overview]
Message-ID: <SJ0PR10MB5488F2708F48E70B0B44A8E0F3A99@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <CADwFkmnvf6wQQucw3psnxOViE0vK7HG+XnEUHfQ78aZsM=DVOw@mail.gmail.com>

> > 1. IMO, bugginess of a theme should matter (should
> >    be thought about, as you put it), but low usage
> >    (coverage?) should not.  Why remove a theme just
> >    because it's seldom used?
> 
> What I mean by coverage is that it has only few faces defined, which
> leads to inconsistent results.

I see.  (I took a guess that you meant usage.)

What do you mean by "faces defined"?  Do you mean new
faces added by the theme, or existing faces redefined
by the theme, or something else?

Existing faces that are not redefined are nevertheless
covered (still defined), I'd think.

What inconsistent results have you identified?  What
kinds of inconsistency?

> > 3. I have no idea who the "maintainer" of that theme is.
> >    We were asked to contribute themes when custom themes
> >    became a possibility, and I sent that one.
> 
> That was a commendable initiative on your part.
> 
> The question I am thinking about is what to do about it now.

Why do you think you need to do anything "about it" now?


> Perhaps we (read: our users) aren't well served by
> unmaintained/incomplete themes?

As you say, users can report bugs.

In what way do you find it unmaintained or incomplete?
Has something needed to be changed, for maintenance
reasons?

There's plenty of code that's part of Emacs that hasn't
been changed an iota over the years, but still works.
Does that mean that it's necessarily unmaintained or
incomplete?  Certainly any code could be enhanced, but
that's something different, and not a requirement for
its continuation.

> Perhaps there are other themes that we would want to include (see
> modus-themes)?  These are the issues that interest me.

That's orthogonal to your bringing up the light-blue theme.

> Conventionally, when there is only an "Author" but no
> "Maintainer" line, the author is also the maintainer.  If you don't
> consider yourself the maintainer, and no one else wants to step up, the
> conventional thing would be to add a line "Maintainer: emacs-devel".
> That's my understanding at least.

If that's conventional, please feel free to go ahead
and add such a line.  I guess that would be an act of
"maintenance", but I won't tell anyone you're doing
maintenance. ;-)

Anything more critical than the missing "Maintainer"
designation?

  reply	other threads:[~2021-09-29 22:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 13:40 bug#47047: 28.0.50; 'help-key-binding' face's background sub-optimal Eli Zaretskii
2021-03-10 19:59 ` Juri Linkov
2021-03-10 20:06   ` Eli Zaretskii
2021-03-13 19:01     ` Stefan Kangas
2021-03-13 19:25       ` Stefan Kangas
2021-03-14  3:00         ` bug#47047: [External] : " Drew Adams
2021-03-14  3:39           ` Stefan Kangas
2021-09-28 17:46           ` Stefan Kangas
2021-09-28 20:26             ` bug#47047: [External] : " Drew Adams
2021-09-28 20:54               ` Stefan Kangas
2021-09-28 22:13                 ` Drew Adams
2021-09-29 15:57             ` Lars Ingebrigtsen
2021-09-29 16:52               ` Stefan Kangas
2021-09-29 16:56                 ` Lars Ingebrigtsen
2021-09-29 17:24                   ` Stefan Kangas
2021-09-30  6:22                     ` Lars Ingebrigtsen
2021-10-03  0:24                       ` Stefan Kangas
2021-10-03  9:05                         ` Lars Ingebrigtsen
2021-09-29 17:34               ` bug#47047: [External] : " Drew Adams
2021-09-29 19:18                 ` Stefan Kangas
2021-09-29 19:50                   ` Drew Adams
2021-09-29 21:17                     ` Stefan Kangas
2021-09-29 22:21                       ` Drew Adams [this message]
2021-09-29 23:21                         ` Stefan Kangas
2021-09-30  1:59                           ` Drew Adams
2021-09-28 17:31         ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB5488F2708F48E70B0B44A8E0F3A99@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=47047@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).