From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>
Cc: "52023@debbugs.gnu.org" <52023@debbugs.gnu.org>
Subject: bug#52023: [External] : Re: bug#52023: 27.2; Enhancement: `this-command-invocation-(buffer|window)'
Date: Mon, 22 Nov 2021 20:00:23 +0000 [thread overview]
Message-ID: <SJ0PR10MB5488EE1B1A6407CE7241C540F39F9@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <864k846q2q.fsf@mail.linkov.net>
> >> But in any case you can use `pre-command-hook' to store
> >> the original buffer and window.
> >
> > Please the bug report. It includes this:
>
> A verb is missing. I assume you meant: "Please close the bug report"?
It should have said "please read". No, the report
should not be closed.
> > Currently, to get this information a workaround
> > would be to use a `pre-command-hook' function
> > that sets variables, and then to test those variables.
>
> Indeed, `pre-command-hook' could be used to set these variables,
> and other possible variables. There are much worse problems
> while using window-configuration-change-hook. When this hook is fired,
> it doesn't provide the previous window-configuration as its argument,
> thus requiring remembering the old window-configuration in `pre-command-
> hook'.
>
> So every `pre-command-hook' calls `current-window-configuration'
> that is huge performance overhead. This is worse than remembering
> a variable in `pre-command-hook', and still no one complains about this.
Please consider filing a bug / enhancement request
for that (other) problem.
`pre-command-hook' (and `post-') are overused.
One reason, I think, is that sometimes there's no
other way to do something easily. They can be kind
of a mess, and yes, they can affect performance and
other behavior.
I'd like to see this particular enhancement added,
as I think such functions would be useful generally.
I'd like to avoid yet another use of the `pre-' and
`post-' hooks just to obtain some simple state info.
There are lots of things that no one complains about
but that it would be good to fix.
next prev parent reply other threads:[~2021-11-22 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 18:11 bug#52023: 27.2; Enhancement: `this-command-invocation-(buffer|window)' Drew Adams
2021-11-21 19:19 ` Juri Linkov
2021-11-21 21:36 ` bug#52023: [External] : " Drew Adams
2021-11-22 8:06 ` Juri Linkov
2021-11-22 15:17 ` Drew Adams
2021-11-22 17:46 ` Juri Linkov
2021-11-22 20:00 ` Drew Adams [this message]
2022-09-24 13:31 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB5488EE1B1A6407CE7241C540F39F9@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=52023@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).