From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#54161: 27.2; `define-minor-mode' with alist of key bindings Date: Fri, 25 Feb 2022 22:33:01 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21816"; mail-complaints-to="usenet@ciao.gmane.io" To: Drew Adams , "54161@debbugs.gnu.org" <54161@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 26 00:36:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNk8X-0005XO-7X for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Feb 2022 00:36:33 +0100 Original-Received: from localhost ([::1]:48652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNk8V-0003sh-UN for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Feb 2022 18:36:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNjA3-0002Gr-Ss for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 17:34:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNjA2-0004BT-9P for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 17:34:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNjA1-0003ld-Vf for bug-gnu-emacs@gnu.org; Fri, 25 Feb 2022 17:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Feb 2022 22:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54161 X-GNU-PR-Package: emacs Original-Received: via spool by 54161-submit@debbugs.gnu.org id=B54161.164582839114407 (code B ref 54161); Fri, 25 Feb 2022 22:34:01 +0000 Original-Received: (at 54161) by debbugs.gnu.org; 25 Feb 2022 22:33:11 +0000 Original-Received: from localhost ([127.0.0.1]:53881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNj9D-0003kI-3x for submit@debbugs.gnu.org; Fri, 25 Feb 2022 17:33:11 -0500 Original-Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:1864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNj99-0003k6-6c for 54161@debbugs.gnu.org; Fri, 25 Feb 2022 17:33:09 -0500 Original-Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21PIiisC017475 for <54161@debbugs.gnu.org>; Fri, 25 Feb 2022 22:33:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=uMXK+9Y8UZOv+byPADGwv7iVpI3jWkDBYBiEf5nLev8=; b=taOeEEKHJwPnvirDEfp8feOyU/FY3C5PQdrqTkc9Jb5/arVmT3xKFEjOfzF6DpfrqMCF GGAKZewwCt9jy63hpF3Gr3zQknBCmuHCOxn4XXxbEs8cTpovLAiCco+AtTzogS52ddIk 6CQTKHhS52UdxLsWNPKeURXhqdn7exqoVQFLF0yNH6SCx2CbAipkOIqihhTX1iZh6JvC rpA4ZrVAqA+tO6yBnN2IhXQqGE4WBa07D6VSedkms+LvXuZ0Kgo/VOu3EKtewkOoB+NP 3Y5hvtN4VwK6B+gSP27OMdIx/ohTETjSVH4PBusRP5elmqQHwIlH9RO/AEwSTvvPAvpK Ag== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3eexa8t6k3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <54161@debbugs.gnu.org>; Fri, 25 Feb 2022 22:33:05 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21PMH3fJ043431 for <54161@debbugs.gnu.org>; Fri, 25 Feb 2022 22:33:04 GMT Original-Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2173.outbound.protection.outlook.com [104.47.57.173]) by aserp3030.oracle.com with ESMTP id 3eapknccdn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <54161@debbugs.gnu.org>; Fri, 25 Feb 2022 22:33:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b3DNYzzgBEmVW7BeLA+2CzudrAocu4+5HS42aMKWi8Em4u9dd+jsgTnWBptYrk1p2RO/KFw6iDaKoNvSEMa0xh5+ao9HWzdsoBSzY7TpZVoQjk3X3PXP90EzC5QNh7SCiHJxdmauIdtAsvW4aYfNTma5GePe5XVa+s9d4H03Nngo0WtIW9H7/IivOqpE3QL4Y6DrUW3EwhUsMirRZGzZgNWKYHov8exOAsfsQWEXEEMoMuiwrTgkLvL/8Q7Dw1hiIGsL2Jgdk6JLUcGBv0X5ZOTVRvSwYdNN9SvctGjGacp6puYGRX0o8t4gkEy4CJ36upqDIN+hFo5I9IJu5F7rsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uMXK+9Y8UZOv+byPADGwv7iVpI3jWkDBYBiEf5nLev8=; b=Xiy320JKDszW6LBYOWfKv48xoRlDZaX3gezaIi5VN3x4NlKBqoTRjTIZS6a0Km6FfYVol3d+RNOFl5AeX1XVmdFlnUGcNCnLp6PfPQRTo9wvvZC4Qq5kHN0K28Lm0WwibEbZwCs0E5IbPzXNW3maOi4RWT+stXi5omC0xTICom4sihs1StrBMWJDSMKW5EHlLzc1eAWV4zmt1pu4aUUAQSrefcPKpoM25bdN9Zg2IQ7BO6sqRpEZbCDVZP4QM7GcrVsZZaRoCIV4+TOYNCI+Gf5o5KaEFXGj1kU3fkvZgS1BnU5+BnkZ+0IGFe1mewmMxc8Hg/5FUzBRgEomk2s0ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uMXK+9Y8UZOv+byPADGwv7iVpI3jWkDBYBiEf5nLev8=; b=wMRVkOmUHhzIFutXYwhiLHOQoFnHsd5T/Nn0b1eMWpepRlGkeZu0iJKj+iclDXynKF8Iag2/Mf/Zj0TT1Uiq7pYN9r+NDgZLmoCa45RGC8FtUhwzxkKGG4oKgGzFFxFMhZm2DAYPkvKk+vtUpVPmAOLiu3A/jWxOJKfADzwzg5s= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by MWHPR10MB1981.namprd10.prod.outlook.com (2603:10b6:300:10c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Fri, 25 Feb 2022 22:33:02 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::f811:66c9:41ab:df79]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::f811:66c9:41ab:df79%7]) with mapi id 15.20.5017.026; Fri, 25 Feb 2022 22:33:02 +0000 Thread-Topic: 27.2; `define-minor-mode' with alist of key bindings Thread-Index: Adgqb9uJCPzV6IRMSmOFwWRzYqvc1AAJwHxA In-Reply-To: Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 30a1d740-9b87-4457-e846-08d9f8aec873 x-ms-traffictypediagnostic: MWHPR10MB1981:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B1b7jMTSnJS2IhDwOx8MI65TawZ2jl/xZ6nxk+YcflmMVgUg6mdqtomqUCN9TVBRjC0uiF7jYn9uMZ8mVjziCxBGdcq+Ubeld2T13ZttLr/agdEmAaIo0pAiSxZIEWT4Jn4sEjoSZvvt4QE0NNkEJUOTtd4NfsayziFsJDHNS7Id6d3v04dlOXpA0ami9sw9UUGT31+Y6a9NlVb16GcU/lfu/zVPnT9t6+6dz3oPwBnhM0JBQScqahqKIfQ8+ZhVS06Vg2wsGKwfYyd9asTTNmBxfoRkpLbbsR5Ma6SDgEeHzBL5rA0o8EvAtZXRsyugtWNvPbSYwiLjt6fmvLm2Mn+OFPHJf/hFN6U5zB1iXdzFpzss0lDvhu9muHywSStcQ4jfWAVtChAiTXlrMltUmGr0QJBzvMgk2Ed/X9zxwtGaHQsxxnjCNZrYhZCLDE1hNIh2MWcao+3MAhe4xTy2CcoMiUmXhH6OjQ43wfVbacxyd0hnQWOySJLye10YK7Q3owhfZ5TS8Mv64vioH1ttXw+r2ZamNmDb+z+reFvXJiyT+AZoV/zfOutIhqFq4ehmdX4SAFh9qN7WrNcENwy/lpuzIu6YUAh7gH87XI6w+M+Z+wNAQnY4BEPC2kSEG08A/H6oifNMd6oY08sn5xH7vQlAxEGZ5fyXvJrikcYn133jAbONO2Ur64SyRz2TW0aBwuUMHgcn/X3WxTwws7/XrES4EKnuNGTl1BlWRdamk9I= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(110136005)(38100700002)(508600001)(26005)(33656002)(44832011)(8936002)(55016003)(52536014)(5660300002)(2906002)(86362001)(6506007)(9686003)(66446008)(66946007)(64756008)(76116006)(66556008)(8676002)(66476007)(83380400001)(122000001)(7696005)(316002)(38070700005)(2940100002)(71200400001)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: g3YwvztV4Lq+7wg/n2jlCeO3O2yH3bBFCHyaoVzf2BKSPCYCnpzVQVY/oskVaH6oii7ZhI8p4OmNE0smfMONNoj5P/qmzhn6ODM8OL8ect8Ga+OAjjO9cT3DhNpCbkUnaHh/KfTLhHfMcdS2AzhjXcmRKytTZl7iDwf57Zq/3NPOPfNtkfDfzWtobV7kYD4zVGi/Ve8A944QOvYYRcWpz1Op253pUTRGRPYVydkBWKlEz7jUMVTY2aUiws0B3mp5WPm8QGGOlfyyjHRXAGHZl7Pr6I6vQthlpoEsvEJ/uLn0SppcZ2pldGS8lDjuFE1HJjYxLVoyMG6s5VuuGreHZi2M3+Y0MXm5vhVvQVvU62ct2ZGbWKc+z21Xx7vS7KkYBn4bxl05wA+zjqFZsDDVxbEbIWplvkmMTDvPTRXRdqZyQnRs/Itb2nRZujEVNxqBjqUr+w72psODKHBP71iuVTaviWWUW4ObLId623hE/hTHQYOjdF7LRV4MrHT/kOi7ddrWSVgKvpTxr9ual9Rl0qqnrrjPllWnwX9PavCNPFAaERWR0RTkfNer09UkRnr8xz3GaXTob7+bc5oEM8AiyG3wd7XFnpGRtJza+9wYpqwB6waoaxhUekF/m/B/drIoRQQOYQgB5mLJn/G4oSXXTs+DUnrOaJbToqah6RRqHPotwsa43ZNRxicw6m4CkSEetvB+vvtCpsNd0xFbeSDEBrr2b2UQYah81ak+VOMvIEOX8FiHelI6tH9tF8 wdTYA4QiWIIspn5eY1g52xLsbApY1E0RxDLiEaABwIc+Yo/ihYH1VWPsrkBYUiJnJ/ndtVDZub2grSVp+Ir+zG+FLDV1bQpiP9 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30a1d740-9b87-4457-e846-08d9f8aec873 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2022 22:33:01.9423 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: klAe/NuiBkxzsO3zlkGCVEOAoChM+8hpPyVzMT8yTZJ3RB3bfR+3BcVsQdvcd0I9v7ZoHuRC3o5fhKBt7VbWmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1981 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10269 signatures=684655 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=903 adultscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202250122 X-Proofpoint-GUID: rXUo0M1tXdoLMZGr6UYOIsOrQrYyLL0w X-Proofpoint-ORIG-GUID: rXUo0M1tXdoLMZGr6UYOIsOrQrYyLL0w X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227658 Archived-At: > The doc (both Elisp manual and doc string) says this: >=20 > The optional argument KEYMAP specifies the keymap for the minor > mode. If non-'nil', it should be a variable name (whose value is a > keymap), a keymap, or an alist of the form >=20 > (KEY-SEQUENCE . DEFINITION) >=20 > where each KEY-SEQUENCE and DEFINITION are arguments suitable for > passing to 'define-key'. >=20 > I think that's the case in these examples, no? Both (kbd "C-o") and > "\C-o" are suitable args for `define-key'. >=20 > What am I missing? I guess I understand it now. I think the language about something "suitable for passing" to `define-key' is what's misleading, and confused me. Usually we speak instead of an argument that is "acceptable to function ____". "Passing" suggests an unevaluated value you're passing, which is then evaluated as the actual argument for the function. But even that wouldn't be as clear as this could be. I'd suggest making it very clear somehow, that neither KEY-SEQUENCE nor DEFINITION gets evaluated. Maybe add a short example. In any case, you can close this bug, if you like. Consider it user feedback of something I found confusing.