From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24842: [External] : Re: bug#24842: bug#9445: 24.0.50; `help-make-xrefs' has bad logic Date: Tue, 7 Sep 2021 20:13:02 +0000 Message-ID: References: <919e40a4-f6c4-492d-b50f-b0671e13cb60@default> <87pmtk9sgb.fsf@gnus.org> <87wnnsgogn.fsf@rub.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6153"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "9445@debbugs.gnu.org" <9445@debbugs.gnu.org>, "24842@debbugs.gnu.org" <24842@debbugs.gnu.org> To: Stephen Berman , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 07 22:14:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNhTx-0001P1-6L for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Sep 2021 22:14:13 +0200 Original-Received: from localhost ([::1]:40148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNhTv-0004gw-S5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Sep 2021 16:14:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNhTm-0004gg-VT for bug-gnu-emacs@gnu.org; Tue, 07 Sep 2021 16:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46356) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNhTm-0002U5-Mj for bug-gnu-emacs@gnu.org; Tue, 07 Sep 2021 16:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNhTm-0002qZ-B1 for bug-gnu-emacs@gnu.org; Tue, 07 Sep 2021 16:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Sep 2021 20:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24842 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 24842-submit@debbugs.gnu.org id=B24842.163104559810880 (code B ref 24842); Tue, 07 Sep 2021 20:14:02 +0000 Original-Received: (at 24842) by debbugs.gnu.org; 7 Sep 2021 20:13:18 +0000 Original-Received: from localhost ([127.0.0.1]:57901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNhSw-0002pB-K6 for submit@debbugs.gnu.org; Tue, 07 Sep 2021 16:13:18 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:51840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNhSt-0002oy-US; Tue, 07 Sep 2021 16:13:09 -0400 Original-Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 187HpRfk002544; Tue, 7 Sep 2021 20:13:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=f9YIBX53aJsPG+9KWQIHe9BAxHjsYih/otkmbb7ngCg=; b=0WdVnonBIL4nI1gspzjSEsHaKu6YWoTR/vsdIZXoyfPydFY7igzu8cfA7w9R8ye9iD1J WxIopvzOrMdC1GXER3LQ0zSoqhiT0qsk5adATK3/SkUqcPBD/B5A3mKPS7DTTOkbXjNm 5YPy9BJXM01Gj6htabPYrOqtH+o4Lr3UASL+sebzfnqkNBkaIKbxwCYoagah/MBSRxhM 0LfeCyQ1qcYruBslrWZeyqhZIkMKypAG8bf3ahSJ21TwCIXpOVNcWctp/oreLUjXmRv4 ZRn3G2Esp6Orj2rt8ZWsbBa9/zSUsa+3zDYi5JukLKeIF89h2507RKnPIAYV4Byb2n2V Tw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=f9YIBX53aJsPG+9KWQIHe9BAxHjsYih/otkmbb7ngCg=; b=MUXeQbsLqQ+Gnri/6rJ6PqwGjQZKgrSTe6A8y/qkyWStyXA4feWd6mTAjANKDnqigtOX Fjhj6/lPi2i3dBC+67Vtv6IQZHwXluYw0Fq3+waWzX9+wv2IJ/lKz0AM9X4wuqS3Hkw1 /gxI4XxjALgg60vb9XXVW9/6x5kaFwQL35AScfkU+8yW6j/2sMhrVHilhGpieOyq2LI+ uZaUWZszIeWVP52wjImjEWfor1GJ0esGbMXmY0iXutrxeVds/cQQLkISTqiS3GVs6hKj LRgYscBb/nlA6reN0x9jwToNDOw0h+mhBtIAYaHa+zpBIp+7i/04OiwbL/rjT3x+9+4z IA== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3axcuq8bmb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Sep 2021 20:13:06 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 187K68cE021699; Tue, 7 Sep 2021 20:13:05 GMT Original-Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2170.outbound.protection.outlook.com [104.47.59.170]) by aserp3030.oracle.com with ESMTP id 3axcpmpdcc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Sep 2021 20:13:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fI1GZaneC/0lg+yFXOrC3BMPlgC9W0j0hYeGnTKtE7XGHpPcMS8Oq6JHZtULoU/6GOXpVTDu0LAkJc5WisvSjDnj6kGaODXV/H4BLSg0b+BvmjyLSLKyyLAvn2TMNK9Fm9iXjVodsMY5eYTE0rvDR4SGbN4Lc4dvAFZhuOcJOCfDZkg3CCkY0dP89e8iI1RUKLUhjaFuVfE/NLup30ClNq04nEbX6Py5Q1YTbfkRcaeyku2kwgQWXT2Ax6++cBHkkm0D6YiUkD9iuYIHrGAcJvjHny/uVT6Ww8ouNoJ+Svs6fbY/gR3uAcT9EuJgLncE5i1uZxkh7woq6qrLp4QAnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=f9YIBX53aJsPG+9KWQIHe9BAxHjsYih/otkmbb7ngCg=; b=bCypTnb0pa5dtSKgzgHxyIO1MalVhDKI760tu0ELJLeB9Zqu9HlhzAbDoO1ncastyqV3YuuQn5Uv+McX//G1cUpRVfCSryo3ekqI3QJl68BDZ8Bznsi/bj7SesHces49IIBpbxiYHsJOARmJl1GEaMUZ1QDnGtg6xaMYJavj9kPiVxlQP7SJLl9osUCjR6p7+5wiSn+kVf7VqkcuFSzrGmSkAXrFy5G+JpoFPNMc78GHSjhoTo46deeg0ocJ51dvzcurjqzqV2tBNfPRw1cLyKazd4L9h490v8p3g2Ade4Fie5ju+2UdL4U5EKs6bAQPWXtCrWozhELg/V2HymJUGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f9YIBX53aJsPG+9KWQIHe9BAxHjsYih/otkmbb7ngCg=; b=T2JuoU7ENZbeehI+rezMlkDqbP529z1lGdz93M5duSJU6qF1egohWQHJIt4T31ooKG+o9S91XvLvAcLrKCIaZWDLFeNg32v8K46pxYAf4t7JVqCBl6XucA/TMmNCakFpi5St9otIogofFsVDqrwNHRZYQzgO1sRksw05Khr3FAw= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BY5PR10MB4386.namprd10.prod.outlook.com (2603:10b6:a03:20d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 20:13:03 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::c0bc:7c3a:292f:8a82]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::c0bc:7c3a:292f:8a82%8]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 20:13:03 +0000 Thread-Topic: [External] : Re: bug#24842: bug#9445: 24.0.50; `help-make-xrefs' has bad logic Thread-Index: AQHXpCDRONsyBgAKc0Skq4H4+v5e/quY+q2w In-Reply-To: <87wnnsgogn.fsf@rub.de> Accept-Language: en-US Content-Language: en-US authentication-results: gmx.net; dkim=none (message not signed) header.d=none;gmx.net; dmarc=none action=none header.from=oracle.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6bca7bec-f231-4a7c-3d6e-08d9723be5a4 x-ms-traffictypediagnostic: BY5PR10MB4386: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i/qIEj5F6F9XUR1NS7e0FamThhzk1TPdy+T8f0nOQPYZuGXrgFWrY/qgQ4oRxLU2qtQC7ZExeadN7S2cMUWR3jrakjl7c+wj74e7tRCgICOHF/v6hUbKyA24SeiFLN1HJQaTvg8+Ld41mnfJdUO3smfm6BSqdolINNodgOX9x62JudP6iMs61hWcSrit+37GWgU2eCRWq4GWJ059SAVHx9L2HAGgVUo/GTKQDNODquX89GFGy+HIEgByoUhu924VJWXP2KqLRZVWH8zc3mwGnSC6KGUjXJ1psoYK1c3CYBnZ05sfpp95UimRHjG8Ne8SG1EKYPhGKXvpb6wwIW57SD2NsVKUj52bKiMfpd2dhkogjc2FGGGn113G/S6RePBInuVq2119L9UFOpXw9IeqRWg6LDxkKzxFGeCuN1JC/W2EaWcHPYpBn/QPQ5CF6NY1ldFMAc6CeBn7+OIQJrupoUs1bkYgodpnJoz8yurAori3iEMQEX8QOrqAKGU5/Cfjde2HuHpXSaL3XzuVcIHtw4G5e1hGhv/EBkqQJlSxdJbXKZ8lw6CFL40r+AXOMrVwO3993rAWACBTQlyGP0NXZE/QzDGwkq5IcRXX5o1kdlZ8VJKkFTfIZ2qiiPMDqrKD2cxwsmUjwh4sb1mjQcZS3cLxlJ1hbzM2o1eMC0W1icuy4qP+xNkTlXf6ycN+ubyRzwfyd+60lSthCDQZ3i8HbqbiRh0jpz37VB6JCUDJA2B5tcgnjdnvvcfxm7Esd uw7O70F2UUiSGcXCARFk56QR8ZDl0soGqfnni4YJbPiQOMqa0FdfTHeZ3gYDEcdCCU4 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(39860400002)(346002)(366004)(396003)(136003)(52536014)(76116006)(122000001)(4326008)(6506007)(316002)(7696005)(5660300002)(83380400001)(38070700005)(186003)(110136005)(54906003)(66446008)(64756008)(66556008)(66946007)(38100700002)(66476007)(44832011)(2906002)(55016002)(8676002)(9686003)(71200400001)(86362001)(8936002)(33656002)(966005)(26005)(478600001)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: DySGo9C7gyDqpvDy8lBX464vkzav2QV/8SE8eyxkXiw6XVlptaPd0fPTtOjMeHb4CmmOWF62jTmQ1ikZ7gz0mYHH4cUpzOhte6wHK2gBnQkoMkslHXkwKqVFBKb0fTLNzKolSOzDMcIzMDcjabzURn2qlMY0U+GA3w+uMjELxXfQfv+sufoPxe/mJCRtHJJUbX+Blck6l24Dcl7p6upZ33v/KizpWvsNrvakLolIjX2RiMmtfSl9Ff+jdB7pZbIxAUjpYnP23RJXMq9nhxxpkVCBX1PJV4Sj9WJN1UooqTjiMA73bVUEvJ6iF8Hn3LiSgZYoHzzTjLy4ee7DLvV2xwhmYfqMYqepeVeZ1/rPVAYFeHjyNJ/o48+EjYyolKf2ExP6iLsCX6CSx/Yg1ZphvDbDpZPkpX8wWy7ffmkhw4sKTRVrpXobDSiUjEykVwXLk4aFY+CBFVlKCXkMI0nCV2W2CiFU04xXcsRewwgKFK/bVzfu6wIcLMK0IVMPAqKo+kDGlIVGcvlhrpA/W3k0YC7ce60pALjSP63v5p5F+YBPq7C/a+sD4qJEuFK3jRZve4NP9kXJMgLhqPWGv7X31CPTHZAW2VG1JQ1+X/UtYNjGPinUE3TkvZeK54Tky7aH2vDQZdKQaukPf6uOz8pvTBFQDZC/qFnv9igZr1Vj/eWlhG2pQPGzJU/zKtGquOYN33CP6ijpPdybbLcIqZsL1SMx0royfeYE7fkeB3l0Lk22RmFKvU47SuX9l7 Sy07sUAIo+7w3pqNnh+kWjnOCmbvaa2o8+P6vEvUdOb1V4PpLVEx9D5H/LLSgknYw3UiCnZk85ZZBV7VF3upZkRkTOldyZmiJk x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bca7bec-f231-4a7c-3d6e-08d9723be5a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 20:13:03.0043 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3dpFzI8p+tPMPvJu132dCt5SRJLKZQyB6r9pVB6fjuHGE2ML6TWc649NION1Ga4PiBM9YNabpYF2TGlLspA9sQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4386 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10100 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109070129 X-Proofpoint-ORIG-GUID: jOtqyb55jVFkwK8y9ZgJorN_qfAmy5a2 X-Proofpoint-GUID: jOtqyb55jVFkwK8y9ZgJorN_qfAmy5a2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213754 Archived-At: > > (defun foo1 ()) > > (defvar foo2 ()) > > > > (defvar foo nil > > " > > `foo1' something. > > `foo1'\t- units and their movement functions > > `foo2' something. > > `foo2'\t- units and their movement functions > > ") > > > But the recipe Lars gave doesn't quite match the description Drew gave, > IIUC: if in the recipe you change the first occurrence of `functions' > to > `function', then eval and do `C-h v foo', then the first occurrence of > `foo2' in the doc string is not turned into a link. Isn't that what > the > problem was, and still is? Hm. You're right, Stephen. But not with just that change, I think. And it looks like the problem is maybe for defun doc strings but not for defvar doc strings? (But see below.) (defun foo1 ()) (defvar foo2 ()) (defvar foo nil " `foo2' something. `foo2'\t- units and their movement function `foo1' something. `foo1'\t- units and their movement function ") (defun bar () " `foo2' something. `foo2'\t- units and their movement function `foo' something. `foo'\t- units and their movement function " 42) `C-h v foo' shows links everywhere, for both var foo2 and function foo1. But `C-h f bar' does not show a link for the first occurrence of `foo'. ___ What's odd, and the reason I thought this was fixed, is that I checked (using `emacs -Q') the doc string in my code that I was reporting about. That doc string is for a function, not a variable, but it (correctly) has links for all of the variables mentioned in it. The recipe for the original report is this: 1. Download library isearch+.el from here: https://www.emacswiki.org/emacs/download/isearch%2b.el 2. Load that source code. 3. `C-h f isearch-forward' 4. This variable (user option) in the doc was not linked, but should have been: `isearchp-prompt-for-filter-name'. But now that option has a link. (With the above recipe all have links except those with `[*]', which the doc tells you are defined in another library - so no links is correct without that library loaded.)