From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#50431: revert-buffer doesn't preserve read-onlyness Date: Fri, 26 Aug 2022 16:10:02 +0000 Message-ID: References: <87mtopkj2a.fsf@mail.linkov.net> <87h721oowl.fsf@gnus.org> <86edx5o99p.fsf@mail.linkov.net> <874jy0ju7p.fsf@gnus.org> <86r114qk13.fsf@mail.linkov.net> <83k06w2lwe.fsf@gnu.org> <86edx4qfp8.fsf@mail.linkov.net> <83czcn36we.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27788"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "larsi@gnus.org" , "50431@debbugs.gnu.org" <50431@debbugs.gnu.org> To: Eli Zaretskii , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 26 18:32:47 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRcGF-0006zK-3H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 18:32:47 +0200 Original-Received: from localhost ([::1]:54030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRcGD-0000pf-Uz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 12:32:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRbvC-0007PH-Fv for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 12:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36393) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRbvC-0006tv-7V for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 12:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRbvB-0001zT-NE for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 12:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Aug 2022 16:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50431 X-GNU-PR-Package: emacs Original-Received: via spool by 50431-submit@debbugs.gnu.org id=B50431.16615302107547 (code B ref 50431); Fri, 26 Aug 2022 16:11:01 +0000 Original-Received: (at 50431) by debbugs.gnu.org; 26 Aug 2022 16:10:10 +0000 Original-Received: from localhost ([127.0.0.1]:54375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRbuL-0001xe-N9 for submit@debbugs.gnu.org; Fri, 26 Aug 2022 12:10:10 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:11980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRbuI-0001xS-4M for 50431@debbugs.gnu.org; Fri, 26 Aug 2022 12:10:08 -0400 Original-Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27QDcMnp010012; Fri, 26 Aug 2022 16:10:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=c/g3VEfVD+l8HbPsJR3HMuGuqg0nKvQ3SFBPa5CNUEA=; b=sEHgykhQbkgZ1yUjxQwC6xRArkvbbnCa7vakKr6aS4nT8GVfmuLu5ykRdHWlvZQVhYSR 4/fTZBVkr76zaat1FEZV8oiP1gcJ574FMOwLXObzDzR+A3LTy2D5iOoShq1a6XVj4tc0 fi4rDujpmBXxl9gpx2KS0bVydCJWqhrcwrmmxBRxMmoLa1m0IKpZZymraxDz+l+QYpBV 4ac2oGropnDxDRZoph3ZVU0K8+QlyZJV9oEpJQZKqD2TtXeBG+KeG68z/uBSjBFpXxdH /GdV0nSpmQlWC8/OvDLleqgMyeDSgP/SsjnVYVf1CRAe7JVyKr7Ne/Ln409wHLl8OL7N WQ== Original-Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3j4w25sv6u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Aug 2022 16:10:05 +0000 Original-Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 27QDqIDF036181; Fri, 26 Aug 2022 16:10:04 GMT Original-Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2042.outbound.protection.outlook.com [104.47.66.42]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3j5n6phv7r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Aug 2022 16:10:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LuHaZc6RBQYKWvSj8bhSdCL8iHdk/EB2h+kF7i6KJW6+0sDsHIRm8ZlSJPu8dzznO1JxslUJFhjhyMBahUeuB5E71BgPVRixI2DmvcMkVCO2IqVnZQ2XrMrk/mzMDRhjT9O8aEbPxRmTCCrl/4zEplFHK/FM8IInWaEn0XsdZboSq2zP4vsSf4XcKWkj5NmmLDqOKRUnbZYOVmPeJvnlIPPEWyMUnKtXRcRrK50m3/Ht0MBLzd15mwwE35gp/R022vKY4shZGltl42tD7uE5xCJv1599FmNCe95IhlXKOTkuqahVVhyR42ez9l+eQTMxl3OZ3Q0WKA9iA3ED4TzFIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c/g3VEfVD+l8HbPsJR3HMuGuqg0nKvQ3SFBPa5CNUEA=; b=GaL6eKLV8eFlQ2EsaxpkktJirFqhzsBoBEzd5tPggv5F+haiDAuEGg2IDjN63icSzNaZL/b+XJMJRbsRgncytoGOe6QdbpZjY+xrkBrVx6PhYBIsHZZyXcnW8pW74OuGwgtEEZ8zFiaQvHNk6dHrr/21v8PsvdX7FOwyDhZviu5j/CLD/+U/sJqCqr9JhgS6GD7aKVR6ljJFVbt8w7d2l/fvnRELxLMuEU0koOIgD311/ShD1wBeudfAT8ZgoYKmZBKz9EudkN8yAQulH6Ww35TjdbFug9Cg7BxxuDSa46W/sf6/OEkyfHAOaoBEWgTOj0r//SAhXC8mhidHo/qfMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c/g3VEfVD+l8HbPsJR3HMuGuqg0nKvQ3SFBPa5CNUEA=; b=nvl372A6ruYbj5XeISIl8q0FT/ruRAJj0DxuF5scIgtSUspNngJx9uFLgUQS4+qOgLBc98VHfVRhForRmxu2P2btdmUVlHyTKfJsCblisGPLPLyrcvQ4JTVKiBmwyfY+fw1FLM0uCppu1ljWVAZyjl4/LUSqjNooDK7pl5nhFuM= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by PH7PR10MB6553.namprd10.prod.outlook.com (2603:10b6:510:204::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Fri, 26 Aug 2022 16:10:02 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::570:ff21:c9e1:22f1]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::570:ff21:c9e1:22f1%2]) with mapi id 15.20.5566.016; Fri, 26 Aug 2022 16:10:02 +0000 Thread-Topic: [External] : bug#50431: revert-buffer doesn't preserve read-onlyness Thread-Index: AQHYuQ2bW0Fqz3kpPU+5aqH+opo5pK3BVzEQ In-Reply-To: <83czcn36we.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8a222fb9-60d6-4da1-41e2-08da877d6e9a x-ms-traffictypediagnostic: PH7PR10MB6553:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uiuP+eVED1E7hcVXZ1nU80IMn0bGelIddDoR0TeLwCsTO0i737ey/6+iggS9mk/l/kW9zatBJSnyj7lhCgZP/LZ40DaOwOjb/03hm/KOi4p+vEDu7gHNeUfCQCfufekqR/VNzcd33mjAcVAQLMNgsEjf1wsmqD9tIbmQ/aZGWhqqAq7sQ+SdLEuGN7bNF0Ig6+lpQUTnXrh3tC532izFcdoro5NQet4/Mzedb4qNA4R2woolOgAFdP208ikVtMKXOZOhSZJrSm5pPruc9afIEXyOFSbDFRqeaS3hIAABYDmdxx4HK04XQMjUjdAdq9ulSG06ghsWFWJNUtPRRnq4u/CLMTtlzCtIHAeC8+g8dA4JfjwNGylR9+I3mvLEewH3IYEEghbfMU/T0JxUymKuWTeWwMujLWSLutnAgH+AfJOX+xqXOdAofW+1BJex3SwYLNtlq4WE/fdAj3Ru/BkjXgJDdqsKLazY3C4ZS7xBpsBxT0CWh6JrZP7ZZig9z3FYTOwXeZKLjq1cmICDi0NfPgPTjGFRaRAwPjP5MtcPFDElNvrYUdHzG455t13ft1PBOdJqrP2zFqCrNBTLbJqdnOcqo9wl2+bZcZ9yPB+RUz71FmBDZvYZM/3zY2+1MIioOgQjLUIyqX2zoDLBTnELaSP4Yd2ZLdUrXS8Yf/UWSRUq3vz8KDdQrC+IaOCtpaNfPEKBhm5r/8+7aDWTNz+Q0QOMfi94jP5LZdBX03pj2CLMg1t5HuIc/wUJY+lXC jC+zxTyQTeyzfiSAVGlfg7BXg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(366004)(396003)(136003)(39860400002)(346002)(66476007)(66446008)(83380400001)(41300700001)(66556008)(44832011)(5660300002)(66946007)(71200400001)(478600001)(33656002)(76116006)(38100700002)(64756008)(8676002)(52536014)(4326008)(8936002)(86362001)(2906002)(6506007)(110136005)(122000001)(186003)(55016003)(7696005)(54906003)(38070700005)(9686003)(26005)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: LfIXlxTFifk/j3Clh8pOKuxnrvePIJJ2cxT8dwe9/Ljt4VMUyABnvE77ArWH9RJBVX2dk4lYFL0CJluKTS8/5BnEgNsZLoG7ET5T37b8uD+8SSJkoDDsnBCoZB4BC8tujL7yL5b2wjc5d+SWN79xh+ROXWgqtp+uP9MzMKOtmSQd4ASx4XoT4WwubXUfpl+/kdm0dRQf/PibztnTAfPJOcedHaBoxmn9ZwKp6ktMgXUSBRQc93hgKJmXL4/Xhg2mXIYyfzSJZgB/dUCosG7MjN2J3p6xmskn9FQjvsDTwMXDacI3/5a8ibssMzhlZFA26kLTjR4CnzCDWts0+wdMAjfKbz7deIJ17sBhbvMkFhnISbq64wH3kNwb38iGVR6ohjQHnKOZ08EYqFYqWNJJ2mZBnj32ZQZfyhpK/HOckLrg7BheWL1wQ1M7DVUhpRvw11gDXVhsPjU6kTqqZzXurmftaz86y9KRMvUqV7/68Myg8E5gW5cwe+VEb0ROIZ+9gxoNPjAhmUWaLVU890jYudLP81Z8om4hcheGDotfkbhsRTYIWaO7/2l/wbXCJDBXcycDtFCV7UuHVB2gRI2GNdqAdL0odOp9nQ5mY/hv6GvEtzabkrMAh+vU/Zgp/OxZgqbEebZeyGYS7CaX/vS8pwjDlaFATlDN1hjhnazqyE+5/00FkbIXeA2I4l9P5kFCTod9BN/tGUiitK3ww/kk/hBQiVWSu8NlqK7j9DpwQIsVANtI1aBbRATN7q OxotabqGFxwHdH27w1pxW/IOQVjoaot5Ewozo32OHguzEOAy1ZlM0OhmUhhLnnCbNrEPMvMOEzoazaPaPXN0vrrbLU0saSSQKS X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a222fb9-60d6-4da1-41e2-08da877d6e9a X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2022 16:10:02.2455 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nKyjioG0uPO3wHngBXn46ZvVEjR080jpnzMjuLIw0hOCw98BqX9EPKnefU/QEkl3r41fZI7pd0Nlio0M70f/3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6553 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-26_08,2022-08-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 mlxlogscore=608 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208260065 X-Proofpoint-ORIG-GUID: YCB27XKpHFkOyvJl9vY1_tZb4aFYfc3O X-Proofpoint-GUID: YCB27XKpHFkOyvJl9vY1_tZb4aFYfc3O X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240851 Archived-At: > > >> Maybe minor modes should be restored after reverting? > > > > > It was a regression when reverting stopped to preserve > > the read-only status that worked in older versions. >=20 > IMO, that was a mistake. It violates the notion of > "reverting", at least in my book. Yes, there can be different notions of reverting. In the file-visiting case, it generally means and should mean, IMO) respecting the current state of the file on disk. That might not be the last state of an unmodified buffer visiting the file. Nor non-file buffers it can mean different things depending on the mode or whatever. It's really whatever state/behavior `revert-buffer-function' defines. Dunno whether we have, or should have, guidelines for what kinds of behavior generally make sense (or generally don't make sense) for `revert-buffer-function'. I certainly wouldn't expect, by default, a file-visiting buffer to have all previously enabled minor modes turned on, etc. And I wouldn't expect a buffer visiting a file whose disk read-only status has been changed to revert to the last read-only status of the buffer. Reversion involves substituting some state for the current one. Sometimes the new state is in some sense a restoration of a previous state (in Emacs). But clearly that's not the case for revisiting a file whose state on disk has been changed - whether content, read-only status, or whatever.