From: Drew Adams <drew.adams@oracle.com>
To: Stefan Kangas <stefan@marxist.se>,
Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "8951@debbugs.gnu.org" <8951@debbugs.gnu.org>
Subject: bug#8951: [External] : Re: bug#8951: 24.0.50; [PATCH] enhancement request: buttonize key names
Date: Sun, 24 Oct 2021 21:07:53 +0000 [thread overview]
Message-ID: <SJ0PR10MB548895C642A523630CB8E97BF3829@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <CADwFkm=FmtdWeZsUh9Cv9M5c909ntafsR3Temp3uwf_qGqsoVA@mail.gmail.com>
> >> What is the feature? Let users click a key description (i.e., a
> >> key name, such as `C-f') in a buffer such as *Help* to see the
> >> associated help. This applies to key descriptions derived from
> >> \[...] doc patterns (only).
>
> The attached patch adds a new option `help-mode--add-function-link'
> that when non-nil makes `substitute-command-keys' add a link to the
> `describe-function' for the bound command when inserting keys.
>
> I have reconsidered my previously held opinion that this should be off
> by default. From using this patch, I have come to the conclusion that
> this position is wrong, as this is in fact highly useful in places such
> as `M-x ibuffer RET C-h m' and on many other help screen besides. The
> only adverse effect of enabling it, furthermore, is that you might have
> to hit TAB a couple of times more on some help screens. So I think
> having it on by default is very much a good thing.
Glad you decided this is worthwhile, after all.
You seem to have ignored this, from https://debbugs.gnu.org/cgi/bugreport.cgi?bug=8951#17:
I gave this reason to make it optional:
\\[], \\<>, \\{} are about mapping command names to
corresponding key descriptions - nothing more. That
in itself does not say anything about help buffers
and interactivity (clicking, RET). The function is
just a string transducer.
The common use case for that is of course doc. And
the common use case for the doc use case is a help buffer.
But a string of doc is more general than a help buffer,
both in terms of string vs buffer and in terms of the
need for button text properties (interactivity). There
could be applications of this function to produce a
readable string that do not involve a button-clicking
interactive context.
Instead of making the choice of whether to fontify/link
key descriptions (1) depend only on a user option
(dynamically scoped variable) and (2) hard-coupling it
to use of the result in a *Help* buffer, I argued for
(1) adding an optional arg to `substitute-command-keys'
(to make the choice), and (2) separating creation of the
resulting fontified/ linkified key description from its
use in *Help* output.
I think my approach is preferable. I suggest it still.
next prev parent reply other threads:[~2021-10-24 21:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 19:13 bug#44909: Hyperlinks gone for first story of two-storied *Help* buffers 積丹尼 Dan Jacobson
2020-11-28 7:39 ` Eli Zaretskii
2020-11-28 7:56 ` Stefan Kangas
2011-06-28 16:38 ` bug#8951: 24.0.50; [PATCH] enhancement request: buttonize key names Drew Adams
2011-07-04 20:28 ` Stefan Monnier
2011-07-04 21:08 ` Drew Adams
2011-07-06 18:49 ` Stefan Monnier
2011-07-06 19:55 ` Drew Adams
2011-07-08 19:07 ` Stefan Monnier
2011-07-08 19:20 ` Drew Adams
2019-06-27 16:35 ` Lars Ingebrigtsen
2021-10-23 0:46 ` Stefan Kangas
2021-10-24 13:36 ` Lars Ingebrigtsen
2021-10-24 13:54 ` Stefan Kangas
2021-10-24 14:15 ` Lars Ingebrigtsen
2021-10-24 14:56 ` Stefan Kangas
2021-10-24 21:07 ` Drew Adams [this message]
2021-10-24 21:37 ` bug#8951: [External] : " Stefan Kangas
2021-10-24 22:05 ` Drew Adams
2021-10-24 22:24 ` Stefan Kangas
2021-10-24 22:47 ` Drew Adams
2021-10-24 23:15 ` Stefan Kangas
2021-10-25 1:32 ` Drew Adams
2021-10-25 2:37 ` Stefan Kangas
2020-11-28 20:45 ` bug#8951: bug#44909: Hyperlinks gone for first story of two-storied *Help* buffers 積丹尼 Dan Jacobson
2020-11-29 10:25 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB548895C642A523630CB8E97BF3829@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=8951@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).