From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#60623: 30.0.50; Add forward-sentence with tree sitter support Date: Mon, 9 Jan 2023 15:57:16 +0000 Message-ID: References: <87o7ratva2.fsf@thornhill.no> <86bkn9whgl.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8385"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "casouri@gmail.com" , "60623@debbugs.gnu.org" <60623@debbugs.gnu.org>, Theodor Thornhill , "eliz@gnu.org" , Juri Linkov To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 09 16:58:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEuXX-0001v8-3H for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 Jan 2023 16:58:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pEuXF-0005hH-34; Mon, 09 Jan 2023 10:58:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEuXC-0005gI-UI for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 10:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pEuXC-0005ES-M9 for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 10:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pEuXC-0001kh-Cw for bug-gnu-emacs@gnu.org; Mon, 09 Jan 2023 10:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Jan 2023 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60623 X-GNU-PR-Package: emacs Original-Received: via spool by 60623-submit@debbugs.gnu.org id=B60623.16732798436686 (code B ref 60623); Mon, 09 Jan 2023 15:58:02 +0000 Original-Received: (at 60623) by debbugs.gnu.org; 9 Jan 2023 15:57:23 +0000 Original-Received: from localhost ([127.0.0.1]:37985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEuWZ-0001jm-2O for submit@debbugs.gnu.org; Mon, 09 Jan 2023 10:57:23 -0500 Original-Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:24862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEuWW-0001jb-SO for 60623@debbugs.gnu.org; Mon, 09 Jan 2023 10:57:22 -0500 Original-Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 309FWXBO007462; Mon, 9 Jan 2023 15:57:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=ix97NnABBETDNYgl3Vr6w+TU1ypzhhCB0HqCkBnbn1s=; b=XH3/LyA0jW9rLPzh5sx74DG7ydxFPgiW4EvWkGtM4OXxB1BRn1sjZ20VuShNy75CdsUI dvubdinXLpLwUwYtISzVNtz2kj/u67SVoqEHmFWDpHMnAg6E4AuaE6EDFubE3exJ7Xae bZDeQyvuY7CJ0+dayl3yLhfWs55slkNWH9TMSdmMcW3/FhQMgIFwsm9DUa4JJSMMUTZL J8hhhl7p4sKhYv/wt3Tjsla04jLHVkpVzBzmo/4PhRECtNWMgsc0iyHr7TpQOJApnphO b3ajR4oyDT/xS/mhHSFsT1Hv4rnEt1GS6AkBx5O7JXowoxvx4C3BTble63480e/8f7OY Bw== Original-Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n0nn102dn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 09 Jan 2023 15:57:19 +0000 Original-Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 309FCTWq035379; Mon, 9 Jan 2023 15:57:18 GMT Original-Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3n0h8uands-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 09 Jan 2023 15:57:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ok80CdfXiPfNp02tlNDxGTcpxM3+IhQaYxApTfF6iMoGiyRnJ/49tVdAE5eIwV1k2IxHC/Vrb6F61MhQaf75ScPf+Ew8yHQsiVPwePbWgfw2YUiqZc23Z80uInuTqoHT2B0DLrU0D9ZlDmeNz5Q7Mn5y67aQRuFyEFX+jYZC44wM1jy3vgULNUNgWG4WZ2ijtO1GUlAplAZP05NYEAqB1169S3dUV9/tA80Jvfnb8ujCokp1UOwJIy9wEl+6zQuDSU3GjayE714QTXfe54XdFN+PL2aH6HS/K+m0SZnI68UFEBtnSCEBfMGEhxxsiDzOJ1RRdJ5zSKMkUwfbkpTthQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ix97NnABBETDNYgl3Vr6w+TU1ypzhhCB0HqCkBnbn1s=; b=ULKbrJ3tWSZTbeJ5Ujwdv+1QS6Fu/EbZA98ArzCeCQnaYDYjMDYUrSLP00SeA/GhhtYMWra/mdVGJSKbMXJA1Lwf3E2pmDiw67Fs0ohrwvZiP3XPK12nk0rloiRiYzTUcd4HbGSTP8ozCYCH9boLzQbdq8mXUQaivEtIQx0vPirYUcOkebRflUUzW881GF3iyim6NAGn/Y1/e+CfNKiAiKsfA0gSFgXAgdcbZYah5iSjhIX2G/sCoJgh00mTr24HCvyyS4gGSMaLeeCFkNvK/Qcrs7NJVTgnUl34z+Vb4kybMJRL/0lSWKVaNFQ0ag4gPvdCzapZSE4TX4c32AJ+yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ix97NnABBETDNYgl3Vr6w+TU1ypzhhCB0HqCkBnbn1s=; b=qZrsXJ32KeTI04ZvbivN+lBOvaZ8m1qp5heg7PogzibH0xMuKzWaKhv6kiN3GFKy+vwEhtPgw0LhTq0zPuOuScA2J8Te0BSgR7ZbsBznpBYIhRF+qDpSoWOGoQhEnnGHmv8pQzSq4DewgMjKnWjYNVIMypyY6D9IZgkpo7t0GtQ= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by MW4PR10MB6559.namprd10.prod.outlook.com (2603:10b6:303:228::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.9; Mon, 9 Jan 2023 15:57:16 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::7c3c:e53d:5276:ef29]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::7c3c:e53d:5276:ef29%7]) with mapi id 15.20.6002.010; Mon, 9 Jan 2023 15:57:16 +0000 Thread-Topic: [External] : bug#60623: 30.0.50; Add forward-sentence with tree sitter support Thread-Index: AQHZI/KNyfYC8zSUJUi0/j5xFlVD9K6WNwbA In-Reply-To: Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|MW4PR10MB6559:EE_ x-ms-office365-filtering-correlation-id: dfba8198-5f2d-41ac-4644-08daf25a2e92 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Tb0BVtE/liuBWDwWQxl+ToRShrrex3X5OsmxB8Qsf7NLTy+6ubM7QM5OuP3zZ2JHnMFaU81Dd9qrBSgPgYZJpM5+7w3KyVoDGSTjn3x06Gb167t/S+QkgDI5CYsgzeqpSbux+vl1NEsye/vx15FOSGD8H2dMl/v7IIGgOsAQ74TTx2Ak2NloSeLYTkMQDxa4gikXYzxY+G7jXHQshqSM+7Sw8HmjHFEN2cqPgIreIXaXlchHUtxaQV7kuhTCAiEXAr+w+w040nmrVoVuyl87VlOtC9lNpUbGypLa/wFFebxA+tg0sAODLwsLtQxhAnFVB2qbU8r/GHNFVVp7HWpTISIujQOkVbfh1aLLo2L8ULvrHl5+pgRwEY1Tyzbqmln/wq6XT83IUvhjM6ID/TSXkXK7p4gJeZkfRxKalJt4XFOBXNFuq5gk7po1sf1wmZA5delf+HpMLoRz3C/abXKjxT7DqkKIsHbW/Fz4G2D0xyr+ZZ3ehS1Zck6tG+wtXjzN9/Ls3+O3u7KZZikeCaZsgmEjeyYbL4JjnBNDqFElpw8IA6PX86mOhzR1WngIpnUy6xhMyRngvisego8fA1SZeQGd2Nwk/glkV2tmoJqVIN+UCnpQScHlHDpKGJvg3Jn0EuwFwBd7nTcNsIEbTlxMq4kNkVUlxxZTvyCJN2eGhghiGCrG79hcfh7Jp4OWGRGaJkOyPwERbntft8p2RjWhpA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(366004)(136003)(396003)(346002)(39860400002)(451199015)(38100700002)(6506007)(122000001)(2906002)(38070700005)(478600001)(33656002)(44832011)(186003)(296002)(7696005)(26005)(9686003)(5660300002)(71200400001)(316002)(8936002)(52536014)(55016003)(86362001)(41300700001)(8676002)(54906003)(66946007)(76116006)(66476007)(66556008)(6916009)(66446008)(64756008)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: eFbzOMfMzq9eaOKCKvxOPiNN6r9lSkpfAnHh8klLDuE/E5geMWm94Yla6/LalIR1LEQbeo7H9JTI0BXDlg2SEy/Z9Jv3jUOPZUVZSbcOrffLyYLBzROFapgXT0AL+Y2ENMiJzoGCRbCTAalu2qhPbuk2WEp8mmh//YBmww8UD9pcfYRMnbTG5XRcVzPhgkA1AN3EyVlMttjcQhrqebyDFYtoHYMC8wSVez89g6Xz946o0CpEGVq9++VSJ0Umdir3phFJSoJbcaSKJgcYi1aOGXntV6zLOl7GSNty4jqKcCe1LOfQsl2xUQ5f38iJEZznO8KyyO3mRaeWzk2483YlPCYzdl2ZU/uubmo1NGtuE9Wfh4qdJQx+8AzlSYBv4I6lskpZHovin2u9fADrRk5Y9gfdqVjfQcfHy0mHy3EnyUCp54QKnOmqRBE80hsWKR4QbFRk2Ohww3y1xN394QSeid4/yqojFVuUmkUyAJ3tTwpJDg3dqotYQjjQt+nAEzGoKec5r8TxRFZjQgIIzcnhrkD2lExmeYmmDW6vc0xI1lvY70G2m4ECmc5KUhmS1tCPTWcanzQ0FQIuPC4wo7+sjyh4D9x8bamOpTEwMLJ3xCBxXpTmAXWhlDejpZW9NUkY/eIUruargBnfCQoADaQLw9c2DPn5a5ssqAagiY1xS9xnLQVux8g108M2PbjjFaA2+fe79MGd7Z7vdIcq8okOaE0GGGhiZS5lBEZzVGJiUwazSnBg+zdtXH1l18 ATazrwYMHdKeroKI6/P8ggk+VL/zrxGxSVyqkumuYc3XLQDNl9VLq6d6zAhFHkeSaHLiMyxXa0ADXtAFa89pyLMO4ZEvw1IjdC X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Xeey4p1KcJyiP9E7gR+/1G4kmDn2E8pXjHXfbdQJUT94a7b5cgmrRlCvHaxanUOoPTn5f6jB6SzQMrY8zy4WFgT/Vc53QKgCK06Qm2frCBQlqBOGYhyOVO7BsYX2YQhB9j+BthsOKKd3S7OdOb537PiBjFt/UOdPRqlhnQn/MFr9LTr1cRtWhqSpObjfQimAkGmqz/dUsq+l2l1SjE1J3+pvdjhXeBEXqhMzSLtJtXf3/MLKzit2NC2aab6CAcsCrQiE/DMxVKwoyo4mQL3IhjQ7l8UjdQDsxUY30TXcwfZZ1CstsuiEc948Q6WBCdeqjXDOih39NRaTHcYVQ2F+T7YHMcFspZcutJoDCXeOUedy7xFEn+1RwkYBazna893SMbD15kvku3i03ZHYDvZXr3J8cLlpzeilb3i6hQcf9k5kDAF965ucqjoTpFNNKkmKVQTuHHI3lUuLpLHUXL4ajTCZd392Uy22vHVPdUT0Dz6RMNn/x37lL6rWhO8wF9eZZYFAt1AS9OrMIuMKOSJnvacPuwW/Ui6Per/SRkTfMu/z8CX0mJZqjA8+WNnvo0ZBDn0+GDYGAqM20qWGbHiKm9lULbss+ZkF0lGLtoGRKhGxD1nSOffYc1Bw5+Y0oujN0+JfzBJ5t9Jrs91Pvvg99rIiTM8yhQkL0SOuXW0v2EoMAkRZr+KUkhNFJQyvxgArB9qkWsPTa475+rNYImQE70HMc0X3WQq34s5dM94Kv9WROT QSELMyzTqLE+U86qmUpqtnoLibVQgFX7oY92jGg74BFDs0XYjrM37+ASbhTLC35KjfD+9izHR7Su9hGA39Sqq3iOXXRtDS8Tpw X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfba8198-5f2d-41ac-4644-08daf25a2e92 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2023 15:57:16.8194 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lrDPOYaThcINDFN9da06FmEeW4KLp2csCIZV/Jodgf0KSwVqCJFQtyQ1VxTHDfhWsiKPbkdUswb7sM/XHij87w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6559 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-09_10,2023-01-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 bulkscore=0 adultscore=0 mlxlogscore=877 phishscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301090115 X-Proofpoint-GUID: YoeA1aBnzG3qfUxO3DGg45wt0EzlCvIV X-Proofpoint-ORIG-GUID: YoeA1aBnzG3qfUxO3DGg45wt0EzlCvIV X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253027 Archived-At: > > Exactly. IMO, if the variable can have ^^ > > a nonfunction value, especially nil, then >=20 > Bad idea. I know you think so. ;-) > That precludes changing the value of the > variable with `add-function`, Yes, it does, at least blindly and ignoring its current value. And that's _appropriate_ IF the var can have a non-function value. But even in that case the var value can be tested to see if it's a function, and if/when so, advising it can make sense. > whereas `add-function` is often the best way for > a major/minor mode to change that variable (actually, the "only" way to > do it with some hope that it will interact correctly with other modes > that may change it as well). A legitimate argument. But it doesn't apply to a variable already defined so that it "can have a nonfunction value." Did you perhaps miss that "if"? I also don't agree that that (_good_) reason you give is all-deciding. I'd say that _other things being equal_, yes, you can take advantage of that good reason, IF the variable's value can be ensured to always be a function, or sometimes even if it just is currently a function. IOW, you give one (good) reason for one (good) practice, which, yes, can sometimes make sense. > > there's no need (nothing gained, and even > > possible confusion/misunderstanding added) by > > adding "-default-" to the name. > > > > On the other hand, if the value must always > > be a function, then having "-default-" in the > > name makes sense. >=20 > Agreed. It's also helpful when you look at the var's > value, it lets you know that it hasn't been modified.