From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#65621: [PATCH] `dired-next-line' go to meaningful line Date: Thu, 31 Aug 2023 19:10:57 +0000 Message-ID: References: <834jkghcu1.fsf@gnu.org> <83y1hsfw83.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16650"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "65621@debbugs.gnu.org" <65621@debbugs.gnu.org> To: Shynur Xie , Eli Zaretskii , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 31 21:12:40 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbn5r-00046U-V3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Aug 2023 21:12:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbn5W-0003vg-QA; Thu, 31 Aug 2023 15:12:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbn5A-0003tX-6R for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 15:11:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbn58-0000wz-7E for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 15:11:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbn5G-0001U7-UH for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 15:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 19:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65621 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65621-submit@debbugs.gnu.org id=B65621.16935090775636 (code B ref 65621); Thu, 31 Aug 2023 19:12:02 +0000 Original-Received: (at 65621) by debbugs.gnu.org; 31 Aug 2023 19:11:17 +0000 Original-Received: from localhost ([127.0.0.1]:59246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbn4X-0001Sp-AX for submit@debbugs.gnu.org; Thu, 31 Aug 2023 15:11:17 -0400 Original-Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:7788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbn4S-0001Sd-2E for 65621@debbugs.gnu.org; Thu, 31 Aug 2023 15:11:15 -0400 Original-Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37VJ4Uvu012563; Thu, 31 Aug 2023 19:11:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=iANJmj6qAT9P7kbQSEhOU+Fa743x+EQJhxZzdc0gqmc=; b=dUvDf0SdRs1KgejM2a7V3ojPt4m0LAJmtetbWVSzfhMbuBxanPLbeBz9HgUbdM0T5biw wmJ15br46PU8vIhSIOW20BWrhRtWoV1FwXVTLPQEXCYqqVsVJwa97K4NBTR94vh0Cy63 q6pAT5geXqXkbFBEIUDGCUqNXgyXu4wNjnTxZBHHNznJ6Fu1dHKGEujkLSdbpxGASQsS uxbat6mvskmZIIgLUnPPRPqVPo6Vaa7zU1sL7O0GsYrUrngE3qE/OPm50Xic9R4708wa nD1SRNmqR9ZwjuIkS57l8a0WfdZC+l4Mvsis8EZjVhEPM2uzGhON5pX5uIH6o/I974hr ZQ== Original-Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3sq9j4jmqs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Aug 2023 19:11:01 +0000 Original-Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37VHYUCu009143; Thu, 31 Aug 2023 19:11:00 GMT Original-Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2174.outbound.protection.outlook.com [104.47.57.174]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3sseq0sfav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Aug 2023 19:11:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UEMwUE95ACVPiLU2Ys/fU0fCD7tWBGV/DyRj1ihD4Nt5OPFtBF4ubcJXvB8aL2IXA6dk07ofAuF3DJg/R/B0jJo0S4j8ZML/H+Cgxc3sHPDU4CtMu1WTnQQdr1vjW7A1TQGolQXdzi9jI3emULiubCSLO8GvdDqcOIJd0pAuy5KB3dw8dEAw5ODaawI83jBbKFXz3lxtKURo05olVN3i4a2kAmhZO6w2IlosV6H1phT3dftu8bK4cuR5bMMT+Xd7UuFbGQGGuJyauQIa74gDpXFq6U0dPlm5okE2VYIWMyub1xOuRiJDjl2JC31YXxf/O5FZaz9Mr66EmXpKxGNETw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iANJmj6qAT9P7kbQSEhOU+Fa743x+EQJhxZzdc0gqmc=; b=AX3m3dy83x9VDnzZ/eDW3J3MAyxlbN2rMTm9DVTrD7A1vkXVrl0wfdTsTh3zZKrb6VE10giH5IsjyZwzs0ARI4bmZGYka4yW64MfNukQW8wQHD78Z0h94XzddS1ktakXWXxmOqR1Hqx3rWL61WAVHJX/8YtPNzauGURDPLips4EubIPK95xXYeJNY69v6Ly7E5/gyuo7mDeJofHV7TatV+zGamYBkPXfyqhJjqi1yKQTSqdtJmfmgQTyXOuzakntIMkHmZvZe6CFt6C7/c1WnAdqrX9Y352M7WNaa9gyqtvFPtBcPK2eKpKdIYr0EV5Vu3DADRkOC+GM6qO60fx7Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iANJmj6qAT9P7kbQSEhOU+Fa743x+EQJhxZzdc0gqmc=; b=qROivZaVuz8PjEcZneKMFG6RGof5knpC4SCPHNhD+viKxmx0Xii7mUStKHARL1nVrMhLhlKDCv2I3okTpv09+RHanhc3evwoDxoXU4bCzz5Q6Hz0PvLEvsHRpFFt3zIIpTLExeut5X+6nagNoem4LtcrHBPlAy2yLwMYgcOv7gk= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by CH3PR10MB7188.namprd10.prod.outlook.com (2603:10b6:610:121::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.34; Thu, 31 Aug 2023 19:10:57 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::7c3b:c5a0:5222:69a4]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::7c3b:c5a0:5222:69a4%6]) with mapi id 15.20.6745.021; Thu, 31 Aug 2023 19:10:57 +0000 Thread-Topic: bug#65621: [PATCH] `dired-next-line' go to meaningful line Thread-Index: AQHZ20HT/8wr5daoKU60WYHNTQV+4bAC13cNgAABd6SAAArZcIAAUhkAgACwII+AAKD/oIAABN5EgAADr2CAACeyeIAADBAQ In-Reply-To: Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|CH3PR10MB7188:EE_ x-ms-office365-filtering-correlation-id: 27124313-f91e-47de-1919-08dbaa5601bd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SNeMIbvykKk7Qd0zadM/8ldxSURjInkM4XYIZ6WJ82NmaeqhnRGXqMg54npgvWawYMtNRRTkyivjB0UPT49JpR46rPjl5oQgnef5W31tXwqMdUTIG72ARY6+ondSIV3urjmDvHtB/sIsVBIc/MkSrn33ZfMcIF93xfPTzttE3/H/ZdcXDCns2mKh0EGoX8CBhZMoDKpv3zmy8SNGDZzfJsUtxov9zI+NnxinQv2eMj69BkVm94KBRPxjuf9CRgp0yXfgfjmk5Go6L47IK5gWYL7bjum+a/Zb9ZXcDP8/vgAgkuEdwWkFzA6f5BTcXts52b9fmP13Pr5d1XFm1SSWHoW/Thsbp1Ju1V9hkplgfUaPar0MQx/1/yRomKi0kcLR+itvggNDpX/WoAA/emjUy+Xz0JuClT5n9LhdtuoX+BKg8+LFafuASwtOvJJxeZVv7USw9Ik5meZksJyCviu6zYBYG4KfDigc3ZRWpxePtnvqPbR1UstKJViUBPydk4PdR+Mtr+waHrqAT2lLPYTdsTu0l3jI2hAfqZz2b5h7fNSnWrAV3kVQqmhIfWTdDAjLkwJW77XQ90o+31wKMPxGb2AjopBu4riGoMFtPu/di6E3cigepfT+fw+OOvjlerD9gSlY1lrjdGizQeQfN60wyw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(366004)(136003)(346002)(396003)(451199024)(186009)(1800799009)(55016003)(66899024)(6506007)(110136005)(71200400001)(7696005)(9686003)(66556008)(66446008)(8936002)(33656002)(52536014)(5660300002)(4326008)(86362001)(41300700001)(316002)(38070700005)(66946007)(76116006)(64756008)(38100700002)(66476007)(8676002)(44832011)(2906002)(83380400001)(122000001)(478600001)(26005)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: dlGLqbUwdQpCeBLNiSWUK/OLNLBrH+2yzpPiggpygGDOeBp+t/jfvuXDVyBN+QBDmfrgPjo+V/826Iv51rVKC9v7kUevawpVhFcidd3CNa6gtM5hKMbl1VZQaXz9jKihNQ3YB0iXTcoeaIVbSd4Oo5gglKvKLCSRTOCFHkORHIdONAh2E4F9c0QOUgmFQh5/r1fmR6LeWz+dShrS1L5jhK7vyCZLsSgMMEPdB/7mh8CSsGpSyV+qwo1CQzHvpbvjJ6cgSGKQnafTQWT3DWz7o8PggSATLqyypGu9zYFoBS53XTgIKw/W7h4XLcofmL211C2OPUL5iE5UFhr/HE6edBAfRz14PQyQk+Nv/fjLxMPEdouxTf0MUv0xO2ZYA86SdMj/rywJ/I9VoYUm3icO9PAwlvR4bOspBwdsLnyx46wPwcxp/kquE1rWSeAxffG/TMcY1lO9ZJUkCblo/6XB9qT44605TT7lyQGk8KwunRB0a+JJupm4qsOywKX1G1zcMjntMhWcqGX36/xoQVPzQrq7NGsafZ/6eSdPNRaRUondf753t8xdh08Dv2laVISFJkQRWvOofmJVx5ZJXzQRLlqhflQ5R875AiCtwVeXcOHHxD5gflkL0wXLP6dv/ldDQa1wFCI4WtONRsVBIHh0cZ0jgxlHIcDEVTyTHD1m6wHvDJqVlH47e6iU0gfJFzbGwJ9hlxF2FvERjYSrpeSMKu4vFx1yGa+77ZMwOUHwW7p/tgHFPW/Gp5/deg TSMovY3OxBEiyhjZxH2s0OiqT7arBXnDTNUYYA8dDT3MDPb9gwrm3LNEQid7afNhCXbOtkpZ+E7+X6E1gUdss9Cw7YKTOFYyjq X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WKfEiGsXae4jeWh+dUpM2XhRL389Vtsn+Ni/sHeAx9yJYn0HT9J2xO1l9we5pjeMUYoaB/7WobHCZ5ttS/pjfkcAl/+0a/uOhwMcH2eDiFIR2bJk/io0rPuNggJ29/YAGygbXJGnc2tYtZk6kqximr0QXH4cjg5DqyitA0lxO2oO1SD5aG3xP6vaQ/ApojK/GQMrLwAJ0qM5NXGc/17wFIEmFaRgglxiTTVwIdUti3W1tgsEfPaX2aUKQ6/WMGAfFTi7HsV+EJsXygN/Drkg+4YW0dc50YdN2TdmKjVlgqEfNoQzBtZ+6pxccjKIZV9weRpKCWCUckfpSNB6qLyQiKnMK1SY/6m739xTzQDXBMTiWKaQWi5wm+dgtxduy0yxBmJ3qwFuq9HU0s+UZq7bKWrI9K2BDoko77uDmj3o6U/IIXA0gXfPp1Zzu6Vpqu2FxGG4n2PaZ1lEQP4Hj0ZMEY8Gq6pyd5Dj7k8whooZFfgoB6dWjSAivZiSHsc3aRcVpolfkwo1x0u4ob2xKsYRBU0oFcovC6UiZDEIjvRCe6OZPkiwT9D4hjai7ZYEQJTuumMHmlia5Jqre//iuZNCCkgLsfp1X3JZJ0wUIWe0ow4Ri9E1ExFnYxuZb/7mRlzfqKxCIDM71DQ/4gLs4dTYBfpfJtlIVL/QiH/mf9dfpJce6J6ewaO2kCjps5x0Mlsb71FZ0M1zJEjv03JPz0D1JfaN/2rcpBjO+k0DTk3ZAv+KoQ oTaFVlQujMf2Lfgagqoc3jaE21+01gXp8yzi8ZxF1uWsg2ge/vccVHFFMK259hSFZnjGsi6GxUdgYUJBsDycCkkReNxFQBp+FS X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27124313-f91e-47de-1919-08dbaa5601bd X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2023 19:10:57.5951 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +xZHFiMvt4tp78P0igE+X33fKRlysJleHJi1keb3JcIdjWw4jzk6OIYDfIp5KyJIhlyxtsSdWsXEticRjoOEIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7188 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-31_17,2023-08-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2308310171 X-Proofpoint-GUID: K4FX-g9aZ2PQ-fE3FEAryp8CjsrvXE5_ X-Proofpoint-ORIG-GUID: K4FX-g9aZ2PQ-fE3FEAryp8CjsrvXE5_ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268838 Archived-At: > Stefan likes my original patch, so please set > `dired-cursor-goto-meaningful-line' to `bounded' and > `dired-headerline-is-meaningful' to nil. >=20 > > Dradams: > > it should move to the subdir header line, skipping > > only the blank line before it. > > `dired-(next|previous)-line' should move to header > > lines, as well as to file/dir lines. > > If you really DON'T want `n'|`p' to go to header > > lines then maybe set some option. >=20 > Have taken your advice. No, you haven't. Not as far as I can see. > You like what your Dired+ does, so please set > `dired-cursor-goto-meaningful-line' to `cycle' > and `dired-headerline-is-meaningful' to t. No thanks. Based on your description and the definition of `dired-cursor-goto-meaningful-line' in your patch, I disagree strongly with this change. Currently users need not do anything to be able to move to file, directory, and dir-header lines with `n' and `p'. Those lines are as actionable as any others; they should not be skipped over. That behavior should remain the default. Users should not need to do anything to have `n' and `p' move to header lines. Making users customize an option just to get the longstanding (and only useful) behavior would be a big step backward. And it would be for no gain. AFAIK, no reason has been given why `n' and `p' should skip over header lines. `dired-cursor-goto-meaningful-line' must default to `t'. >From my point of view it need not (should not) even be offered as an option: the `t' behavior should just be all there is. Have you - has anyone - given any reason at all why `n' and `p' should ever skip header lines? I don't think so. (And there's no need for "cursor" in the option name. That's implicit in going to a line.)