From: Drew Adams <drew.adams@oracle.com>
To: Shynur Xie <one.last.kiss@outlook.com>,
Eli Zaretskii <eliz@gnu.org>,
Stefan Kangas <stefankangas@gmail.com>
Cc: "65621@debbugs.gnu.org" <65621@debbugs.gnu.org>
Subject: bug#65621: [PATCH] `dired-next-line' go to meaningful line
Date: Thu, 31 Aug 2023 19:10:57 +0000 [thread overview]
Message-ID: <SJ0PR10MB54888C7308CD404FDBFAEB49F3E5A@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <PH0PR11MB7470C711EBAB79091E0EC63FD7E5A@PH0PR11MB7470.namprd11.prod.outlook.com>
> Stefan likes my original patch, so please set
> `dired-cursor-goto-meaningful-line' to `bounded' and
> `dired-headerline-is-meaningful' to nil.
>
> > Dradams:
> > it should move to the subdir header line, skipping
> > only the blank line before it.
> > `dired-(next|previous)-line' should move to header
> > lines, as well as to file/dir lines.
> > If you really DON'T want `n'|`p' to go to header
> > lines then maybe set some option.
>
> Have taken your advice.
No, you haven't. Not as far as I can see.
> You like what your Dired+ does, so please set
> `dired-cursor-goto-meaningful-line' to `cycle'
> and `dired-headerline-is-meaningful' to t.
No thanks.
Based on your description and the definition
of `dired-cursor-goto-meaningful-line' in your
patch, I disagree strongly with this change.
Currently users need not do anything to be able
to move to file, directory, and dir-header lines
with `n' and `p'. Those lines are as actionable
as any others; they should not be skipped over.
That behavior should remain the default. Users
should not need to do anything to have `n' and
`p' move to header lines. Making users customize
an option just to get the longstanding (and only
useful) behavior would be a big step backward.
And it would be for no gain. AFAIK, no reason
has been given why `n' and `p' should skip over
header lines.
`dired-cursor-goto-meaningful-line' must default
to `t'.
From my point of view it need not (should not)
even be offered as an option: the `t' behavior
should just be all there is.
Have you - has anyone - given any reason at all
why `n' and `p' should ever skip header lines?
I don't think so.
(And there's no need for "cursor" in the option
name. That's implicit in going to a line.)
next prev parent reply other threads:[~2023-08-31 19:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 13:02 bug#65621: [PATCH] `dired-next-line' go to meaningful line Shynur Xie
2023-08-30 13:36 ` Eli Zaretskii
2023-08-30 13:50 ` Shynur Xie
2023-08-30 14:20 ` Eli Zaretskii
2023-08-30 19:14 ` Stefan Kangas
2023-08-30 20:58 ` Drew Adams
2023-08-30 21:34 ` Stefan Kangas
2023-08-30 22:36 ` Drew Adams
2023-08-31 5:45 ` Shynur Xie
2023-08-31 15:35 ` Drew Adams
2023-08-31 15:46 ` Shynur Xie
2023-08-31 15:55 ` Drew Adams
2023-08-31 18:15 ` Shynur Xie
2023-08-31 19:10 ` Drew Adams [this message]
2023-08-31 19:17 ` Drew Adams
2023-08-31 19:44 ` Shynur Xie
2023-08-31 21:51 ` Drew Adams
2023-08-31 21:35 ` Stefan Kangas
2023-08-31 21:37 ` Stefan Kangas
2023-09-01 17:29 ` Shynur Xie
2023-09-01 18:46 ` Drew Adams
2023-09-01 20:51 ` Shynur Xie
2023-09-01 21:06 ` Drew Adams
2023-09-02 12:05 ` Shynur Xie
2023-09-02 12:13 ` Eli Zaretskii
2023-09-02 12:18 ` Shynur Xie
2023-09-02 12:39 ` Eli Zaretskii
2023-09-02 14:40 ` Shynur Xie
2023-09-10 7:45 ` Eli Zaretskii
2023-09-03 21:47 ` Drew Adams
2023-09-07 15:04 ` Shynur Xie
2023-08-30 14:54 ` Drew Adams
2023-08-30 15:39 ` Shynur Xie
2023-08-30 15:55 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB54888C7308CD404FDBFAEB49F3E5A@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=65621@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=one.last.kiss@outlook.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).