From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#49534: [External] : bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Date: Tue, 13 Jul 2021 23:00:55 +0000 Message-ID: References: <87czrmrxfv.fsf@gnus.org> <87zguq6mof.fsf@mail.linkov.net> <874kcy6k4l.fsf@mail.linkov.net> <87pmvl3kz7.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40544"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , "49534@debbugs.gnu.org" <49534@debbugs.gnu.org> To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 14 01:04:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3RS1-000AKw-Nt for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Jul 2021 01:04:29 +0200 Original-Received: from localhost ([::1]:43848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3RS0-0005mH-PQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Jul 2021 19:04:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3RPd-0001Qq-UD for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 19:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3RPd-0000rm-Lp for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 19:02:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3RPd-00086s-KE for bug-gnu-emacs@gnu.org; Tue, 13 Jul 2021 19:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jul 2021 23:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 49534-submit@debbugs.gnu.org id=B49534.162621726431097 (code B ref 49534); Tue, 13 Jul 2021 23:02:01 +0000 Original-Received: (at 49534) by debbugs.gnu.org; 13 Jul 2021 23:01:04 +0000 Original-Received: from localhost ([127.0.0.1]:42375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3ROi-00085U-8g for submit@debbugs.gnu.org; Tue, 13 Jul 2021 19:01:04 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:49132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3ROd-00084X-Mg for 49534@debbugs.gnu.org; Tue, 13 Jul 2021 19:01:02 -0400 Original-Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16DMvTtQ014979; Tue, 13 Jul 2021 23:00:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=igYjTg145PEcUUgpBTvxOPn0sNB6JM1wazWnNmnUV/U=; b=qVQuYKSNOikIgdnX+C3z0n199o51MijCJTIk9zUhp7Q7EDoYlX0R7rLtQqb/ioL3sZVQ b7Pmji/e1U8bTZ0SIoQ3web+0xpOiILojig1uSRRAVzeqdHMWfYgip/DjYRqaUOiBFcV QX7cf4xpIBw9DAfSI+48o3CF0fG9YT6P6QjI6p7mbTiohb8I74XSdBwoj1Fv9C2MbAev dI0+7aVHdbvE2Gr3bP7Nfmd/F5gtdUm+xthCwoh50mR9bj70DGnt9F78Nzy3jS4hZ3Jt hFpfPJnxBV4XP9bm+A9y8nQJ+r6zQw7aAS0CvKtit0zALW6YvHgtNVdUfoXZi+JMX/Yd Vw== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 39rnxdkpd1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Jul 2021 23:00:58 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16DN0it7176344; Tue, 13 Jul 2021 23:00:58 GMT Original-Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2171.outbound.protection.outlook.com [104.47.55.171]) by aserp3020.oracle.com with ESMTP id 39q3cd2nax-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Jul 2021 23:00:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PcN8/wsGe4KKwma1rlh8cwZk1r1e1pndUREFNd+Ni05qTUOokyrIFn3UemvJKvNlSCzv3/81LmZwg4aio/upD1xXl7xvQBsEV8LUEzmUgK8k+uXKUFy8D6DgKrUjvkvQIhZSJVAQpVazNhSWmsXnTb4XzCswsxxI3njt+SsYFaExgSOfY+xj//WKoKVsp/WNlvaal4HbGHk+YludvUh2iwegv8MtjwiJ0nfVvJbnCW6j+VDJDGUqUPGwCGtFZWfMFeaordGp6YI6MrG8SlyvaExN75luQB6BpiTa0cglUAMKQGuLv2v3P+sgQvo7ExBOrukjsxYkKlpd8CxbM0aKig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=igYjTg145PEcUUgpBTvxOPn0sNB6JM1wazWnNmnUV/U=; b=OMu9MRE2nKXb9toffoBQ6zfoBXDQuvUwTckNZmD+TNnkppjp5xNgmiC84idTvjqdtRSgpbGWI0E6Ac+ILSTe6XPuM0/cZpffg/Atmjo0eg2obWCuF+YxLsykNJ9A/PBqP/wpz6lLLjUl6rUwyqbuovi8X7YVNtRJKoplTenfoYUCRl3iPU0C/S3guppEo7MMBP7l4uosaVXKREir1yeX6XN/wLtaYhz5larqHg3FwwwraI3cEWEEAutLKfrrLSmsWhanA217qkysUl9q2mK1V8EKg+HHs58CiOb7z8zPMT5XYqd5IQRlLofmB4x2W+jrwF6STdb3oaDwNlHdsrQWxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=igYjTg145PEcUUgpBTvxOPn0sNB6JM1wazWnNmnUV/U=; b=d03daKf3+sXHfigDD7AreOPTDZFFhwucPKgFMek+ucRu1usBaMognFx10S69Ml/q8iass5AjU5BUM31qJVA1OobrQPQmSesfSa3db7lhiQ18X6dR4eGwMev49LOUB+MvD3I9CSyILqkei7+N/5eanqJyjTlMLjgN+LjkY/U/5BM= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BYAPR10MB3272.namprd10.prod.outlook.com (2603:10b6:a03:157::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Tue, 13 Jul 2021 23:00:55 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::1d3c:d31b:8add:1958]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::1d3c:d31b:8add:1958%5]) with mapi id 15.20.4308.027; Tue, 13 Jul 2021 23:00:55 +0000 Thread-Topic: [External] : bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Thread-Index: Add3KtHOVbhX4iMwQf2riJuDn1/IigBDCdxjAAC91CA= In-Reply-To: <87pmvl3kz7.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US authentication-results: linkov.net; dkim=none (message not signed) header.d=none;linkov.net; dmarc=none action=none header.from=oracle.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee2acba9-01c3-46b1-c197-08d946521214 x-ms-traffictypediagnostic: BYAPR10MB3272: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TSX7imhCBbQDpyBG1FKctNrj/QnW5Sg2VkVUNrAZAAxJYtudnNenicS0mCaP38G3YKHlgh5OwR+jYetZhQ27o+5H/KCZqzOhlpJJ1dAfZ3/c1fmfGt94S2S+SZ8nDAJ8OzhpiDafp8wfkVuBUrMFOyeBPCfUt/RWcpCXZh/znRUDFPSs5wHb4zYqvCTmxV8eRxGvNSK9JzbJ1rfA8d5MWwbBtMQeLFkL7RQJcd/raG/xVoHObubusHV74TN4PGQIe9EkthaRPTvqh/ZJm2Tw5NEPu8QraOC2Wh0n5WFYEcYXNphWjYa4e1kJpKvo0S+tS/v82xGjmZePbfaDwBkD2ddsolVDw8a5J1dcaYq/6bf9QmL6B45j56xi351hLdZuDv+unhhTeWhbZK0i0W4bk6isjw+8bPNQpN7g2OKXVHMv/wZ/rJd+NRnDl00VOC8TYlBvhYfaN4QE8lCGiJpEVCElM6V4Ek9w+Zw2LrKq3vb1+99Ta05JIJjPG/H1Uvzw20VMGbrb0h613NcvKmcPfAQeN3UZjiTw9b+7AcgV+9CTbcGCo7XtUL/ql74gVzMEs+2FgSzdINjz/81g8xsFzS11Qos6FZYG999E3p/IIwE7BKEBQIYEgPrMefYn9ERig5jUoGfMUSZJ+UAf7TMqYRMlfhiojQeldE+MOEPc+fOtdKNgWjgTqquICLoVGaizrwqgi7AE1N2y+MILcuStJrrQeWVvT7SYD6p5rA0u4aaeYRb5j9uwL+sXDsBpg ThhfjvQgMa6JwMaZIUuJdnkm5nQktQiovUQ2LRwAyNghGk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(376002)(346002)(366004)(136003)(39860400002)(2906002)(7696005)(55016002)(5660300002)(66946007)(76116006)(66556008)(38100700002)(66446008)(64756008)(66476007)(122000001)(44832011)(9686003)(316002)(52536014)(71200400001)(478600001)(26005)(6506007)(8676002)(966005)(86362001)(4326008)(186003)(54906003)(33656002)(6916009)(8936002)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: smVrTJspCXkXABTaSK65l6DH5zJwmNHomn7/GMfHzK3CqNr2DMF+BHY57qrZn1F7Pth16tgl+Lze+R2ddcZgokiAZBAan6gxl73zDQ/BVKfFQo/gJhA97haxjAuwrmkKUz2YTv5o9oW8+0Qjk0iP7wug50FV0/vH/S9PUYBm0XTC/Yxbc5y+Bwq2eH2xkO7WTne18Bz7o2Sigv8SpPuMPFW3730UbWVyWNC0MOB+lPBnO7RuOmhozYoU2RkGXNbxMwtOXdODMvyMepYxEkr2ZP5d9DhlYdU2G6svZ37XfpO0qDBMp+wckuC0lXFlF0y6TBsJhAmnJ9jNYjbk5a6x3ZUw0CMNJZiKoVbpVRueyofjQINJxsnk8b+xyvrDA8ZDDd+7J0fFxKd00mSHaT55rLLSeHPvI+mO8CROCw5AoFDPN+r/rhEAMaIBqZvZNTZCeZv386SqIf0Fh/tzQUYMzc7zVMo73nLHXZfTRYuTBAyWDPv8ki8ypWMHfwMEy2mpbCw3EnXkD8C9mfc4ypGNPxYoE7IgHZBq6jOq765a9LE1uRKg1JEtAkmAIG7R7hxEfezaDt8o1DoH4/DS2RCXUKVZeKt4TesQW8Zh2mKVy3PXfB4C6CVTjGJpyuQi/mMkOnzawfacifznDFPGMjwPV32ETSf69M8gNIcYb1sISETYBhpMHjbBKaVd/O7/ZBkWS2ILk4THCivNVqV5xZfmp9METaPp2gYF8WpAxaqKdh8ykweehI4NpkKe88 wSj7IRKYwR5/8WZF2uyLkPKlOASI8rQrOxxQ75jIrGu2EIHEnzFSxRcIwUNYEDcC3UhIvyOoF5y8MCynXSX9UtjjzDhOzvp/MV x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee2acba9-01c3-46b1-c197-08d946521214 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 23:00:55.2745 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ldvudr5p45puXLs2OAPLZM3g/U9gkU0yG2vnTfv9wjiZi5Lww3Zfx+h75yn/blcoU30cGOsIV0zU22TqxaPBJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3272 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10044 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107130140 X-Proofpoint-GUID: i20wfmlGI8ZqHpnKIqXzPGnL8gqQb0uu X-Proofpoint-ORIG-GUID: i20wfmlGI8ZqHpnKIqXzPGnL8gqQb0uu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209900 Archived-At: > > [On the other hand, a filter predicate can really > > do more than just act as a predicate (it can > > perform useful side effects). There could > > presumably be reasons we'd want to let it change > > the match data. > > > > No, I don't have any concrete use case in mind; > > and yes, without some other changes, that could > > mess up code that follows using the predicate. > > I just wonder about further restricting the > > predicate. The point of this bug fix was to > > _remove_ an unnecessary restriction, but now > > we're adding another restriction. ;-)] >=20 > If you want to mess with the match data, > you can use own isearch-search-fun-function. No, that doesn't speak to whether a filter predicate should be able to do that. The question is not about how to accomplish this or that; it's about what a filter predicate should be able to do, as part of its intended effect. I'm OK with not letting it use changing match data as a side effect. But in general I'm in favor of it being free to perform arbitrary actions (whether or not it also acts effectively as a filter). ___ See "A Filter Predicate Can Perform Side Effects": https://www.emacswiki.org/emacs/DynamicIsearchFiltering#AFilterPredicateCan= PerformSideEffects