unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 52334@debbugs.gnu.org
Subject: bug#52334: 26.3; Doc string of `process-file'
Date: Mon, 6 Dec 2021 18:57:52 +0000	[thread overview]
Message-ID: <SJ0PR10MB5488718A8A538780755531D4F36D9@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)

1. The doc string includes this:

 File names in INFILE and BUFFER are handled normally, but file
 names in ARGS should be relative to `default-directory'...

This doesn't at all specify what args INFILE and BUFFER are.  What does
"handled normally" mean?  Presumably it means that such file names are
something from relative file names.  That something isn't called out.

But more importantly, what are INFILE and BUFFER, besides the hint that
they can (but need not?) contain some (absolute?) file names?

The mention of `call-process' might lead a reader to hope for a
description of INFILE and BUFFER there, and then hope that the same
applies to `process-file'.  There's an INFILE arg described there, but
no BUFFER arg.

Please consider making the doc string of `process-file' complete.
It should be standalone, or it should explicitly refer to some other doc
for descriptions of some of its args.

Maybe something like this (?):

* For INFILE, repeat what `call-process' says:

 The program's input comes from file INFILE (nil means `null-device').

* For BUFFER, adjust what `call-process' says for a buffer DESTINATION:

 Output is inserted in BUFFER (current buffer if BUFFER is `t').

2. Args DISPLAY and ARGS are also unspecified in the doc string.
___

I suggest that someone familiar with `process-file' and `call-process'
fix the former's doc string.  If it makes sense for it to refer to the
doc string of `call-process', fine, but please do that explicitly and
clearly.

Someone with little knowledge should be able to grok what this
function's args are about - what they can be and how they're handled.


In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
 of 2019-08-29
Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
Windowing system distributor `Microsoft Corp.', version 10.0.19042
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''






                 reply	other threads:[~2021-12-06 18:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB5488718A8A538780755531D4F36D9@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=52334@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).