From: Drew Adams <drew.adams@oracle.com>
To: Devon Sean McCullough <Emacs-Hacker2020@jovi.net>,
"49734@debbugs.gnu.org" <49734@debbugs.gnu.org>
Subject: bug#49734: [External] : bug#49734: 28.0.50; define-obsolete-variable-alias
Date: Sun, 25 Jul 2021 19:52:48 +0000 [thread overview]
Message-ID: <SJ0PR10MB548870CADB7540E005F70E53F3E79@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <66274858-91ee-81fb-b157-d40c0fc0c676@jovi.net>
> This change breaks existing libraries.
> Better to deprecate old forms for a few years
> rather than gratuitously and prematurely sow chaos.
>
> P.S. Please undo this incompatible change:
>
> -(defun make-obsolete-variable (obsolete-name current-name &optional when
> access-type)
> +(defun make-obsolete-variable ( obsolete-name current-name when
> + &optional access-type)
+1.
In general, moving an optional arg to mandatory
makes things harder for code that tries to support
multiple releases. And it doesn't gain Emacs much,
other than perhaps a byte-compiler warning for more
recent code that omits the now-mandatory arg.
Does this arg really need to _be_ mandatory now, or
is this just another turn of the screw to provide
additional warning support by the compiler?
next prev parent reply other threads:[~2021-07-25 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 18:11 bug#49734: 28.0.50; define-obsolete-variable-alias Devon Sean McCullough
2021-07-25 18:29 ` bug#49734: oops Devon Sean McCullough
2021-07-25 19:52 ` Drew Adams [this message]
2021-07-26 17:50 ` bug#49734: 28.0.50; define-obsolete-variable-alias Glenn Morris
2021-07-26 18:26 ` Lars Ingebrigtsen
2021-07-27 15:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-27 17:04 ` Glenn Morris
2021-07-28 15:32 ` Lars Ingebrigtsen
2022-08-21 20:46 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB548870CADB7540E005F70E53F3E79@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=49734@debbugs.gnu.org \
--cc=Emacs-Hacker2020@jovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).