From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#53153: [External] : bug#53153: package-quickstart: unusual autoload form in selectrum gives byte-compilation warning Date: Thu, 13 Jan 2022 16:20:00 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21001"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "53153@debbugs.gnu.org" <53153@debbugs.gnu.org> To: Stefan Monnier , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 13 17:21:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n82qv-0005HE-Hf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 17:21:29 +0100 Original-Received: from localhost ([::1]:47642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n82qu-0006Me-KL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 11:21:28 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n82qU-0006Ki-Cs for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 11:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41452) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n82qU-0007ss-3c for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 11:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n82qT-0000Pj-Rt for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 11:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jan 2022 16:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 53153-submit@debbugs.gnu.org id=B53153.16420908091492 (code B ref 53153); Thu, 13 Jan 2022 16:21:01 +0000 Original-Received: (at 53153) by debbugs.gnu.org; 13 Jan 2022 16:20:09 +0000 Original-Received: from localhost ([127.0.0.1]:34355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n82pc-0000Ny-UA for submit@debbugs.gnu.org; Thu, 13 Jan 2022 11:20:09 -0500 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:54984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n82pZ-0000Np-WA for 53153@debbugs.gnu.org; Thu, 13 Jan 2022 11:20:08 -0500 Original-Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20DEp6pU023541; Thu, 13 Jan 2022 16:20:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=h/APjKUGaLneURHZkXRkkcSEkTqQbtHhGXOuEj6Bu84=; b=emDdaZ9uNncWIswyH9J68EHolpUe/b5YMkTCtSe5JVIjtkicpLuE3b/QKtmkKDU8B8xC wRAwdG6dGRcJKxSj94Uv1WE50MjhVdKy7iTqCb4AAbQ9+/yS+r629Xzh6DWG3m6tbB7q 59okKxuE7OqkUOBgC4tUge4GUjfaH8V8klTP/27qFPk5s/e6utM8qC/48R4o2eJocJ7H siQjdxETdlINl6r3mWmmdllLBXpQ0KO+rqitJQoIdBq0lm/SK2qcfs8TBL3x2OCvu29T cVl5BHDJM5gC2g+luviOldY57P3394JMRYRLmY0v/20OslQhy8NJdbFxYD0e9PA+tgwG Hw== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3djjm0gqub-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Jan 2022 16:20:04 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 20DGFlNv123472; Thu, 13 Jan 2022 16:20:03 GMT Original-Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2171.outbound.protection.outlook.com [104.47.58.171]) by userp3020.oracle.com with ESMTP id 3df42rrbx5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Jan 2022 16:20:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E+ASiRte2EBhFp99J9+vpk/po6t09Bo9Q/ZpzUGhdx6VttdM2loLuldTr6g6SuWd7ijnCFdpiAwtjJWJb6iLTJ7AI6iB69FKLInImrME1vKgN8oE2FbCCJgSNuBuvGF7nsnyMl+mdwbKkm+bEUP5TltcfBDnGrNfTI0yKcHENkUNn21BR1i33at+KzRNCIBSuXaiAD2hP/WPgVaC34FS8/NfUn81y9XrkzUp+H0oWKPCJ3r+0eZB7fFp889uU5QVMgmMHtk7Niw/4CSP6r6vCQ6cISDIf7Q/3aaq69Pa8zgiKBMzE8OGvA3OU0F64+RxV3nZyueY5mMQuqO2il0GSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h/APjKUGaLneURHZkXRkkcSEkTqQbtHhGXOuEj6Bu84=; b=CI83zZGy5XE7DqCaOEAs0GGjh9zgeqVZz6SM53+XVH6XGsZ8bKZnm1KeCEGHBQXGtePF+SrN17Q4TeWOAlUSx1KLFLE+UxSpgFIFS81EzMQsTe6+mlfOzvzuKaCtJyLpvv5t4xXmeC6ZUhmL1kiuU0zSqQDIsu8m7iF1xmyIrsimBztPC4n9Ae8qRsrOQKYajdumkUoWVyO4/UGC98Z1g8qbD/Vl6IsupBIAOxC24mqg1YHhsWiXkJF2CYt346gIrZTWnK+elhxNRhJKAOboEhC8WgM0NkyL3zciFUAD0rSBU7Z2of3HoZkUrw0BcDRSlfFqndJSVCKfU7dKYNGj6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h/APjKUGaLneURHZkXRkkcSEkTqQbtHhGXOuEj6Bu84=; b=LKi1p6a+BrGQPWLZC5a+3JZIcL/bzuPpguFrlC2A+XkDkFXf2Kh2XGmUKqSieJmSMMkQDALtuKJ5vF+xrTmtFjt7i3zAvwqYtmb5CXHr68du7oUXy2ztXHZni9Hc/qz0tWZF9FVMMNFJfSl/a/7RY/II5/madQ+3a9o/M0h5QQ0= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by PH7PR10MB5746.namprd10.prod.outlook.com (2603:10b6:510:126::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 16:20:01 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%7]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 16:20:00 +0000 Thread-Topic: [External] : bug#53153: package-quickstart: unusual autoload form in selectrum gives byte-compilation warning Thread-Index: AQHYCIybW0DpdjVqzUqhZwZeDOobC6xhHFqQ In-Reply-To: Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a0b4110b-65b4-4c4f-ece1-08d9d6b08c63 x-ms-traffictypediagnostic: PH7PR10MB5746:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8ufzkbROs6lLz9ooUY3TDaIO5M8MBqUccjOjlfKGPU+KxNLZYn/AzLZGpVEB8i9JF3VZwgyUY2b1dHSx/YaN3D61EEWga+dUaSu/3jW9F9EafR33OIzOFpIiTYtTQesFPue29bxLt0C4JqbXnkjRQ1r/rUE6IYqTy9p6P70VxdOeUCvvkmFwGkf9vXYKYlCNbLytJl8ht1KYOTR5V9kOh//QsMR9QuSVANr5gDKg9xqe3Gr9PaqnrXoVuSa9eh27xOCaE6cTWKfxM5k2zui2w66U7UgszY8OMi5G7DbLDFJ4LjAlOU2BGpdN+tlUW0+9BiggzNXQ1UkSg3qXgrBHB07qmmBe66gWzpN6gjiASQhUChHm8JcrJnlOivfvoKSA7b3cfS/H4p+zTFmyvHXbpF/z80cLLtvUjbrV/41SfqzDZG3/rjNNi7a5Gmbom8vdhhW5g1manGo74mJZtrSwRnMxQ+pG/sUexBEgRTfMEJEp58Wg1Loht5jpL5pJAmqYODVFrSAH0iIgsmR1FYWNCp2wlTvnV8uCcSLEA2N0A44ulfr5jbHczQZX/e5AtNUaS+BH/0YHw3KWomiTV0fYZUqpUF4tQDRFEPLQn+ewXsSGTTa9w85OL7oYOEv+PLwK6nqaX+hQ/8BDUILlo/GAu1rjAG27HYIX8ODKP2sNfMFG0uMDSZgEsXd8CMo74pT5MfK417MS1RE6U3YPqL8e3g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6506007)(38100700002)(508600001)(186003)(86362001)(9686003)(38070700005)(26005)(83380400001)(4326008)(55016003)(66476007)(296002)(7696005)(316002)(52536014)(44832011)(2906002)(8936002)(33656002)(122000001)(8676002)(110136005)(66556008)(64756008)(5660300002)(66446008)(71200400001)(66946007)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: eRlpQOItz4YPeVwjaddxtJ3jS2YQtOHhzKPWMZERJ8DiZUwv7vnnTVOlsn8ZWDeTwIRQ6WPMv0B69tJhDsV8BYcot4sRORTMuO1YA3it0ynfXdzjyd8xXgNrqVMdvvmLIPJAREei35TZUDjk8RHbN1Ii7wSp4ZOjWAK16yggIflAzg9iJxUC/pOIuotJDu2f3mlVaiCLSFDIUnSpWMX9+2XqpB+Yn17KnHDxu+wlIgf0XjojW5E9gaEkF8HU0C0xqpSqE3rxBfQHdtec2SCznibxQ9pVQePywNEx6KfTZ76qMkXP4GbVdd6wu/vxNDsbF1gAHT6MIxjyDeJsXVAFLsbnYbRiRXCKbjNcN9lLOpIED4O6FA/v4dl9xII/0/pKscdQz5PwigmLFnp+BPevE6QvlKzBY73NpZMhdB2ZQTLK1gWM++FzcmlVG4+SpR0o/9/NgqjHhinbLmD8iJru1k2hlNqhGZ/1+dM3nOeko34n67V17Nx6fWK/kIt3QCZnpnN+vs+upOiPhrXe9I2y1Fc0WRiLwmS2gd8RFUogtOqzUy7cFvzOxICJRppuSrFslhQhzE0Csbz5WubzTbCApv734Zwoo58wLY+7qUx0pzG8wCEGaRYOg43df7qYyVq7cfBiCn9qhQnCWCZyeP8To38CssjpAVb8GOSahT+MVYTFyX2Uy+kOOIwX/KvAbkJhSZ8f9hNbwdbFEoIemylHao37JteVBWk620a/3Js/wCCujK03qUNcv3ja7F aNwGO13I5zYr6smIgo5Uyzz4plqbBnY4ILqNBEnlpqMfWnXZHSsnlpejHDHGpLc0ylDx9m8dBVdpfOZXqMw5A3W53Pe6comZHT X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0b4110b-65b4-4c4f-ece1-08d9d6b08c63 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 16:20:00.6958 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w5o5aytFHFGo1X83UpY2E3DH4tnh03eJ9c95LTcQ82D+vm8P9ZjZ55TrOdq7W+6nNNNGN0MQfqI83QOsp29WfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5746 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10226 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=772 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201130101 X-Proofpoint-GUID: sHK8wXJ-xobCaUZjcguUDCCyASa95kGI X-Proofpoint-ORIG-GUID: sHK8wXJ-xobCaUZjcguUDCCyASa95kGI X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224121 Archived-At: > Global minor modes define a `defcustom` and its > :group is usually provided by default by the last=20 > `defgroup` but if you copy this `define-minor-mode` > to some other file (such as an autoloads file), > then you can't rely on this defaulting so you > should provide a `:group` explicitly. FWIW - IMO, it's misguided to recommend that people not use :group explicitly when they can get away with depending on the preceding :group being for the same group. That's a sort of "premature visual optimization" that provides no real advantage and presents the disadvantages of (1) being less clear (at the limit, it requires readers of the code to search backward) and (2) gotchas such as the one you described. People no doubt have different feelings about such things, which is fine - it's partly an individual style choice. I disagree with recommending one or the other as a general guideline. But if one of them is to be used as a guideline it should be to specify :group explicitly, even when it might not be strictly necessary. Clear for all. And what's the purported advantage of omitting :group when it's not needed? Presumably it's (1) less clutter/noise and perhaps (2) easier to notice when the "current" :group changes. #1 is very minor, at best. :group labels are not verbose. #2 can be misleading. If a reader of the code tries to depend on each :group being significant (i.e., it can't be omitted), that assumption will bite, sooner or later. (Just one opinion.)