From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#64656: 29.0.91; Doc of minibuffer histories and completing-read - automatic addition of completions to DEFAULT list Date: Mon, 13 Nov 2023 18:14:15 +0000 Message-ID: References: <83y1jga0nr.fsf@gnu.org> <83o7kb9a40.fsf@gnu.org> <86bkg84de3.fsf@mail.linkov.net> <86jzrhlrub.fsf_-_@mail.linkov.net> <86h6m9v1sx.fsf@mail.linkov.net> <861qdc1s3s.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40484"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , "64656@debbugs.gnu.org" <64656@debbugs.gnu.org> To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 13 19:16:00 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2bTc-000ALd-2X for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Nov 2023 19:16:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2bT7-0004cW-3T; Mon, 13 Nov 2023 13:15:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2bT0-0004bm-2x for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 13:15:22 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2bSz-00005O-LP for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 13:15:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2bTe-0007Gb-VL for bug-gnu-emacs@gnu.org; Mon, 13 Nov 2023 13:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Nov 2023 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64656 X-GNU-PR-Package: emacs Original-Received: via spool by 64656-submit@debbugs.gnu.org id=B64656.169989930627853 (code B ref 64656); Mon, 13 Nov 2023 18:16:02 +0000 Original-Received: (at 64656) by debbugs.gnu.org; 13 Nov 2023 18:15:06 +0000 Original-Received: from localhost ([127.0.0.1]:59313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2bSk-0007FA-0Q for submit@debbugs.gnu.org; Mon, 13 Nov 2023 13:15:06 -0500 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:37118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2bSe-0007EI-S6 for 64656@debbugs.gnu.org; Mon, 13 Nov 2023 13:15:01 -0500 Original-Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ADHi7BT014664; Mon, 13 Nov 2023 18:14:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=H8nJzW7R+THjbSqBoHBBY5LzNi+GRKKVSQqr+rUi2rE=; b=S3+0URrPPnqhy2I5YZxzODK0vHvDCsccN0T4Qwub994JSL9ow7fza3/WLMMHMbhuL4r5 7eo/y2lJtrTq0WP+vMY57WnxOx8dMEfIbt4n3XWxBTXZmRXj506S4hzk0fTFHKjz1fSu 5nq4QjL3ToJSgfGXYCfuJcR82bEOnf11ZRO36vM/E/YKeZ5Ef6MqkDKhdhV47EQVbV57 /OxlRznI8QWjknrZbAnwv+FBOvr77n3GXzNSYWMY8hKEuqO9USGHNJj/80iIAe4V4xOG NNBDV6s2KsjAWPctyE4IaVjkLzYgPkEZaPjuxrzuJGMOrrMajInapFqjtQsM83OfjMy2 6w== Original-Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ua2qjkfex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Nov 2023 18:14:18 +0000 Original-Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3ADHQki2015018; Mon, 13 Nov 2023 18:14:17 GMT Original-Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3uaxput2n0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Nov 2023 18:14:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cenipkT6q/KLMhi2DPJHKszYZPQ+y0/0XsbMyvHw1pCkONL3NMfxbPJ2dwxhVV8Q3Z7xGFrTGAfuhfilzZo2XRicdSSmwHEN/kvlxsUQxaTsuZDDWHe9Cwq7kCO7XUAYq/juoiD20bRZ0+qsGaHeo2b5obbT4jdhjsVPb6ep40Aus7KmTd/GVvVddxE+K9aY1UICNAVS9RtcQ2JE3AKXs3WCE/TxWIDU8na5hCrKh2sZN8tIXjNvunQjWoITlpRE6FpVt4PMOQEceIz29bNuO0uEkfGJ3Bf/nbuCCwLg7XjDec8eYZ7r2Z2a28Jb8VafIXtUkS45niTcuAVHPty8Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H8nJzW7R+THjbSqBoHBBY5LzNi+GRKKVSQqr+rUi2rE=; b=jMVuu1n3tdY8kdBBOySotKPicZ4k/do6lXeQrcOt/5F1QP9XbXhuQKnDomZYW62snIfWlZSG/YnN5iHNd1aDtiokgJeoI2pyrYlo/AngaqvnZwUgOP3uh6HDR7KEdNasW7oME+qhaNjFdJ69nQcw4jhVKCywCTR6lOi35drzhl7ViUuJc4Qk1ImZSkYf7RUNPA1U3oK3lI2/xra95NL78N0YmEA+Lvc6YhTRtX4efPAQm4eKltG9z3r7r3Qj+F/BqDJxtuFMf8RvXDYqz9H2WySUUnqXNo+JXAgoknkdtfCRgP2A5veiZRK2lkwWWKJKQLiM17fM8ORb0Zgo7dTRjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H8nJzW7R+THjbSqBoHBBY5LzNi+GRKKVSQqr+rUi2rE=; b=ulkPr+n8lli/FTFHwtp158gTfMVgOPGn+oRMjyJuxBvPeHhPP3dg7tUPEAtikrL+VR54Jpo/9hTAz6X6JtPGxPA9hKKElBDsBf6s+3q3OxJQ/YL+S7oa/l3Wh7e+ma9T25ZrvCNOVNV6KimLSu9oIU3JQRpLNoD78hosAcJys/k= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BY5PR10MB4372.namprd10.prod.outlook.com (2603:10b6:a03:207::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31; Mon, 13 Nov 2023 18:14:15 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::3b4c:a669:c229:47b4]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::3b4c:a669:c229:47b4%6]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 18:14:15 +0000 Thread-Topic: [External] : Re: bug#64656: 29.0.91; Doc of minibuffer histories and completing-read - automatic addition of completions to DEFAULT list Thread-Index: AQHaCwhzlYmAvSsXL0ium0OZYugthbB4meSg In-Reply-To: <861qdc1s3s.fsf@mail.linkov.net> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|BY5PR10MB4372:EE_ x-ms-office365-filtering-correlation-id: 21b3963b-06a8-4236-b06d-08dbe4745865 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9qizwLsmFeSUKWeX3XEsf65fIKdgER6hc+ARU4KdO7KK0/A94vaiN/BHG5+w8xmuMxV8ZnuA+tVWa6mP7p7e5Zl00GzyOdo0dX06IsWRKh0HMwFkryaJzZ6K4Q4FSE9wzgzS2SnPA+vn1bfgbXXig6y9monb/ALepfslMO+wSwGBxqxsngxHsX8nSEzAZQxHL0Fgf5oE6qMESxd0wzdryR0+/mW9iTxlJUNNa6hXpxXmNCC0a0IxLrFmYMvtTK76QiCeBkcZKa+qwJ9LoDfWxEdEHDpRt1GWUb9coC+hQtPES/N8UqTiA/+fY1c34ABOW0+1PXR6UavOS/oyOxH8yHOaedTLsxX/IlDz+R5s2itL+kyK+FnS5sOgeof38Efmdn/45X3IDgGLkieuK3z4xSPTZ90n8uNteXeteiKFti1eUg6g8LEjIWzWEKzTRfmnFV5WKukxvqR3erS/HDJ+GOGqrEsM1a/Axic2qxkszsKjXi0mTYBcBvr6SqBXeOnwUtITiMfDiwpjaYj0W/LTjtrbiKFlEWUZjTxWUaD9o6iVBoSLdtwEiKBQA1VnpOl9xqvYpQWSF8mOn9oX5YrB0yHdehBqqD8c2FsDZ8l9Q6X9uoZS9gZHuatQROh2ChSs x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(396003)(346002)(39860400002)(136003)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(66899024)(38070700009)(2906002)(44832011)(52536014)(71200400001)(5660300002)(86362001)(41300700001)(33656002)(26005)(66556008)(54906003)(9686003)(55016003)(66946007)(76116006)(6916009)(66476007)(316002)(66446008)(38100700002)(83380400001)(64756008)(478600001)(122000001)(7696005)(6506007)(8676002)(4326008)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: U1OH4HG40UFTFXMGDqzdO3xp7IDAsacYyjqqGcVFJHUmqTMCI9w0NS9Llifat/4zNMkDCegu3ahmAEYHPD7h9dr6G0cpPZNxgL8hN0mkHC1bm3qKT93H9WEplNPtO3VJ99kzCM0rssMDpjqNL+LeCVUPB/nFHmZiHsV14jv1lHiDXmEp2RVni2r2GsBM6KQATjW83iLkmtvVSzzX928+NqNhtUn4zlMLVz9M1AJ5e1L4E7VSuxTfSApHkG9a7ih8o0vLdQ09ejkutcGHdvk9eKAPzdLgJRABcd/RUClaCX2jTxNIOpvU9LjKF5oL7rv56688AA2mgZOqXuwtd3FBmTg2XYP/t4r9SinR/LuFkBtaZhs9uI/ldDMYFv3mNSsXNSCobaJcrOAe2HTF3b2ir+A6l46CKkT862XOdB/c6r7yK4beZWO1voCPVJBy93/yN7itI+yef5p6pCoCNVYT1a39zqG40eS2ZE3eldADDGH35ULPwPwRhZ6tpVg2oTTFfm/8PFAyi+Tfp8YnUklxoops0CuXMmAn2Oxzk5LDmP9/QrqI6oTMvmhuHvXCm3DXRCLzA5lwBO62V9Lp5BpOH95OtUHy/6w7Wd0DDZyxPwS3cB+RMOaPQTLP5ZGU1zl7UUg17FYb6JwNjMHhpjVE39bzK8VJAJcsTYN5q4cykgBW4ZTTY8GzPQLRkBap4Fvljztpi+QsMpnKtfkfchIxL4R+hQgcdio1am2TvRACgpI9klrEqr28M7T4/w +0eaTuK0IIfZypvgY6G+cvLcQhB5nFCbmWpFdOqyznmA8oKwp0QO2vewZYGeGoBLCxGwW/SnRF0l7u+xkwhOkvFF16K6QKmXYZ X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: wJiWbAwGfaAxpPkpcGGotn6WNpFcx1SacPDEdPA1VhyFm/QKr0awHddMcqdWEvYpbdL2reO3sqiec7Z8EDnOI+taT+/JT0F/fVKbchw5VRQTAFwKyR5rJ7HCc8qATubPMcjPlkMzdy45A+6/jDNDFMCjgueO3kJNoedFrJi+PsjbPhSG52E81RCATo+ag+DNW7VPYN/d0Ncgdr4CLNn7Ng1MW1j5uu+0BfrGKLADWwq/QcAKA4oqmZYqnLCoPtjBv+b6ZVBMxN7Xy+m+2u6c4ScrADy0KNhJL3WhYln2aLiL0TFXXbOeiU7AMc5OUw1EvFS/8AM+y7WxLWfyL5HlgN90lNNkCZYmhztiJb10E9nzjSpvRFlOiZP2tr2zJJh7XQkev1Cxf1P1Akebw02ESf1DH7dcovdsPNBCUjuE0tsqRM3gPpew7oW+Ed7RjsSOA5f+3bIr5VSTg7DKBdB8XC/6PZJPNVn5S5w5n1ReOxgOzW/QfCYhArwOqiRq8uD6+10liBUeyKv9CLvGihT8WLbR+RWGRv/LMotmRzoAzvm4eA1Zz47ipPvx8SkcbADakpyGPfdd0KAiyIUciNxUpC031314RP2gEAxcF7SObBpGRUpfFS37DtvUklHZMtDp0HW0u7EVkSIN4vF+sGFTbebrwadGoaCv2hzTRvQ81SiPWs1YKPJatXHCrdN6ZB4cqahODkWidj1UR7abwM+X0vvd2hosUJTpsaR+F+fa5BzZPM M1gdapSMEJg6wdqI5b0fqoouHjLN60hWyUfDhmWl6BiZhbx1nsAy1sr5MzSLn3KB4cMLoS9V9V/Qjcie9l X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21b3963b-06a8-4236-b06d-08dbe4745865 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 18:14:15.2862 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kWjZkxBAxiQLBvKjf93rGban73fv3n0VDUTcTxo8OlQkVktGRnFdYFAlYgUOHxANPGCqOzoWUCRvGPOQbkofwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4372 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-13_09,2023-11-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 suspectscore=0 mlxlogscore=538 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311130150 X-Proofpoint-GUID: gX6j424AOLoNk1R-IPbh2bVOpoh8BM3f X-Proofpoint-ORIG-GUID: gX6j424AOLoNk1R-IPbh2bVOpoh8BM3f X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274281 Archived-At: > > But it's easy to restore it with a simple patch that prepends the > > current default value (a command at point) to the sorted list of > > all available command names: > > > > And even that doesn't seem to have much, if > > anything, to do with adding all of the initial > > completions to the `M-n' queue. > > So I really don't follow you, here. >=20 > All available command names mentioned above > are extracted from initial completions. And? That's the problem. The completion domain ("initial completions") shouldn't be added to the `M-n' queue. At least not by default, and IMHO, never automatically. Any programmer is free to add anything at all to the `M-n' queue, including all of the initial completions, simply by adding it to DEFAULTS. That's what DEFAULTS is for: to add to the `M-n' queue. > > To be very clear, I'm opposed to the misfeature > > of automatically jamming the initial completions > > onto the `M-n' queue. We have arg DEFAULTS for > > that. Callers of `completing-read' etc. can > > provide exactly the list of DEFAULTS they want > > to prepend to the `M-n' queue. >=20 > Indeed, ideally callers of `completing-read' should > provide the exact list of defaults. Why only "ideally"? Anyone is always free to add whatever they want `M-n' using DEFAULTS in their call to `completing-read'. > The problem > is that it's too late to identify the existing callers > and to add an explicit list of defaults to them. _Programmers_ can define DEFAULTS as they like. No one needs to, or should, try to add anything automatically to the `M-n' queue, overriding what a programmer has explicitly decided should be there using DEFAULTS. Or perhaps you mean existing `completing-read' calls in the vanilla Emacs code, not user code? If so, I'd say don't worry about it. Don't second-guess what the `M-n' queue should be for existing `completing-read' calls. Or if you really want to, go ahead, investigate them one by one. Each call to `completing-read' deserves its own=20 consideration wrt DEFAULTS (the `M-n' queue). Nothing should ever automatically trounce what a programmer has explicitly decided should be in the `M-n' queue (with DEFAULTS). > > Don't remove programmer (and user) control by > > smothering `M-n' with the completion candidates. >=20 > This doesn't remove programmer (and user) control > because it's still easy to add own default values > to `M-n' and to remove initial completions from `M-n'. It's not so easy to remove initial completions. At a minimum, how to do that needs to be added to the doc (this bug report). But as Eli said, it's more important to fix the bug of their automatic addition than to document a workaround.