From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#46973: [External] : Re: bug#46973: 26.3; (elisp) `Face Remapping' Date: Wed, 23 Feb 2022 15:56:21 +0000 Message-ID: References: <87v8x594yr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28867"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "46973@debbugs.gnu.org" <46973@debbugs.gnu.org> To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 23 16:57:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMu1A-0007KG-2y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Feb 2022 16:57:28 +0100 Original-Received: from localhost ([::1]:53680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMu18-0006UV-6P for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Feb 2022 10:57:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMu0k-00065J-Qb for bug-gnu-emacs@gnu.org; Wed, 23 Feb 2022 10:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52135) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMu0k-000310-Gw for bug-gnu-emacs@gnu.org; Wed, 23 Feb 2022 10:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMu0k-0002DT-GK for bug-gnu-emacs@gnu.org; Wed, 23 Feb 2022 10:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Feb 2022 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46973 X-GNU-PR-Package: emacs Original-Received: via spool by 46973-submit@debbugs.gnu.org id=B46973.16456317958474 (code B ref 46973); Wed, 23 Feb 2022 15:57:02 +0000 Original-Received: (at 46973) by debbugs.gnu.org; 23 Feb 2022 15:56:35 +0000 Original-Received: from localhost ([127.0.0.1]:46029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMu0J-0002Cc-GX for submit@debbugs.gnu.org; Wed, 23 Feb 2022 10:56:35 -0500 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:61474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMu0G-0002CT-RF for 46973@debbugs.gnu.org; Wed, 23 Feb 2022 10:56:34 -0500 Original-Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21NFGTUg026299; Wed, 23 Feb 2022 15:56:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=V5W1iZXNbN6fRo/r9KX9IEbBTycjPuUcT/UoJWn8foo=; b=paZTXoHCrqiJTlCx9muV6psOfHLlQTKZPW4/V3MHgt85Qw1HfFC9i+sgjMwzugb/uJAd GmEaWKc85vkNJnRygAF8qHiMB1sS+VxmDscnAwMbj95ptdtRXRozS8GAe4RjGsUdjPrW TbdSgwWNmoiOkSLJf6hu+UKmEMZmfWV6LhAp8ta+WLcH5KdDuheyBfRwXvfOCtYW+RiE aJFkTjnNkW1HhndK35stX8Ey9bApjAvMlfikGryzjowPMLjupz/W6JYqHs9Yk6xwNExC Yanmn93oj4vH9bpyrXYb7wO8KD1iOj3z23zZlcjYv9aWUqj8n1+lplCGxZCUwjeubFcP /w== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3ecv6evf0m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Feb 2022 15:56:31 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 21NFuVQN157314; Wed, 23 Feb 2022 15:56:31 GMT Original-Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam07lp2047.outbound.protection.outlook.com [104.47.51.47]) by aserp3020.oracle.com with ESMTP id 3eb482nqwf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Feb 2022 15:56:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gJ3mLsNI8rDJGoPtitSMlG1Kfle+mmsd0JdY5/f0i6/eC+76NlfF/czvTsMKcbZQhp9KcJ3ff1qhF5ZqpUaKjoD3x3nkK8oTajK/pHoomsujPwSvxyggDMJ2zftXbsR76yu5wzexATsj0xWIk6+LKf2NRwWT39dYM/Sa4EeEbBOIW4HIiOJi1b0pep4jinx+SX4cK9PIh9T356iSqsub3rYFcW/SVUI3F1cH46JvR/TqOrtgjVSBN3Sq9wfpSXz69UVekzU8mkdkTPx7CWLM82QFrpYAKorExo2/Nj9jxubN6GG8ocOyIACFkldfvYe4cBxBiDbsnw1pOE3knvguiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V5W1iZXNbN6fRo/r9KX9IEbBTycjPuUcT/UoJWn8foo=; b=AY5foN+vdJ/zMdhrhNTK57WVLhwqQ910mlA2b2LEv28mSsRup2Jvqm77Iayo4BA5qphKqPv2WdQiDvhEAIsjInqcFJmNFHa7N9aDMNlAHIuME4JksSPwbEYCx+6dzAYWei2cDdLXkf1BW+nhf91o+x/g05eMpyqv09MZ/6FbbqD+BQ02ofjpR+gZ2j+oAv9EUh5KmCzuntQhzCkauEi2KSHourSWY7N5XZkZGmpTX4ZmTNbgOGqU6wpcsU+71z1l8wKJFJPANUDoffHIYIhvAYReJwDj6K3InApy460vvz/Ty4EzqfSbXS5Gb9X6otgcN1TW72uXQSVwxftx+2ziKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V5W1iZXNbN6fRo/r9KX9IEbBTycjPuUcT/UoJWn8foo=; b=svJGVQr+O3sl/nutwNUf5RWTZk6scfbIV9O/xkiKaDR/csOSm5XwEKkhqqK2J9GIcfvjSNMAat+/a6wtFP+8zY3FAoEA1UXjk6BRyUCnrr8pTWayFR6LAmfjQp9meTHSbrMoh7Wr9zRQaAsAoHb8EUgtmjt2FGJcx45U5azyPxA= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by DM6PR10MB2588.namprd10.prod.outlook.com (2603:10b6:5:ba::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.26; Wed, 23 Feb 2022 15:56:21 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::f811:66c9:41ab:df79]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::f811:66c9:41ab:df79%7]) with mapi id 15.20.5017.022; Wed, 23 Feb 2022 15:56:21 +0000 Thread-Topic: [External] : Re: bug#46973: 26.3; (elisp) `Face Remapping' Thread-Index: AdcStINTEVy4W76YRRuu4lEZ5bRTF0V9yOASAAhEw0A= In-Reply-To: <87v8x594yr.fsf@gnus.org> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b994cc65-63dd-4924-664d-08d9f6e50940 x-ms-traffictypediagnostic: DM6PR10MB2588:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qiFc973c3Kh4u6CPs7ZMzFc80P2EmkKjp91we8J4XK3RpTLpIiftja1G4uX4Uue+YF3qXmJvaa3ODWwgKGz7ftyoCjsP37IZJxJDp6oxE6vevQ6wVb3W1FYdFZuajTaGXrkG7cS4gs/eany1QkbC0jjf8SfI+7BlkuT3Bo2Pz6HGKBpCONBRO/lqdFiM+725h+IN5eCM5RTSI6cf7g113cWB2jI/iYAmUsMM/E4rmVxal8q9OSkS6F1rUKQOIiFFslA8NlW/6+/J3Fcw3wawMD3vJsMZxYE4hkSa6kM6gnv8CQMZhpaBvLi8Gzh8AqXXgvIMInqh025g8P7KWdeH5WPwX1OQ8pMK2VPLtDxreXMcojqBKH+RLCJ20RHoEL+tphR4nQM5pwJSzNdl7FeFqG39L3nH0saplmEppR0fiYMovfJAkGxGsNwGfD/MVoV9yjvwIDqJu5ob/tC5oLfdDF02N3Ta8Rx/vnHmKYqlUQojQ38RQlI8Hws2ZsbIA32CaIn25LwhT49N6aL62Rv+YnnK9tzOktRo3P4o91Xhans8Xdo3Go75RCDCuEpPmGc7/4zDOB5Xv8Lkjf0o6ePrb76rzeQovZUzWR0v8kXuEBsx8gWX4qqMOyDoQT4qAl2fg2GtX6QTpdfSrlSfI61JGJLEqrsxrijeRqHNIaJ+qDIzsOwKKnlVyqyCPT2IXZxACckPaCsGaaoWea4qwjVJLLFIR8auRjfS0TSj68SnLJ95yKXJxLvW4HZb0NuPe pc8iy2SRWGu4ZCLMEum3I2bJVogBEELVCXHSFQzra8ZnVdFrWSbVYctubBRTZHNL+7a x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38070700005)(4326008)(122000001)(26005)(64756008)(66556008)(66446008)(66946007)(76116006)(66476007)(8676002)(966005)(186003)(508600001)(9686003)(33656002)(38100700002)(71200400001)(86362001)(316002)(83380400001)(4744005)(6506007)(55016003)(8936002)(52536014)(2906002)(6916009)(44832011)(5660300002)(7696005)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: NPc0+UBlVXBMe0AHNjB3m6ZlFX/mB6abJytXYIDBtgZfqMwozmf0QVOgprEgvED+n4Thhay6g7vthiOX5VCgtikRqJcPg+ngO/ZBtxPjqpXEWtKcjUuv/7LW42ER7eHsJQ85+IURuId4hs/RM+/iyRjhZ/U8qKO0ziQzgmPmriJ+6RYPU3v4T9jo1t4RrdAVSzXhcS4q7fxkCRPceHQ7iYLOmNsx9DwIvl+4rE5i/t7g+aj4GlF/ts6acKUsyDb+yB8dtqz07uqgU55c3uKXXMDI/W1YJdsDpzHgSrFB0bFcVfb18axr68exG64vkAMXxbkwLS28SwPtONW7dc72wJ93PxNf++LAmTGXwCM0zVXqJbDdeykktOkle55mVm93WQPuthe3qAn91RlX5zh/3c+oDWePAua5AIwCa1pZN4Z+L+8+CTGhHR4Uv/jULaDTZj7538dSCIFnRaf+9VkiHHEbkIHT+W7la/Gd7EgmFJ/90e3a8YbiMyR4wgZ51UKPAUEXRZ1YghCH9aqeZOeu2cbKbA6mG/IMMWtNqoLzpr8MOLEjvK80/kusf51xZdjHsIz75O8odlIA0RX1FiTmzXyYvh+uMj4eiXlCVEs+ngDKvGGNIJ22vCKoDmLeloN0T3RS63kSOtbxpqL+8ifOAZOfNaKgoNXULnuhqI7BYCbq0bvzwQdOgd8J9pn5Xe60/PVSwtwiL3RPYo+zGlB9pY4UkN/rloAH8bY9gSkSIb0FQmVOD+mqCn3HV8 MiPWXgkn/pDGS1gIiUr4jbT0y94uHwOk7Fb0aaQv7Z6EhZDEdd0+5EPT1x2iY/rY3Giioweog8q8BkyQzWX31NNmjV4qF8qR+J X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b994cc65-63dd-4924-664d-08d9f6e50940 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2022 15:56:21.1388 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: thDvNo4dGbrQPhLRCOY1zq7UfdavMx0138VpdboqEW0AfMwaDGYvsXeMjzipySU+HJKGygwcHWE+KplJdb7bCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2588 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10267 signatures=681306 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 mlxlogscore=866 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202230090 X-Proofpoint-GUID: ytavafPL8cMlh1QdWhh_xCQXB6fwNr-8 X-Proofpoint-ORIG-GUID: ytavafPL8cMlh1QdWhh_xCQXB6fwNr-8 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227519 Archived-At: > > (add-hook 'some-mode-hook > > (lambda () > > (face-remap-set-base 'default 'variable-pitch))) > > > > I get an error saying that `variable-pitch' isn't a list. > > (And trying '(variable-pitch) instead gives the same error.) >=20 > Looks like this regression was introduced by cece37cf09de9, which just > wanted to simplify the specs list. But then the test after that wasn't > adjusted. I've now fixed this in Emacs 29. Thanks for fixing this. I downloaded face-remap.el from MASTER, and I see that you applied the fix I suggested: (if (or (null specs) (eq specs face)). I see from the commit log that the regression was introduced in 2008. Which Emacs release was that? [And how do I find that release @ from the web interface to the repo, here? https://repo.or.cz/emacs.git/commit/cece37cf09de9]