unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: "46621@debbugs.gnu.org" <46621@debbugs.gnu.org>,
	"Mattias Engdegård" <mattiase@acm.org>,
	"Simen Heggestøyl" <simenheg@runbox.com>
Subject: bug#46621: Copy line
Date: Wed, 22 Jun 2022 14:10:30 +0000	[thread overview]
Message-ID: <SJ0PR10MB548845EC0592059D8008972FF3B29@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <86o7yl9oc4.fsf@mail.linkov.net>

> Now I realized what's actually missing is a command `mark-line'.

About a decade ago I added command `mark-line' to my
ad hoc library `misc-cmds.el', with this comment:

  ;; Probably not very useful.

And yeah, IMO it's not very useful (for me, at least).

> After marking the line it could move point to the
> beginning of the next line.

FWIW, my version moves to the end of the marked line.
IOW, it marks only the line, not its trailing newline.

(defun mark-line (&optional arg)
  "Put mark at end of line, point at beginning.
A numeric prefix arg means move forward (backward if negative) that
many lines, thus marking a line other than the one point was
originally in."
  (interactive "P")
  (setq arg  (if arg (prefix-numeric-value arg) 0))
  (let ((inhibit-field-motion  t))
    (forward-line arg)
    (push-mark nil t t)
    (goto-char (line-end-position))))

> Then the key sequence would be `mark-line M-w C-y'.  And the case of
> a missing trai[l]ing newline is very rare, so an extra RET is not a
> problem.
> 
> > I.e., `duplicate-line' offers both a practical and
> > mental simplification over what we have today,

Bof.

> > but making that command do region stuff doesn't
> > really give anything except muddling up the command semantics.
> 
> The above suggestion is just an alternative way to do the same.
> 
> BTW, what do you think about the already suggested leaving point
> at the end of duplicated lines?  This means removing save-excursion
> and adding backward-char to the end of `duplicate-line' to move point
> before the last newline.

IMO, it's fine to add any commands you like,
whatever their general use(ful|less)ness.

But please don't succumb to giving them key
bindings just because some new contributor
requested them.  Even if you feel you want
to encourage new participants, that's not
appropriate.  (My impression is that this is
in fact sometimes a thing with Emacs dev.)

Emacs has gotten along quite well for a very
long time without feeling the crying need
for a `duplicate-line', a `copy-line' or a
`mark-line' command.  Maybe ask yourself why.

Just imagine that some such request doesn't
come from a new contributor - treat it as
you would from a longtime participant.





  parent reply	other threads:[~2022-06-22 14:10 UTC|newest]

Thread overview: 117+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 19:07 bug#46621: Copy line Juri Linkov
2021-02-18 19:30 ` bug#46621: [External] : " Drew Adams
2021-02-20  6:58   ` Richard Stallman
2021-02-19 13:09 ` Lars Ingebrigtsen
2021-02-19 20:27   ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-20  6:54     ` Eli Zaretskii
2021-02-20 13:05       ` Lars Ingebrigtsen
2021-02-20 13:12         ` Eli Zaretskii
2021-02-20 13:18           ` Lars Ingebrigtsen
2021-02-20 14:15             ` Eli Zaretskii
2021-02-20 14:35               ` Dmitry Gutov
2021-02-20 13:03     ` Lars Ingebrigtsen
2021-02-20 18:28       ` Juri Linkov
2021-02-21  6:16         ` Richard Stallman
2021-02-21  6:21         ` Richard Stallman
2021-02-21  8:54           ` Juri Linkov
2021-02-21 10:41             ` Eli Zaretskii
2021-02-21 13:12               ` Lars Ingebrigtsen
2021-02-21 13:19                 ` Eli Zaretskii
2021-02-21 15:51                   ` Lars Ingebrigtsen
2021-02-21 17:06                     ` Eli Zaretskii
2021-02-21 17:39                       ` Lars Ingebrigtsen
2021-02-21 18:00                     ` bug#46621: [External] : " Drew Adams
2021-02-21 17:45                 ` Drew Adams
2021-02-22  6:22                 ` Richard Stallman
2021-02-21 17:41               ` bug#46621: [External] : " Drew Adams
2021-02-21 20:37               ` Juri Linkov
2021-02-21 22:06                 ` bug#46621: [External] : " Drew Adams
2021-02-22 15:45                 ` Eli Zaretskii
2021-02-21 23:04             ` Howard Melman
2021-02-22  6:23             ` Richard Stallman
2021-02-22  9:07               ` Juri Linkov
2021-02-22 15:43                 ` Eli Zaretskii
2021-02-22 16:28                   ` Helmut Eller
2021-02-22 16:58                     ` Andreas Schwab
2021-02-22 18:32                       ` Helmut Eller
2021-02-22 19:41                         ` Howard Melman
2021-02-22 19:46                           ` bug#46621: [External] : " Drew Adams
2021-02-23 19:29                             ` Dmitry Gutov
2022-06-28 14:28                               ` Drew Adams
2021-02-22 17:08                     ` Eli Zaretskii
2021-02-22 18:42                       ` Helmut Eller
2021-02-22 17:04                   ` Gregory Heytings
2021-02-22 17:16                     ` Eli Zaretskii
2021-02-22 17:54                       ` Gregory Heytings
2021-02-22 20:51                   ` Stephen Berman
2021-02-21 13:13         ` Lars Ingebrigtsen
2022-06-17 17:34 ` Lars Ingebrigtsen
2022-06-18  9:32   ` Simen Heggestøyl
2022-06-20 18:28   ` Richard Stallman
2022-06-18 18:02 ` Mattias Engdegård
2022-06-18 18:09   ` Eli Zaretskii
2022-06-19 15:02     ` Mattias Engdegård
2022-07-03 17:21     ` Mattias Engdegård
2022-07-04  3:24       ` Pankaj Jangid
2022-07-05 16:02       ` Mattias Engdegård
2022-07-05 16:52         ` Lars Ingebrigtsen
2022-07-05 20:19           ` Mattias Engdegård
2022-06-19 11:43   ` Lars Ingebrigtsen
2022-06-19 15:20     ` Mattias Engdegård
2022-06-19 15:22       ` Lars Ingebrigtsen
2022-06-20  9:26         ` Mattias Engdegård
2022-06-21 10:35           ` Lars Ingebrigtsen
2022-06-21 11:13             ` Mattias Engdegård
2022-06-22  4:11               ` Lars Ingebrigtsen
2022-06-21 17:41             ` Juri Linkov
2022-06-22  4:07               ` Lars Ingebrigtsen
2022-06-22  7:28                 ` Juri Linkov
2022-06-22  7:54                   ` Lars Ingebrigtsen
2022-06-22 17:21                     ` Pankaj Jangid
2022-06-22 18:24                       ` Juri Linkov
2022-06-22 18:45                         ` Lars Ingebrigtsen
2022-06-23  7:49                       ` Lars Ingebrigtsen
2022-06-23  8:08                         ` Pankaj Jangid
2022-06-23  8:17                           ` Andreas Schwab
2022-06-23  9:05                             ` Lars Ingebrigtsen
2022-07-06 17:34                               ` Juri Linkov
2022-07-07  7:58                                 ` Lars Ingebrigtsen
2022-07-07 16:45                                   ` Juri Linkov
2022-07-07 18:03                                     ` Lars Ingebrigtsen
2022-07-07 18:20                                       ` Juri Linkov
2022-07-07 18:24                                         ` Lars Ingebrigtsen
2022-07-08 17:10                                           ` Juri Linkov
2022-07-10 12:57                                             ` Lars Ingebrigtsen
2022-07-14 17:16                                           ` Juri Linkov
2022-07-14 17:47                                             ` Andreas Schwab
2022-07-14 19:30                                               ` Juri Linkov
2022-06-23  9:22                             ` Robert Pluim
2022-06-23 11:16                               ` Pankaj Jangid
2022-06-23 11:34                                 ` Lars Ingebrigtsen
2022-06-23  9:04                           ` Lars Ingebrigtsen
2022-06-23 11:12                             ` Pankaj Jangid
2022-06-23 15:10                     ` Mattias Engdegård
2022-06-23 15:20                       ` Lars Ingebrigtsen
2022-06-25 16:35                         ` Mattias Engdegård
2022-06-23 17:35                       ` Juri Linkov
2022-06-23 17:49                         ` Drew Adams
2022-06-25 16:51                         ` Mattias Engdegård
2022-06-25 17:48                           ` Drew Adams
2022-06-27 19:40                           ` Juri Linkov
2022-06-28  8:41                             ` Mattias Engdegård
2022-06-28 12:10                               ` Helmut Eller
2022-06-22 14:10                   ` Drew Adams [this message]
2022-06-22 17:27                     ` Pankaj Jangid
2022-06-22 20:44   ` Sean Whitton
2022-06-22 20:50     ` Drew Adams
2022-06-23 15:47       ` Helmut Eller
2022-06-23 16:07         ` Eli Zaretskii
2022-06-23 17:46         ` Drew Adams
2022-06-23  5:47     ` Eli Zaretskii
2022-06-23 17:00       ` Sean Whitton
2022-06-23 17:37         ` Sean Whitton
2022-06-23 18:31         ` Eli Zaretskii
2022-06-30 16:31           ` Sean Whitton
2022-07-01  9:27             ` Lars Ingebrigtsen
2022-07-01 16:34               ` Sean Whitton
     [not found] <87a6aal3l5.fsf@simenheg@gmail.com>
2022-06-18 12:56 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB548845EC0592059D8008972FF3B29@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=46621@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=mattiase@acm.org \
    --cc=simenheg@runbox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).