From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Date: Tue, 2 Aug 2022 20:10:36 +0000 Message-ID: References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21846"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "56896@debbugs.gnu.org" <56896@debbugs.gnu.org> To: Eli Zaretskii , Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 02 22:11:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIyEi-0005WU-6R for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 22:11:28 +0200 Original-Received: from localhost ([::1]:57828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIyEg-0001CV-Kh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 16:11:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIyEL-0001C7-2C for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 16:11:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIyEI-0004XZ-Mv for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 16:11:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIyEI-0000fv-Hl for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 16:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16594710472575 (code B ref 56896); Tue, 02 Aug 2022 20:11:02 +0000 Original-Received: (at 56896) by debbugs.gnu.org; 2 Aug 2022 20:10:47 +0000 Original-Received: from localhost ([127.0.0.1]:45154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIyE3-0000fS-0H for submit@debbugs.gnu.org; Tue, 02 Aug 2022 16:10:47 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:14878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIyDw-0000fE-Gl for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 16:10:45 -0400 Original-Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 272JIspr017323; Tue, 2 Aug 2022 20:10:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=ZOCHkrlyDqqURyV+1/Fx75CIxh4/MDgmmGC+5E68/9Q=; b=EBg01oSX+A0/AiPILX6kUHE7tg1NAJo+b9kLGDMfTOia8THU7b76I67k54ptrkWOLWZQ bwNsqBRYq045FxsMn7WlEKYGiT6xyjZ3nZ7LeT3lQNJYZqwWg2J1gKyCkJAaBUzZLdqA MLGT1E2zrFEndM/jHiJ82F1XgijTFftr9EX9ncUmwVKlWByqU27WwoUGCRcx0SToo8K7 j+766poUCtwN7cXP0Gv7rSWqqhQJgL0i9CU91Wb8YXpo4h3VjlEHUP0maIOXRBfHkJUK fuYwol1KgSB5Fy7e05L4jMtoRBCVkVz1NxPMVrR+Tq/Kh7syMQVskFQDtAc7ZzRAjg4j GQ== Original-Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hmue2r64g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Aug 2022 20:10:39 +0000 Original-Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 272HiBPa007338; Tue, 2 Aug 2022 20:10:38 GMT Original-Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2106.outbound.protection.outlook.com [104.47.55.106]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hmu32dd3p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Aug 2022 20:10:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PXlLIoIGQocxK29ltG0j1N+qfDaz1+Za0HH/N0lRG+Vkx+h9h0sKCzVgxkLBdHt35Bbhi09gK0vkVu5JEUCyh32KzFMKY8zAoFRit36n7hcfnCf4SdKLNGEZdVMDkoFiFZeXmb6viNZLHih0AisTCUgn2QPhv9s18pxrG8xodF1bxYXV78GaHUzMUToAxIN1ydVYq7MW2fAEGtORXLDB4wwz8qrTfTfPVSJ4+tojuZPnVv6cZcWKH0eizq0S0/qIkWoDNVOueiU9qH81c7vkSazlzKZtpUlOxr4ONEvdvTFAqDxD1L0Mi0ErUrfOlAmFqjS9JrU+c8eg0J2/JBcaWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZOCHkrlyDqqURyV+1/Fx75CIxh4/MDgmmGC+5E68/9Q=; b=EGkr1areIu0sXlPEA7OsMEuRS5bI3LNwV5XF85dbZyEvkogD02IUb6GuE3+5gXA2ZjZWUf9d1vgVM2AaRMqwx+IyvJzTdLhRhtX3TQvv2a1nlyPoR6kyo0/e9J7agpg+41EDe7q4S0Hy3CPitShlCtNiVnMyVqDHjCUmLrLoWhUvlFH0eBELpz6D5P8UEy5QF8P1vonuIGZS3wWirfZPvIY515Zg6cKgffORVN0PE2GpNWcdsQ+6ja+s7E8ZdbQJ2gbrzYPNm7morFN932jJv9A5oFIZQebfFewFkMsY9pTZ/nW2YvXyi3u95hkl/IUpQdU0S9ovLfFtEioumfrrkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZOCHkrlyDqqURyV+1/Fx75CIxh4/MDgmmGC+5E68/9Q=; b=ikr8oMwyLHiX8wDhN3N/1q/I54EKbRmeN4n1lCnI+sU6KP4tr3hZewR8Ltx2tPqAOxKWzC1nMQJD2KBW/ROcrgp4z+WWFmpxRS3qsmW+dIiTpvSFLNZ+95IcfysTk12zMbMZVYiQoiE4ZJ045fyUUJ189Vk6/SPB5fF7UGkN0jk= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BN0PR10MB5207.namprd10.prod.outlook.com (2603:10b6:408:12c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Tue, 2 Aug 2022 20:10:36 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::8d65:31e6:cd0e:e95]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::8d65:31e6:cd0e:e95%5]) with mapi id 15.20.5482.016; Tue, 2 Aug 2022 20:10:36 +0000 Thread-Topic: [External] : bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Thread-Index: AQHYpqUWgTfQ0OVuZUKlXi4NQXW6Ha2cAN4A In-Reply-To: <83tu6u5u9r.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10dc5359-1acf-488e-573d-08da74c31034 x-ms-traffictypediagnostic: BN0PR10MB5207:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EcGITFkbeMkNq1oX3KCyTrbNXN5CDRFV1uTxC1ftUd/0D0YB5ht5Fk2fYC6PvCJNjl8hN0zVCUOl5bUzdcHq5PZm8WbVk1ielAIirrPrduXfDNZIEoHEZHMmRcl/tWtEvVI+upC78POK/C5DmzPsaGLwQXtRPYwkbkKQacX961xmtySs3aYwac8tP2wq+SZMrPxJUg+N636Jr0A66O0XLWzOSqkOXnjrOY7d6fG3S0yLKu2jYAT9rwkojvXSdT9R4y3OLu/X/ST1cx06/xlv/4m7ADRkTkqhif46HCreEjogqg6eR22VrgsqbYsXfDVnH70rxfi5MCYmnYR7ghFHc1LcKX+RfKNcNNAi52mkkrQUi3Iuxh+RWP2Xy6aQafPaBVFd4Q8dGOjc/mG1scX0uYY4vf7wqM+1LHN5Za4G0/Kia0eVft/PDg3mTA3b8TK/9Fz6ulsRqM1rl/IhWf4C4TftSm6QfU6HP4x6SYKYFrvULXfNgSZL+DTz470g+eIw3cBUTLxawwxWHEQ+xqjiNAL1kgGzmwS47RaRDvzCFdFT/2yYTRmAh9not5C9pMbqhqAkiexXa/vtjCFpDu9JUqtKKQixhocUbVCGhjkWUP837MFasohldAT3cMVWBmz5fc5EmWjNKUJnVVWSJZ2SIM6+9P9czq/skgLwPXMNcrzAB/97PWEmjshSIKPC7gJjPhp6J4rWcCn/Uo8lmJUTvEhpFz+Cgvk0PsMUJ+g/KFP8uvFn/zVOvMcMKPby0 MUj81R8bu70RzquSSLuyXEoc9kCPRn6uFFSVnvusffofjV0A3z2a5Qz9pq+idtw6J9O x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(366004)(39860400002)(346002)(136003)(376002)(26005)(7696005)(6506007)(186003)(5660300002)(44832011)(8936002)(9686003)(4744005)(52536014)(33656002)(110136005)(478600001)(71200400001)(41300700001)(76116006)(122000001)(86362001)(38070700005)(316002)(2906002)(66446008)(55016003)(4326008)(8676002)(38100700002)(66946007)(64756008)(66476007)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: dPdHH/0h4ZGDbBir9AysyVQwM7EIvhgyF9mrL+6IBIbU+c1mx3/CyoLhzPFazCbsNaUF2LdXHejy4z/5qUVT/MIy6JoHjwcp6wNWn3j13YBh9VHHF3eeKfDXjkJo+6A8a2ucrrxjS1n01ZEPr9zyXsVM2jY82QGGoFHlxmD92qrzENRBACJonZlcMzmDgc5HgOeL4E7G7fLfFLwhRFQ0H9ytNFX7pGxjBS9ef2P+r55o2IT/xe2/QweLOjau4AL+G1rJfP553mVi9b/wkcEON9aZY53zCYLEMP260aWaCGP1MRbNL5M5MpiirlCKvZCFkZKoKSA+ZI7e+MQ2vfxVtmg4OJb1FqOcmXskQIT08wtXPwJC0eF+WRiLZFId4FKqrvEXzqBwpXf0dVDt41QwSYkpEyg2Opj/TggTUb1t44jFbQnZgeG8mhXUVBIC7mPJE7Rj9w9nwSlmTAC9LoqGD+o+bbFJBXW8ydtcszu9bLn5JyrqF+spzYnwRegnpGb4mKLkFXZ2fI0O2L7r2DHKgbCQ4nT5poZ4/rd0DbqdrcBEv1uT3K4Ary1PJKMzAsUz47NSHA8nAgepixvrNOpT6xkC51422rOlAmXhlKTaTwNEypY3q9LrNC5j5FVXVu4ODRCbhcojYuKrg9xcORpwFfZfxbdE5+cKsyAKaNgGDq6A4cNfR4BH3VSX/mw720tKvys5QC1/tCohPi+XAUfIC9/cnQQsI8RyzWeuY/tAVx4B5IvrcO1EwajSYb dZOzfuxHkx48wnz3Vt8torbpofuWDF9IfFAyS4nSiEj6S8YV/FudK6LGzn8LvpO+M6lIvgZ2kb2nIkgFPxYpGvltgalg+gyLGJ X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10dc5359-1acf-488e-573d-08da74c31034 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2022 20:10:36.5344 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GIVvp85kCT/NKSXVmmTcQgt9aJMTw4hDLYRePU/muEXjFfmExgl+W4C41tWPch6/kfNyatnkRPSOFfyitPTsZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5207 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-02_14,2022-08-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxlogscore=831 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2208020095 X-Proofpoint-ORIG-GUID: HfJbA0tx7dU_9HtYJQBEsyEbiexNPlYL X-Proofpoint-GUID: HfJbA0tx7dU_9HtYJQBEsyEbiexNPlYL X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238583 Archived-At: > Why not make the icon customizable, and offer several possible bitmaps > to chose from? Hardcoding a single icon will always annoy someone. +1. FWIW, Bookmark+ has had this for a decade. Two options for this. Uses predefined var `fringe-bitmaps' for the choice. (But really there should (also?) be a user option for such a list.) (defcustom bmkp-light-left-fringe-bitmap 'left-triangle "Symbol for the left fringe bitmap to use to highlight a bookmark." :type (cons 'choice (mapcar (lambda (bb) (list 'const bb)) fringe-bitmaps= )) :group 'bookmark-plus) (defcustom bmkp-light-right-fringe-bitmap 'right-triangle "Symbol for the right fringe bitmap to use to highlight a bookmark." :type (cons 'choice (mapcar (lambda (bb) (list 'const bb)) fringe-bitmaps= )) :group 'bookmark-plus)) E.g., setting `bmkp-light-left-fringe-bitmap' to Jim's `bookmark-fringe-mark' (symbol) uses that fringe bitmap. And yes, it would be good to add a bitmap such as Jim suggested to `fringe-bitmaps'.