From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Jim Porter <jporterbugs@gmail.com>
Cc: "56896@debbugs.gnu.org" <56896@debbugs.gnu.org>
Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark
Date: Tue, 2 Aug 2022 20:10:36 +0000 [thread overview]
Message-ID: <SJ0PR10MB54883508242E713140AF6626F39D9@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <83tu6u5u9r.fsf@gnu.org>
> Why not make the icon customizable, and offer several possible bitmaps
> to chose from? Hardcoding a single icon will always annoy someone.
+1.
FWIW, Bookmark+ has had this for a decade.
Two options for this. Uses predefined var `fringe-bitmaps'
for the choice. (But really there should (also?) be a user
option for such a list.)
(defcustom bmkp-light-left-fringe-bitmap 'left-triangle
"Symbol for the left fringe bitmap to use to highlight a bookmark."
:type (cons 'choice (mapcar (lambda (bb) (list 'const bb)) fringe-bitmaps))
:group 'bookmark-plus)
(defcustom bmkp-light-right-fringe-bitmap 'right-triangle
"Symbol for the right fringe bitmap to use to highlight a bookmark."
:type (cons 'choice (mapcar (lambda (bb) (list 'const bb)) fringe-bitmaps))
:group 'bookmark-plus))
E.g., setting `bmkp-light-left-fringe-bitmap' to Jim's
`bookmark-fringe-mark' (symbol) uses that fringe bitmap.
And yes, it would be good to add a bitmap such as Jim
suggested to `fringe-bitmaps'.
next prev parent reply other threads:[~2022-08-02 20:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 19:13 bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Jim Porter
2022-08-02 19:18 ` Eli Zaretskii
2022-08-02 20:05 ` Jim Porter
2022-08-03 2:28 ` Eli Zaretskii
2022-08-04 3:24 ` Jim Porter
2022-08-04 6:53 ` Eli Zaretskii
2022-08-04 6:57 ` Lars Ingebrigtsen
2022-08-05 4:41 ` Jim Porter
2022-08-13 21:59 ` bug#56896: 29.0.50; [PATCHv3] " Jim Porter
2022-08-15 6:44 ` Lars Ingebrigtsen
2022-08-16 4:17 ` Jim Porter
2022-08-21 16:23 ` Juri Linkov
2022-08-02 20:10 ` Drew Adams [this message]
2022-08-03 2:23 ` bug#56896: 29.0.50; [PATCH] " Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-03 2:42 ` Jim Porter
2022-08-03 4:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB54883508242E713140AF6626F39D9@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=56896@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).