From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#64619: [PATCH] Add toggle-window-dedicated command Date: Sat, 15 Jul 2023 21:30:17 +0000 Message-ID: References: <87jzv2p9e0.fsf@posteo.net> <87zg3yhwpe.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22845"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Spencer Baugh , Philip Kaludercic , "64619@debbugs.gnu.org" <64619@debbugs.gnu.org> To: "sbaugh@catern.com" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 23:31:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKmrQ-0005my-LQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 23:31:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKmr3-00065X-A0; Sat, 15 Jul 2023 17:31:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKmqz-000658-7Q for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 17:31:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKmqy-00008O-VW for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 17:31:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKmqy-0007E6-Oo for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 17:31:00 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 21:31:00 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64619-submit@debbugs.gnu.org id=B64619.168945662723108 (code B ref 64619); Sat, 15 Jul 2023 21:31:00 +0000 Original-Received: (at 64619) by debbugs.gnu.org; 15 Jul 2023 21:30:27 +0000 Original-Received: from localhost ([127.0.0.1]:46208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKmqQ-0005zJ-Tv for submit@debbugs.gnu.org; Sat, 15 Jul 2023 17:30:27 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:7286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKmqN-0005np-Dl for 64619@debbugs.gnu.org; Sat, 15 Jul 2023 17:30:25 -0400 Original-Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36FLS9JJ017858; Sat, 15 Jul 2023 21:30:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=i/aq+BY+scxlDO7xvWeA0w6jJ08+tSzN5O91J+wUYRU=; b=qz40RO65E4uVlM792ROpyys1Eilfaz2ieQcXHPbEGXrBBAIMxkVQh3/NcFo7HNdr8tHv RIvZ8MVCkEYPdRKfZNA38W0/1uQBIkirsEj0PL9w+bwN2bl4G4gzJA6UgM8msewsqZkf +9P0+gPINXDq26OQoAv0/i00nTjhvMnC6+P+8OIBQN4Vm3uDW+DNu7OmYbJTOH6ALpHp mC/5T+lQg4paM6FSV9NEFyCdaahgY8plbbjxbnolCSLpKo8Cj9ANoBtiGjgcBuuek59G Nx2rIXoqMtahQta+WL9RKzcaVcAVMSZc5XcOvAbJRiAIrSbjgVNMDr7XGeI39xKccrcu 5Q== Original-Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3run88gq82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 15 Jul 2023 21:30:21 +0000 Original-Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 36FJ7jix038163; Sat, 15 Jul 2023 21:30:20 GMT Original-Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2041.outbound.protection.outlook.com [104.47.51.41]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ruhw1uedw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 15 Jul 2023 21:30:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UluFgmILY7bEY74Rv+ouLAzjFLo3Ty0neakJTUk22GWGmc1kBzlO4lHN5+0RQ2kO+Sdyrl7v4lmO7W/PTFhXgr73NGrcfIkTBD+xZG6LYIKBqqGwOu6W1gEhQ8OWo6j7UWukW7AJgEBwBeR6y3ziGgPIQLDfweZHvcriB8OstsbWXgDmx2+iun2LYnqWhLcSt7sU2Snocdi0Ilrp0KX0jr6yUveOencqz3N8iztgFk4gb12RZG6Ec4iE7snrXRsfZBPTk36gky5570zcFc3rI7MwNi8Uoit4pYndgL070vDH4UMnPR4lCWrWlNW1Z269lP6ofPSwnb0ERrMfAXASZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i/aq+BY+scxlDO7xvWeA0w6jJ08+tSzN5O91J+wUYRU=; b=NZGRChxpJLsZWg/KH5mbUwK9V6ocUYOyJHSlntitKILhT3Q4cttrkXiK1Aoh34YjCSvx9h1R8WQdDJe5bD/DZBBAtQS5VdqtNxjCEyhl9OjB8Gkzqhc/VwHzKYRZBRJnWKmc4vI2KPYbrA7mOF+4FvUfDpdBWs8Bhp8die8Falj0zvoCEggC02VV0LVinbHEH/5Kin4TuvsdlobzQUt4eBkR1om+/c04sIMFjpK1AyTy8j+0lAHNDqTCHxawhOn9f4442waV+oQH/tWx0zpzZUeJ4AJOvjn9L8S7TOAKd+uLwNzxkLYJA28gqW1R37ia1SyPzl1q+Ce/09McfH5Shw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i/aq+BY+scxlDO7xvWeA0w6jJ08+tSzN5O91J+wUYRU=; b=bH2FDioqKkVAsB4ePePb/CD/gGgQR7dxyEmKU1bdIZLnvTKTB/6wv0Gf/2T+etR3mdqKmZBEUrboyBWYAynIX93Q9jscbrakRNm9Ga6Bp9kybL/a2AdbHSDHrlyHu/ZwR/wOoq77t9SzHnmeB23PWbt1am+nvDRubh9rgfk8Nk8= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by PH7PR10MB6481.namprd10.prod.outlook.com (2603:10b6:510:1ec::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Sat, 15 Jul 2023 21:30:17 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::3d70:a351:b27b:812a]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::3d70:a351:b27b:812a%3]) with mapi id 15.20.6588.028; Sat, 15 Jul 2023 21:30:17 +0000 Thread-Topic: [External] : Re: bug#64619: [PATCH] Add toggle-window-dedicated command Thread-Index: AQHZtq8gtY1KC46J7kmH1xW6LF/k5a+7V7Ng In-Reply-To: <87zg3yhwpe.fsf@catern.com> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|PH7PR10MB6481:EE_ x-ms-office365-filtering-correlation-id: 3ba1b847-2dfd-4ed8-78ff-08db857aaf13 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bmwS2Cb0AeUDyVlMheiTDpKRCCBgLi1TPR562IDZvNkNs4ZYmx2TEofyoBsR69CnR8HlM3S5t9q1J3anlmKyjrFnAHnUtstZv5eUR5bdrv5tm0dl1iXw7avAWV0EN6xcftapqP+5uQSOaCUNyAs6LBmLMW/yyj+AbZ61WIoSPBr2vnpu5EGNWj4Dg/XX3Z6zDSwYTiqXR2GmRNkxU3FFQsESjqCVjYQ53N9nX1Nnhfr5lg90A1U6VbbhObXxPlNIdB4fpfpzeMKZ0Pz6q7ChnC+SCOJIX9KGiXigzVy8lCBxXXcfr09T5TH0JceLxq5x0lwzXp+tVypjsTUz0xWIcU9Vl7I6CKrWtHnKwzCFLdpy2HoTeWeSsqNutRxySneOpCCTiI9EwfoPwHdzPG/eSNYFpQib95cCgVzwUm9OaoZPQ1MH+mI/40Uc+OIg7xT09LpOFyv8dujbjFI4jU9yVpc4fY3jJuW0+uy5CrJG+nrZpebaJmFywt4Y8CzgX4Izs1x0oSMI4faQE/Oc0IBRG+hd4zMo28C9YGb7Dxelp/rzdxDm25VbB+cW0smv203/qN39sJEULc8uElDr6cxwms3MMyJ9JcPi+4ao+JXq7liIgpD+S7feHfcM99AQuKr1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(366004)(136003)(39860400002)(346002)(376002)(451199021)(478600001)(71200400001)(7696005)(54906003)(186003)(6506007)(26005)(9686003)(76116006)(2906002)(44832011)(316002)(41300700001)(66946007)(66556008)(66476007)(66446008)(64756008)(6916009)(4326008)(5660300002)(52536014)(8936002)(8676002)(38100700002)(122000001)(33656002)(86362001)(38070700005)(83380400001)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: MN5V66TZfHVNLT3Hkas9z6bCj8PdFVck0EuETb/diljoq73ZsCBnd3qHDe1YP5+qxfHyPOemHJwn1/FEyaF45RNLIB0VHPjL4hM2ZDQfud+kXL7KJvtuTjn2ZN345VOXg0cZky5QGVTjanTz/63uavTMzkkeR28h92T1e3G4ISYk8w/lDfsef+cyxFZbx3QaE3SrWihz5jEkL6e1kCU8DsJrgy9/b/bs1mAhYCHsVCmwc2kAVilSpVpdY9WqiY1ySx/1fNmUl0lw8ZdxNFHPSxXKvZUcmvBj/0imysq//ioJks9mTyIy/5vMZIwmnc5DA/v5hIGYDs7m0gB399OCMx2LIb0Zp4/6yAAqptrugO0rbsIQ7HH2BrRrKinMiNnXBwRmiUlxygMbNugdKV5/dKJbzcpoPKeUiMWzL0L07mCA+m3Rs/JoQF1zhqlcse8VHAWBYOgMvqZmHs+TkVr8EAxjpKJRST/faujEvyJpRgqQbN97aocVXYJJFM1mV9iyy835dsWZYw14Xx33hm0+tPmF4dnHOgJCueEqdOtPl0A6cVsxyvNKCe2tV6fE6+wgnAoA4dkLAB/O95FtxViayfyQb0SOAlSpgqZYFD3OIhTnXCQGu7FWnmSmWAPGgOxGopsJ0x7GEQS3jR+SEIZBXYZU9ihhDt5Utn20u6F6gZl1ZzYvZ8juD7w4s1LdMqAguKcNHNPVAuVBgU31zbfAqfD1ZDvDBvzIvC7j5WrgF5YuiIV/+fTtlcA49q +2wblH6D6nhFmzztO0OKy1v9GeUzIErUPjoiJ0yODefp+k+68GikU+DwjOYbfU6ZgWSPrsGy+pybB4jMxMObpJhbSQefugQyRU X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ePbZG7yu0cd3pPsFykimGrdpCn8DptW2/p0+lCLMI3A1NXVARmn3NOUhdj5TxJhZmgINaFZ5RJGomvqCzOZq4IoCHIXOaNX2OWg7Gmd/zCNEkovqhCIQy0ustmvaPPXDAS2MF8QIGATpsEQYp9tcqXkXn2KSGRCMNWQ5Jw0uWlyhHrwV1pESFNIlZpb9xtPOH1XUQ5Bk1MJADRPeydvFP4L7BhUDp3GKiMqiYpRaFWvGNWvKbh0F4xAyeggDIqX5Cv4hGsZMDTXr7ltiDyOyzZeKdJq5mUNYGkPw2ms164xiXDaLn5K+EvifRSlNQTjSa5cryyhFghaGlXIOujdA/fz8qDOd6nhmYFTzI6+CbKWlDrZfGajUUdKrKAbBB4v5D6I5dFw5n14c4f4xd8iHuwIgQov/Lw1tkEAChCg4C8HaLWt0wXfYdeSZQdA+x2U7brAj1PX18VP0ZfFVd0S6Wng1va5CVmx4qKKjPOJDVp9ax4ylQtFOGE5+m/B7f2bCtUJUIgyEBv/0kN0ob1E66VYPIVUWuX+Wnm1PL+kPt7FZz+JJzwNTaMLbNUmbNnRd7MjSaEPuRaR1mO+XMKGd2pBOAZjMMRjxpq7WlYRzjOe2tUe4LD1je2ERj1MLCtaDdag/zfwq8DYnW0KR3dQDnJk6ErBQrI85lylM9xZy9XA30pd8DCQdZ4oNFkafc4o2af3IYZano4nwoq4RnalKpZhhuLf/KEMNdp6b7F10peqUm0 J8EUOCuJCruDnbd1ZzxKdrV0CxXGWoPJz69dDH7sdQfjwBgTvBsX88tYJk2+Ten8Hp4qLO7UNCEpFhkJ6mc8Cg0OQHzhSU4sSI X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ba1b847-2dfd-4ed8-78ff-08db857aaf13 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2023 21:30:17.2822 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xeyTWsG6Ye4Nl+J8YInH0wEN/64qZwJERu7gcLEHB3vsROSfPJeFqhzG7k5JNc2qB1FEB6LHaB1F6PcsnoP5vA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6481 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-15_10,2023-07-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 mlxlogscore=375 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307150205 X-Proofpoint-GUID: FMDxGLJkog6DwoKq1F_p6NUc60v1oxDD X-Proofpoint-ORIG-GUID: FMDxGLJkog6DwoKq1F_p6NUc60v1oxDD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265250 Archived-At: > > 1. Why _weakly_ dedicated? >=20 > AFAIK, the difference is that if you explicitly try to switch buffer > with e.g. C-x b, you succeed when the dedication is weak, and fail with > an error when the dedication is strong. I find that if I explicitly hit > C-x b, I want to actually switch buffers in the current window, I never > want the switch to fail. Making it fail seems useful for Lisp programs, > sometimes, but not so much interactive usage. Thanks for providing your reasons/rationale. That's the behavior you prefer, as one user. Other users can prefer strong, not weak. (But I see, below, that you're considering providing both.) Let's not forget that "weak" dedication was added as an additional, optional behavior, decades after ordinary (aka strong) dedication was in use. > > 2. Why not just this? > > > > (let ((before (window-dedicated-p window))) > > (set-window-dedicated-p window (not before)) > > (when interactive > > (message "Window is %s dedicated to buffer %s" > > (if before "no longer" "now") > > (current-buffer)))) > > > > If someone might not know what it means for a > > window to be dedicated, put that info in the > > doc string, not in the message. >=20 > Will do. Maybe you won't want that toggling to `t' instead of `dedicated', given your preference expressed above? (`not' nil returns `t'.) > > 3. The toggle, as OP proposed it, imposes weak > > dedication, and the toggle as I wrote it above > > imposes strong dedication. What if you want > > a toggle that respects whatever non-nil FLAG > > (weak or strong) might have already been used > > for the window? > > > > IOW, what if the window is dedicated to start > > with, before you first use the toggle, and you > > want to get back that same dedicated behavior > > (weak or strong) when you toggle it back again? > > The toggle (either definition) doesn't do that. >=20 > That would be nice, but I don't see a way to do it. At the same time, I > think it's probably fine for the user to explicitly choose whether they > want it to be weak or strong. After all, this way it allows the user to > change the dedicated mode. Yes, that's where I was heading with that: not easy to do, and we can just let users choose which behavior they want. > > Shouldn't the doc make clear that the toggling > > behavior is always between weak & undedicated > > (OP version) or always between strong & > > undedicated (my version, above)? IOW, let a > > user know that any original dedicated behavior > > is lost, once you use the toggle. > > > > Or if you want to let a user specify whether > > to use weak or strong, maybe do that with a > > prefix arg? >=20 > Good point, I'll add a prefix arg for strong dedication. Thx. (Though I'd prefer it the other way 'round. ;-))