unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
	"15735@debbugs.gnu.org" <15735@debbugs.gnu.org>
Subject: bug#15735: [External] : Re: bug#15735: locate-file-completion-table should not accept incomplete input
Date: Sun, 6 Feb 2022 00:29:27 +0000	[thread overview]
Message-ID: <SJ0PR10MB5488265087177E12C885D2BDF32B9@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <87fsow7sq7.fsf@gnus.org>

> >> I've now introduced a new user option find-library-include-other-files
> >> in Emacs 29 that makes `read-library-name' (and therefore
> >> `find-library') behave differently -- if set to nil, it'll offer
> >> completion over library files and nothing else.
> >
> > Thanks.  But what's the default behavior, nil or non-nil?
> 
> Non-nil.

So we're back to Square 1.  Guess this should be
filed under "won't fix" instead of "done".

Instead of fixing it, e.g. as Stefan indicated,
you chose to give users an option to fix it
themselves, but the default value of the option
doesn't fix it for them.

da> It would make more sense to me if RET at this
da> point did what I expected a second TAB to do:
da> tell you there are no completions (beyond the
da> directory name), but not exit the minibuffer.

sm> Yes, that makes sense.  Indeed, there's a problem in the completion system: we don't distinguish between a valid input and a completion candidate.  "ess-5.3.10/" is a valid completion candidate, but is not a valid input.

sm> IIRC there are cases where the completion primitives make it difficult to enforce this distinction (e.g. when we provide a predicate, where it can be OK to ignore the predicate on intermediate completions like "ess-5.3.10/"), but in the case of load-library's completion, it should be fixable without too much trouble.





      reply	other threads:[~2022-02-06  0:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-27 17:36 bug#15735: 24.3.50; `find-library' completion bug Drew Adams
2013-10-28  4:07 ` Stefan Monnier
2013-10-28 14:00   ` Drew Adams
2013-10-28 14:32     ` Andreas Röhler
2013-10-28 14:39       ` Drew Adams
2013-10-28 14:53     ` Stefan Monnier
2013-10-28 15:06       ` Drew Adams
2013-10-29  1:25         ` Stefan Monnier
2013-10-29  1:28           ` Drew Adams
2022-02-05 23:29           ` bug#15735: locate-file-completion-table should not accept incomplete input Lars Ingebrigtsen
2022-02-06  0:17             ` bug#15735: [External] : " Drew Adams
2022-02-06  0:18               ` Lars Ingebrigtsen
2022-02-06  0:29                 ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR10MB5488265087177E12C885D2BDF32B9@SJ0PR10MB5488.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=15735@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).