From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#53255: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face Date: Sat, 15 Jan 2022 22:31:53 +0000 Message-ID: References: <87y23hl729.fsf@gnus.org> <87zgnxnwkf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13375"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ndame , "53255@debbugs.gnu.org" <53255@debbugs.gnu.org> To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 15 23:34:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8rcr-0003Km-UV for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 23:34:22 +0100 Original-Received: from localhost ([::1]:45412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8rcq-0004aq-V3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 17:34:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8rba-0003cs-Vg for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 17:33:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49281) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8rba-0002XH-LJ for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 17:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8rba-0006i6-HM for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 17:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jan 2022 22:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53255 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 53255-submit@debbugs.gnu.org id=B53255.164228592325675 (code B ref 53255); Sat, 15 Jan 2022 22:33:02 +0000 Original-Received: (at 53255) by debbugs.gnu.org; 15 Jan 2022 22:32:03 +0000 Original-Received: from localhost ([127.0.0.1]:42184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8rac-0006g3-Ml for submit@debbugs.gnu.org; Sat, 15 Jan 2022 17:32:03 -0500 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:5978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8raY-0006fX-1J for 53255@debbugs.gnu.org; Sat, 15 Jan 2022 17:32:02 -0500 Original-Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20FE2UlX020883; Sat, 15 Jan 2022 22:31:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=dRS9RQjBC2OLbZJsthcM7rWKEzIw2l5O0eT1ztemj88=; b=EKX3BvWndC2FOM7wuQ020lxyQn77+eog/x8lCGD8VZh1QGnVQcfuXCycPjAX9709B6LU RtbNHV03kuWW3pTmUV8ER44ZZY05ONLWh1QQIFMcVcahar5mVPbmSQQs3WbpB8gxU0t6 BpcCKSugg3cqtP2Z/wswITe5m2pSfUTXUMlB6D2inkq+JPXAOugz60PxubXv7ufLUHdM FuIp/XnJgQpPr5KJYBQFZHETf/pUsKHcZ/4GXlHYUC3aOsFda0ducd8FVz57s56uXQTx jtR7nAOecEEO/GPudQljxJEYAwbDys6A7aWRrlFjimqomTOHhp+NRC6TJWTHF46dV3BD 5A== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3dkn22s062-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 15 Jan 2022 22:31:57 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 20FMUVKb132461; Sat, 15 Jan 2022 22:31:56 GMT Original-Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2170.outbound.protection.outlook.com [104.47.58.170]) by userp3030.oracle.com with ESMTP id 3dkkcthwyb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 15 Jan 2022 22:31:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JT9HzYyhXZHIj1ZOJFyBNIV9F1VIVb4pzhS1DvGaHQAwbacxldRRJ22kXR7s0HlOOSRb/9wCiOCzaGIK5kubMfnguIKp4AFczwx9/JPcmCz2atswL4cL3siVmu97PHsHAuT0+0LILZ+cUjPq4dW6c0C+TDamdLImNbHm6yLY6GtXhw8JT8XpR3lxEjqa7RCjQXf67sxk+sX4sf/694BwQ/ZNCWxg/yXI4uw/Xcq0txrqvHqPqpErG/uSvO4wVAsYI24GOySYdKLtt8cAvTEY19rATh82IlHFLU7bUIwcRmRFef2tVMVAxAdpcYQB/zEQi1zHE0MbZYsYZNaqA3iQ/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dRS9RQjBC2OLbZJsthcM7rWKEzIw2l5O0eT1ztemj88=; b=c72IyauhLN+2eGfu7Rtl3sN0scxTAVxjiE5Pi3T1snO+L1XP+8yIUAOju51TqVNvRo+Al6gkmWdSr3VS6mzkRD5tE5FfpEG7B21b7Dh0GdZoXTTqY8Wzpj9cJNTJgFxXsaA58dqZEEVtGjVejVNdjWk3GZicAQIJsgX7SOCPhmp909XY6SjupYnVt71i39lwIiOalHNUTcBwqvn2aaHL+JLuYLige3oJWt8jVxUhq1kfvvGHHgksxyKY3KT3kM0XeAPxOSQwMpCoLlGEILaSAEWNMMjCOG18aDfXVtWIPa27A/iOPmdYRfgECPGRXXh+ossKapYwv1eQJuvoU6UJTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dRS9RQjBC2OLbZJsthcM7rWKEzIw2l5O0eT1ztemj88=; b=OGNNhPLJuqfMxnWl56kYq+Zux4p7JH8/hzUYC6Ap/WZf6d28TWXnipzie1bMO6eyXJH3SBAmndSIw4ykw7iBR+P+kqEyFZiwgpQM2LcsdORDehoNeHGoKbbQHNjGtip4ADk12UQ0tJJPewdXdtK/HHz2L7W8fQFyyHuAFKFqaHU= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BN6PR10MB1345.namprd10.prod.outlook.com (2603:10b6:404:45::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Sat, 15 Jan 2022 22:31:53 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::99a4:696f:5f30:36b3%7]) with mapi id 15.20.4888.013; Sat, 15 Jan 2022 22:31:53 +0000 Thread-Topic: [External] : bug#53255: highlight-regexp should show faces with their properties applied when selecting a face Thread-Index: AQHYCeyi149s0mx2m0mjEIdTSF1DO6xj20kjgADNTWA= In-Reply-To: <87zgnxnwkf.fsf@gmail.com> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a2d274de-ef53-466d-85f6-08d9d876d4b2 x-ms-traffictypediagnostic: BN6PR10MB1345:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4Xv7GRd3a0Ng+NWhZga8mzjb8R5vM+Y1yW6zLumixg5EYehZDVnSAcNr4hNGkTdnDUONb1HnaFToGFq4/ADRaA6ixmwTjiW2yKOSuxmuV6UoW8lTDkWAxe4Zi1STi2rgxpskyBsXy/JtwUe/tCWLXnSCll/MQphtATFkZNd7d0K/ucjytQdVIzmMs5zBPXvwCfzrw1CFj+K7dL0A3LVo9LSb4i4N4hrVZKYu3i2AI49bMgzMptfdTxnphiwuX9g8VuQczT5BxYtRPkPPT16le0VO6WpdTDPwUlWmq7g6l+jCHF2CyT35wyWz3DE5svssGKdn75yPctt8RCdvnKisxJdwvviQi59peHIzM9e2QJ2XMmjd4z2DturFCS91acQAF45cn652bt/YhiMkyrS6NVxcedKXh/W8eiMAPasnUiThvJK0khTiTuQPCyxWr5YjDB0Q5mDVZJ+ZpeZmVUob1pREJgXj5ThTfExL1tT7cpvJ/s1OV6MKGNRZv+PcGOziQyyxhc2ck8eUkMlPUWe75qXSdCW78dpwfsZQON7l7kzNOcHfsfCavUch1WXD/fcNs1rKfTwo/VF30d9gyJGkmIUrdcABlZzD/+dc4hwXqeKECq6pA1y8qT3dsfXvU1K7ON8FL81sUkVAvvyLqeh/EB+dUwg7yTqqf0FjKq8zIhwDTuGMSiAQwG5RtA30KM3U+IwfpfCXM0EYvKXSDA5nkg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6506007)(38070700005)(83380400001)(7696005)(8676002)(44832011)(66446008)(66476007)(66556008)(110136005)(9686003)(316002)(64756008)(54906003)(186003)(26005)(508600001)(8936002)(122000001)(33656002)(2906002)(86362001)(71200400001)(38100700002)(5660300002)(55016003)(52536014)(66946007)(76116006)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: Cgp2JmtaLNOaS9Q789ocyW9c6Di/xK5Fmv8aCUSHJl5nKt4bML7HVHgxzjM0cKyq7y3ubhLwROHb3RbGzmx+KEmg6vTIj/qM9UfJKaFjVkFoyQqL+sFaiKuT5T7Q3bfYHWex0FAj3KHqcOxrbHJn3bZPUSHht84JSbkgprBXj+3/vq9Uq3avMYFfwaL9vm100yVE4bK85bWFaBBwt+dxn+MZsmWFKWPAVjObT3UG/J7RVTPHNwTrUDjD1Uw+LaiTp8m8BhmGSNlntwCTbNJ6a86D5krnZ3wMIAkgLCpVGmKvmYIAg4l5Gf4AkvMPafzXaGhl/b4C4nnDXVyZVXb1U5bMv3IPhvaxnEavm9cJmMnfdX600O3lLIHYgTU9E9ZukxTEM4EJEMlOpM8hwem8cq7A2mnHyDVzswFOrfRlB0pFTnsEgcMVHj8fCIz8LOZarknd7ZN/zTyyzjDGR1T4KTUEtbMIrsVle0PI2G0ZpTjY5Ey1Z7yABkRYclKUfExAioEC0Gme6YXzzAC4A9WPVL/AgwCYdbRNVD2dRA6rBVhDlZCdyvuwSpSHtPsiFpRYGy9vpqoifzBANbtV76Lm4c2TnB3La0Qr1FQteqgbmyYePKtbpgoh66JxLiOcOFrLu3W2T8CWv0FJB16O36oDAoSO33BJRouOl/Ewr4CEF3lijHtl09Kusim3xVgIQM3XIxxaPxnRkYc8o2Xcb8+mQca2HgdEyOEjwseVPSY97XTupRiSA9g146S2Yw CEdhqcLe+Q8TMOXzRM8yX99wNtnnFbsth8tCb7Vy1nspcY7ToJXQpCPCB9ulkCIs1DDTPCZvjZvrofHINXHyQMcFSJ0Gh565xa X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2d274de-ef53-466d-85f6-08d9d876d4b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2022 22:31:53.4907 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9I7Vy8vHjEz6L4q79cp4H3ecq2yGt5dQ/C3TFVKWhGr2Epu72V2vslqKBAsvBjBm4MZmVYdBVJzob8Zv3Y+Nwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1345 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10228 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 spamscore=0 mlxlogscore=865 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201150147 X-Proofpoint-GUID: QAZIyxVhlQYZpIJ3MuKWu8Ba5eNRjutQ X-Proofpoint-ORIG-GUID: QAZIyxVhlQYZpIJ3MuKWu8Ba5eNRjutQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224350 Archived-At: > > The patch below implements this, but it does lead to some strange > > effects: > > > > That is, some faces have odd sizes, so the completion display may look = a > > bit odd. >=20 > In addition to the odd sizes, some face names become completely > unreadable (e.g. the ansi-color-* ones). > > > But it does accurately tell you what the result is doing to be, so > > perhaps it's OK? Anybody have any opinions? >=20 > Maybe using an affixation function (like read-char-by-name) would make > things less jarring? E.g. fontifying the same string for every face > (say "x" or "example") and using that as suffix (rather than prefix, to > keep the face names aligned)? >=20 > At any rate, I do think that showing the actual sizes (and colors, > however unreadable) is a good feature to keep. Yes. 15 years of practice (with Icicles) says this enhancement request can be made to work well. The key is to give users (and their code) the control. It's perfectly possible to have the face etc. name itself be shown without any face property, but to be accompanied by a swatch that shows the appearance. I assume that's what you meant by referring to `read-char-by-name'. See the screen shots I linked to in my previous message. Give users 3 ways to show candidates that determine colors, fonts, and faces: * No sample - just the plain candidate name * Candidate name shown as sample * Candidate name shown next to sample (swatch)