From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code Date: Wed, 4 Oct 2023 02:04:01 +0000 Message-ID: References: <87a5sz70gv.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="380"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "66328@debbugs.gnu.org" <66328@debbugs.gnu.org> To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 04 04:05:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qnrG9-000AJZ-SY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Oct 2023 04:05:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnrFt-0007RD-SD; Tue, 03 Oct 2023 22:04:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnrFk-0007Qt-Lm for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 22:04:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnrFk-0002YC-Cv for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 22:04:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qnrG1-0008MA-Rh for bug-gnu-emacs@gnu.org; Tue, 03 Oct 2023 22:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Oct 2023 02:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66328 X-GNU-PR-Package: emacs Original-Received: via spool by 66328-submit@debbugs.gnu.org id=B66328.169638506632067 (code B ref 66328); Wed, 04 Oct 2023 02:05:01 +0000 Original-Received: (at 66328) by debbugs.gnu.org; 4 Oct 2023 02:04:26 +0000 Original-Received: from localhost ([127.0.0.1]:41008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnrFR-0008L8-Tc for submit@debbugs.gnu.org; Tue, 03 Oct 2023 22:04:26 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:64082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnrFP-0008Kw-7l for 66328@debbugs.gnu.org; Tue, 03 Oct 2023 22:04:24 -0400 Original-Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 393I49Ic025004; Wed, 4 Oct 2023 02:04:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=ydIp7FSqdtYJLQPTAt01gqPfiMJuXk9ok+QptgNMjtU=; b=3gOYKq34ANvWtR4yjoKj7eQV+KNDHB8fjoCa1sAnwebWE8E+5WIFqvKAnmzDdX3IdHeB sXPktaEfDxnQQS0nKPK3ktbB9/5bM5qpeBJwur7a9rnuLPUOLjkgywZAGVgIkCcIrK5r 9XHUKnv4PIRqJga+DrpvRPBR2luHTag9dqfSwtEyfrFROscReqBuVe8xcRQcVsU3G0/i Ihm7VxmmLOv8jYh0vGf+sZLYd8Usic1H2UE+mY/ugSjfAlHWgNAdZ3lJWGKP7ul0Xo0n CiTIZZnABDuF3sB3qz0UmaENv0linPgQAZ2DrjSirI4qazS1vIcO0A8ovGYs8dT4KL8B 8Q== Original-Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tebqdx1pr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Oct 2023 02:04:04 +0000 Original-Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3940tDqC005824; Wed, 4 Oct 2023 02:04:03 GMT Original-Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2047.outbound.protection.outlook.com [104.47.57.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3tea46x2x2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Oct 2023 02:04:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R6Z0Ug9nnhxdTDJDX9/4qsWGZvpRjSZGQK3FQrLcqDyiSV1Ratto7q1pdnSjGgOyyjxt67evq49LhUuuOj+Nbj+uKpFWO33btFMDoBDnbtO9CYlEeeD7ZrIdGcsjAG68qyGF8NgLGK0xpjyoAbgqOZnW8JsWHl6SUhDthSF5dXt9mtrpa4FZ2VMuqe8qB+rOLlcM1NYjjo7BjazXKteT4+XrzEluOPFv35XZAnV6d8DW/DoGIlo2LNnOJfHnz0eQQ1qKzDXLZUQAmL/0MIjctc6REWEIbt79pELFSLTL6+rLfCkOWUdkhtYG4oCarBI3gUL/Pw8bnW4ARdeR+pzM4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ydIp7FSqdtYJLQPTAt01gqPfiMJuXk9ok+QptgNMjtU=; b=OUOxyvIXfJgC8eLLNJ8kamvaqL8Yg8k2dFfowKNacbrsaKpvxYKJnayODA2LAoTNqNPdTuXNSItfHfth9JUYUN7kcvzC1OGE6UoQF6fifAz+JLvM4eHCnCH5+LMNViPeG+c9GZsWbqZI+vUJxhrohWj8XVPtOfj1WNDgCPLj+EW8A+6Lv18uErfJxg3XYHzKT46P+4irMRsVki4Y5FLGGFANKt0UnhAWUrchlOBLf4Wbi5LWJQCXajKoeV/r5sTOi/riE7ZxFVhc7w1FKpkaMcjKGp5SnbkLAb9qHa9ifN+jltOfaKGMSbrWW9My3rgKPDhFzOKxC8oqL/mcJbQklg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ydIp7FSqdtYJLQPTAt01gqPfiMJuXk9ok+QptgNMjtU=; b=Gpuvk+MMAK8IPedBjtKpMhjMmYiZh6keSG4QDjAYxwT+l7ShyQoFcrzWviZf+Z4aOEosCY2wMNBlvHppsZKGCWtf3DqojmbnttujlKQCcfnPR5DqLfJWt1AEgc1GhkvZf79rKM1m/skNKqZWoqqw9SfxTYZAo8ik4oMaRJpcYqI= Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by PH8PR10MB6648.namprd10.prod.outlook.com (2603:10b6:510:220::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33; Wed, 4 Oct 2023 02:04:01 +0000 Original-Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::b7d5:c4af:24ca:f386]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::b7d5:c4af:24ca:f386%4]) with mapi id 15.20.6838.033; Wed, 4 Oct 2023 02:04:01 +0000 Thread-Topic: [External] : Re: bug#66328: 29.1; Incompatible change to `completing-read' breaks existing code Thread-Index: Adn2Ros6Ehwz1+s1R6ebKttcBoDqZAAClsRPAAT0mYA= In-Reply-To: <87a5sz70gv.fsf@gmx.net> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|PH8PR10MB6648:EE_ x-ms-office365-filtering-correlation-id: bdba9132-2cfe-433b-5df7-08dbc47e2dbb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: krZOxUVtKEOSGFXBQ3AZqprwf4If+D130sPlg/KsO5PJk9zkXsthOVX9XiF2aep6s0ov/DKrGqobAOwprfUOXdnbUaamzvfAJxIigJ2IQ8yBiOqMS63zP/nVYiADKLsNyHYXWsKR/arBzwa9KZKvDEg6gwfFf/bk9tKo4Eq7aGhvddc5lRv8kOwV2+jNVvsCyzrWYytTusolVsSzbrlUhEz9DFRMe+dDpXMh5IKb7fdX0ydVyP6jRrnSCttYNGICe9rr6mJ/kV4N4kU8N/JBeQwmuB43waVBo3qkZtKN8tMm4gdtLWUL3X5JqwkKmiZKm5vHBPHhcSYFlQbnNYRKPbkPghwgTSW2lpjx57M0dP5ZCH3WEM2A6Ep4SoSRuL50p4IYH0PidnPxBGEBvRsaKl+d4PfQ5XTY06a2RSKXd6laVdYtRbaum8XbOYoRuwWr4YIN7m8ShKf++Cgea90ugGIoADuFzQQ6Ly7m23fhWiSHiGYiZFZP8XKUKtDoTQvH7HaICh/bTgFQbKN9uneKVvtiycw1wk6YBozwyjfig2TaabZsRqPSj/5Ht8bX2fpzMAP3KNelJY9MjOOvytXEqZ3tmDSOo5EZpBqklSQ4LMpDG+pcjNnMHpEP0sUJoni1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(346002)(366004)(376002)(396003)(230922051799003)(451199024)(186009)(64100799003)(1800799009)(41300700001)(966005)(6916009)(7696005)(6506007)(9686003)(316002)(66946007)(44832011)(66446008)(66556008)(64756008)(66476007)(76116006)(8676002)(4326008)(5660300002)(8936002)(26005)(478600001)(52536014)(71200400001)(83380400001)(2906002)(122000001)(38100700002)(55016003)(38070700005)(33656002)(86362001)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: IwJvv19qEMyov8NMWQzTakMlaOjkv7yykvKqhU1Ca+T/fkr+QzjOilxKtAE8bxIOeIdLe0akfrz9vfnFTvCQdXvsuT7jo/AYidIVstPYARPaG28iPss4o7TGz7oACB60H0p8zC1IwbCfsW5Zd2G84nbLzp/DJjksMFo/RpQ8JfT3j0JRIBqNWNlDg0kPf5+NzVJ3ZQ8x7uvDxtTmejk3Hdgt7ww7Q2kNHwlTLC+jGC0fRmf3PBQuNNpS1KYjQ9qf6qzE3mdKHwyHnm1nj9+pHAZ4G2ZrBACXW7oL3fr+KzS4tWXeMg7ffeEUQZE3RDMR2dfSR3rmVDKdJJ+VAUPm/fYP9OwSt6EiHZC/ffNGEuGpKG4aQiFfr/9tGcVE7khh5Qg96NBV8hb97lXzeRoaZOi0dNho2tHr9K4+ws/t3Nep/0Ol25eKMUOnVjMJikqxEfmdLTveflb3mYyjel6c8z72ozmS1u6YNioqb0kMlU7+bNzi6w14hV8A1kYu0tQmSNZr8SKpe58l/0p43SYkMwPqzUAZ6kGisSIdrNoEVXJKuk31qatDkczvN4fXoMe42ogehgDUt8oMfSYBDB2ABP6BrWN4iQGwTg3iDyRKx6NmoKLHoKFHiPPRrnZ9ZX/GR89+P50YEf+syszHOG8PSVzViOuF+wzDnG8Au56qJmnHfVms6PAcHC4cbjFBkElHhp2Opf/hQBijxJb2tZBFC4ATtzn1Iehr+MtXS0239eU8g17XIKhuYVgvZp wJkk822RbI9+rsJq/WY4R/lN6Q2UQQyeCS9eICo9FRsXf0JspIEXfJDx5cj0A0HCqBfwxbRgVkt+PCcbplOA88itxYtz8WFKbh X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KjrKUNlEY3O1D7+uiImecGWDeTeOSECZTyUDzPy6TEUjKsikWiSEEwkJmgFi8B+YuR7lCb5a5bo5UsboG0rBAKtLVI7Igo+3frHxw6xIO0+HhNZPjclmIcGPEXXYwaikzOBXUy0LbYlpDvx/0FpjyAScIoNU49ml0E5+PnD94fhC3suMPnWGQCbYW0YbXyROPSxvxl59kETC0tMrBEsOgHe77L1McttSsbBkJjhkJx1v1eSZ1ud5qgH5NytDC6EiEGZLB/PbULMwdP8AS8u0zLxMYxgwgnpomQwZ3LmwrkPLQ1aQsLLZVBRa4gzAdJUhYvzV4cYvYz9JhoPeO0LwKGT7veh3RRTX8o95ke7OAELp/7I9Zec4KfX4+RGoE1NY1HSjo3XfIlGurrSucOFPmAj92toX6HzO9xhuyo4P80ao8YNCd6iUyiscUWUf/2HPZd3GK3UocFskB5T2M50FVX7m0RYOa0nmk9FnDHAaWA8V36xqCnWng177AKqrzFljgNSO+lgpB4p6+PlJwlAGS1Z9fSKqDJc6DL0Oq6MRRlvu60Fm7Zp59/9o3kjcc4Xh4jQvsn6FUvU3UrXfU4aKPOq9yDoOKMvTw9ja4d5uRw4ZrCectmU2Og2Sk93R3nxfXHb+ttvouhAQ5s/rZ/RSnO6py6DsxYGVHfFpdVbq/j/4vkgXHrlMwGolzpK2d7kev801OGNRjzhV9nrv5kyKzEjTmnbCDc2G6qALyaMu/p7tZG Yenbqq87x89NMA2BPOd/EBSX7W1QleJbmPgAcd4EjzCn/1cT2dMFd7md5tv+E= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bdba9132-2cfe-433b-5df7-08dbc47e2dbb X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2023 02:04:01.4647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HF3qX5BA+kQWTfAr4XJIpup4ypUjpFvwEK9v5iq3QLUKUkr5ANRkgxqBP0h7v3csUbdqdiwDmDowjaMijsBqpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6648 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-04_01,2023-10-02_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310040013 X-Proofpoint-GUID: EJOpveqnFJIgyD8Ng4RNzJrWmoOqmDVi X-Proofpoint-ORIG-GUID: EJOpveqnFJIgyD8Ng4RNzJrWmoOqmDVi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271753 Archived-At: > > How did the signature of `completing-read' get changed? > > I didn't notice any proposal or discussion about this > > in emacs-devel@gnu.org. Did I just miss it somehow? > > > > It used to be that _any_ REQUIRE-MATCH value that is > > not `t', nil, `confirm', or `confirm-after-completion' > > behaves like `t', except that type RET doesn't exit if > > what you type does non-null completion. > > > > That's no longer true if the value is a function! > > This completely changes the behavior of `completing-read'. > > > > Not happy with the result, and not happy with how the > > process - how this was done, if it wasn't discussed > > openly in emacs-devel. >=20 > There was a short discussion, after the change was made, starting here: > https://urldefense.com/v3/__https://lists.gnu.org/archive/html/emacs- > devel/2022- > 06/msg00539.html__;!!ACWV5N9M2RV99hQ!Pi4vEIugzynWXlOXCj_8GVnUyeP_8Q9i9ysV > ZwoUAmd2dc4qwMRUMS8Ce9W_d_8GAlmYBaDccZg8x2-utGVJed4B$ I see; thank you! Yes, very ugly. And no proposal or discussion; just Lars changing things. At least Stefan spoke up (though not about the basic breaking of compatibility) - after the fait accompli. I suppose I should have guessed it was something like that. Wish I'd have seen it at the time, and realized what the overall effect is. Really too bad. The justification given: "adding a new parameter for this use case seemed a bit overboard." So just break what that argument has always been about, and reuse it for something altogether different? Sigh.