From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Newsgroups: gmane.emacs.bugs Subject: bug#59491: 29.0.50; [PATCH] Mode-line elements too wide in some VC buffers Date: Tue, 22 Nov 2022 17:58:25 -0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21234"; mail-complaints-to="usenet@ciao.gmane.io" To: 59491@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 21:59:57 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxaN2-0005LP-Qo for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 21:59:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxaMT-0000Fq-3M; Tue, 22 Nov 2022 15:59:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxaMB-00008d-RN for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 15:59:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxaMA-0003qB-LI for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 15:59:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxaMA-0004Zf-Cj for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 15:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 20:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166915072217554 (code B ref -1); Tue, 22 Nov 2022 20:59:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Nov 2022 20:58:42 +0000 Original-Received: from localhost ([127.0.0.1]:52689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxaLp-0004Z3-B9 for submit@debbugs.gnu.org; Tue, 22 Nov 2022 15:58:41 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:58112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxaLk-0004Ym-9H for submit@debbugs.gnu.org; Tue, 22 Nov 2022 15:58:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxaLj-0008BK-PS for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 15:58:36 -0500 Original-Received: from mail-mw2nam10olkn2091.outbound.protection.outlook.com ([40.92.42.91] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxaLh-0003gH-9M for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 15:58:35 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LY38srNsFa6PWnkDRJ2nX5YDi1D7tyeI8zU3J7lSOezZ/Gg18Th+y+WAQXefbwl12XFF1YTKusEo3bvSAEimtYvJRsMS3wFHb4L19OQJ87I0Allq9lto7mUxTYET5DDVBTRNVjn2FTNkoUElQ0uyUCwOkAGlzjbeXYw6xxsrFP/n1LYBPGF/S0ZerSnpnhUSchoGSGfYRHpVSBeoq+hwdw3Of2GOrRiTO7uEFuMEcRdGbzosUANtome5ul19JucTkHpFp8h1pNjf8ndmgcYmJC8JmJGjMIPDqdUg7Owa/RV+IS/urKaY5Ln9K9fSXVJ1jbtgPuQotaAs3wL5yP+yxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TkqM3Jl1i9zDCcWwKyYlBukxwDn30UkvSbv5tzypO9s=; b=PBOS4nLWQ6aUAE4csOX50Z5P7xh/h2ygUgYR3n4cg+hJavN3VrWyZe93FaYgs+74o43VnYG7tsa7xS3WAqujZTUsRyqF5djVodxT6Zx9QM20tmGjUdCM63rhw+Yw5PQ7Mkb8HORKpffG7tV261FSr7r/rqJVviMaLIQ4kTBgofHJTja0VJ/oxxZPIPixcUQOBrHqFzCBIxIKHej0q/W0yTmJOGTjqQ+DcOI5V93VLjrHr9S7kc2ZcJX99pcJSarlP64RzJ02NSpAFBQ0mbLmupqN2c5e7s3EAirwRbEgTn1+jKKH2Fc0vzQqeY3KnAqzxiNTWQv/CxXHIuaM3U6GTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TkqM3Jl1i9zDCcWwKyYlBukxwDn30UkvSbv5tzypO9s=; b=n/BpFEVeW48cRKqbHnprvTSHySe9DN/MaWGzdfs2ATc62ofw8hsvhf9IncI1h9hlXAbMpxXOcjKdPLMVV+gXWnKkl1VkAiQ+1/JjsZEgHGEAcoATVAjA5On8xlyCwmGJlS96hHquwn3WupVtVun+WEfe9PZA/9CgG9sJWvg32VdJmyalujepPmDsi6lKhmgL7e3YpG7gjHmFaeTxpbzaX0773nrm1jr6JgeVgSnMtqFAnL9aHNHL85SjfRsRPN21JNMaX7ebbv10TM4/gCasXUY/6CA3Mero6EiOfcF+vYfFveSr47HdpEAehcl2QcfFrezFqlZm+5ATlXgvnM3rmA== Original-Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by CO1PR06MB8089.namprd06.prod.outlook.com (2603:10b6:303:e4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Tue, 22 Nov 2022 20:58:30 +0000 Original-Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5857.017; Tue, 22 Nov 2022 20:58:30 +0000 X-TMN: [w/4UNlPQxWUz5cRSnr6fO2gyYEim2GE6ZQLVI2eN+ID6/lIAI+oPjIllbvVmO1EP] X-ClientProxiedBy: CPXP152CA0020.LAMP152.PROD.OUTLOOK.COM (2603:10d6:103::32) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <875yf67lla.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|CO1PR06MB8089:EE_ X-MS-Office365-Filtering-Correlation-Id: a00a57e8-e64f-4658-6a34-08dacccc4f4f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bowLxMibCStpz+fjPvGQDPfT2yFy5RptYHI9t7JUs6wg1tCUGOks3PjoWXp71YAUXvbBmYbZZmMfRn7XoaKHy0ib1wtH+wdoETP5mxZksIl1HOWUvAl4JdQZDd5BFf/iY43zGW8FZaubJEhMCCxCBJD9O3RRFA08KvbEhXW0g94vyv+wHga6HSaCBV6qNiPHPVclAp/GgKedIS7MacCrb98hQNTgPWSQUI7oDvtEkkXwhlvHtM09rTZ5VuHap/cUJo5FZCb/iZYwXCFujM5wjuKL9ZjwLesJoN87Iw8YKJdH3xzkNdqePsZFYbj5k2FyIJeHJXWUup5z+Mx2H0kE47j0+aUII0pmtG4L4ylZOqtiFTNgC3ukEMFTwOghcB29OR08uaJYAir0ucvHcblDA8IrKIC+gX9LNUd1NhH94Mg+lfnT3IzII0MBZDKGKmG/3pda3Fm7NdWSBrmXhpLHtrZft+W7K+/h4SV1gzZfdNDjDv2W7Bcl1rAFod1NiE8RSfuiYz4UMMy64uJ+6vskWKW01u/qviWkzFgyI5ssO8Y3KKmOw/Koxmi+41Ty6LElS0XzKAGEFFsKV3ZTFxgMxl0cYaiOEm3lJcJgRLs9eKU= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MhAoXfXqGQftdBjJWRBqJz5ObhkgdfilwQrNF7qFTpJUggWDUIX95l3MPfae0EZGrBg23bK0z1PI2gEqIGjTzE9R+kpgGL5wg+RGO9BHehEzPVd+l2fIZ803wMuNOSs/c35iw0kEY7weYb24o9qZ6V71/l+vii/jtkMcKkaRG2j9PHLg6K+fzcmQ18rDLJKJZ77+l7k3nniQe3wAhE/1Zl+FQbpJB5xaw2H3wT7sqRnxYDNYyC+/NgnS0aUMB2OyFMVN3t3cmq4B+dBfGSuucTs3TKnbxCob98LMhOeIsK4bleVxO93Egy8R3WykGNqOz+jbZV+VdThsJ+mmmUrGK401gkYESk9kA8yCHB9IkZxeD7KUWIpPTvd2PXG3WPIu8gELLctWEmpFj8gzsDHx2gOcUTRNqLUeAsHVu72vYG9ugMVP1uJ1nUuTy1tqzp5T7AgSxtQ0IkNVwpC6tDK6ZJXEE8//p0XpiX2FhYDEENSQDE3IHQBQcNclUbl0/mzAbTA+VqQcWJySex+J/oIO0hXYBbTZL353/atRmLJLyTTDfPNSkG4zETJ2+nGB8jphiwjKyKthzKDqJutAP0KjG+o9w8LzQUHeMoGUVHOT9XnvslB9lKvffylYuHMv7tsDEUkvnjlyC7Tg5GQwzKsnvrSuhZNau795p1K6gYNBCYtHL7QGZP5zeaffnvX7U3qU0hbHgLfLMd+03+aS8rYZT3tzgXGihlO94r1FRVzovB2y2CIG+96uSh7FBz o/mrR54+Vyo6by7RiEXQsd3+S4YjiZ+aSAeMzcC6CBfQ6fr9CwMEyqHxxSrvZTmbNoGVNf75yra0FyNDqVSDe4rliWl/aytlQ9 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: a00a57e8-e64f-4658-6a34-08dacccc4f4f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2022 20:58:30.6875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR06MB8089 Received-SPF: pass client-ip=40.92.42.91; envelope-from=gabriel376@hotmail.com; helo=NAM10-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248680 Archived-At: --=-=-= Content-Type: text/plain Severity: wishlist Description: Some mode-line elements are too wide in some VC buffers, which affects the information visibility. Steps: 1) emacs -Q 2) Open some file controlled by Git VC, e.g.: C-x f ~/git/emacs/README The buffer named "README" will be shown, the buffer name is displayed on the left side of the mode-line. (length (buffer-name)) => 6 3) Annotate the buffer: C-x v g The VC-Annotate buffer named "*Annotate README (rev 1f39da3098a2a4cec9985e6db934ed14b7b522b7)*" will be shown, the buffer name is displayed on the left side of the mode-line. The revision number might differ. (length (buffer-name)) => 64 4) Show log revision at line: l The Git-Log-View buffer will be shown. The value of `vc-parent-buffername' is " from *Annotate README (rev 1f39da3098a2a4cec9985e6db934ed14b7b522b7)*", displayed on the right side of the mode-line. The revision number might differ. (length vc-parent-buffer-name) => 70 Analysis: A short named buffer "README" with length of 6 had information displayed in the mode-line with lengths of 64 (with `vc-annotate') and 70 (with `vc-annotate-show-log-revision-at-line'). This excessive length affects the visibility of information in mode-line, which was supposed to ease the access of information to the user. A long buffer name can also affect the display and usability in other interfaces, e.g.: `list-buffers', `ibuffer' etc. The problem, in this case, is the long revision string used by Git. I am not sure how other VCs behaves in this matter (bzr, cvs, dav, hg, rcs, sccs, src, svc etc). Solutions: For Git, a better option would be to use a "short revision" (by default the first 7 characters of the "long revision"), which would reduce, for the example above, the length from 64 to 39 (and `vc-parent-buffer-name' from 70 to 45): diff --git a/lisp/vc/vc-annotate.el b/lisp/vc/vc-annotate.el index a15cf417de..63485af52e 100644 --- a/lisp/vc/vc-annotate.el +++ b/lisp/vc/vc-annotate.el @@ -409,7 +409,9 @@ vc-annotate nil nil "20"))))))) (vc-ensure-vc-buffer) (setq vc-annotate-display-mode display-mode) ;Not sure why. --Stef - (let* ((temp-buffer-name (format "*Annotate %s (rev %s)*" (buffer-name) rev)) + (let* ((temp-buffer-name (format "*Annotate %s (rev %s)*" + (buffer-name) + (string-limit rev 7))) (temp-buffer-show-function 'vc-annotate-display-select) ;; If BUF is specified, we presume the caller maintains current line, ;; so we don't need to do it here. This implementation may give Another option would be to display additional information in the header-line. Another option would be to allow the user to format how the VC-Annotate buffer name is displayed (and optionally also the `vc-parent-buffer-name'). See attached patches. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-New-option-vc-annotate-buffer-name-function.patch >From 4ff9db05b20ac48b222b06f6c11a12fd35fdcdec Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Tue, 22 Nov 2022 16:45:30 -0300 Subject: [PATCH 1/1] New option vc-annotate-buffer-name-function * lisp/vc/vc-annotate.el (vc-annotate-buffer-name-function): New user option. (vc-annotate-buffer-name-default): New function to compute the default name of VC-Annotate buffers. (vc-annotate): Use `vc-annotate-buffer-name-function'. * etc/NEWS: Announce the new user option. --- etc/NEWS | 5 +++++ lisp/vc/vc-annotate.el | 20 +++++++++++++++++++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 5a65896d69..01dab3387b 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1973,6 +1973,11 @@ your mail user agent. The behavior of 'vc-prepare-patch' can be modified by the user options 'vc-prepare-patches-separately' and 'vc-default-patch-addressee'. ++++ +*** New user option 'vc-annotate-buffer-name-function'. +It allows setting a custom function to format the name of VC-Annotate +buffers. + ** Message --- diff --git a/lisp/vc/vc-annotate.el b/lisp/vc/vc-annotate.el index a15cf417de..ff3c9905d1 100644 --- a/lisp/vc/vc-annotate.el +++ b/lisp/vc/vc-annotate.el @@ -162,6 +162,22 @@ vc-annotate-menu-elements :type '(repeat number) :group 'vc) +(defcustom vc-annotate-buffer-name-function #'vc-annotate-buffer-name-default + "Function to compute the name of a VC-Annotate buffer. +The function receives two arguments, the buffer being annotated +and the revision as string. It should return the VC-Annotate +buffer name as string." + :type 'function + :group 'vc + :version "29.1") + +(defun vc-annotate-buffer-name-default (buffer revision) + "Function to compute the default name of a VC-Annotate buffer. +See `vc-annotate-buffer-name-function'." + (format "*Annotate %s (rev %s)*" + (buffer-name buffer) + revision)) + (defvar-keymap vc-annotate-mode-map :doc "Local keymap used for VC-Annotate mode." "a" #'vc-annotate-revision-previous-to-line @@ -409,7 +425,9 @@ vc-annotate nil nil "20"))))))) (vc-ensure-vc-buffer) (setq vc-annotate-display-mode display-mode) ;Not sure why. --Stef - (let* ((temp-buffer-name (format "*Annotate %s (rev %s)*" (buffer-name) rev)) + (let* ((temp-buffer-name (funcall vc-annotate-buffer-name-function + (current-buffer) + rev)) (temp-buffer-show-function 'vc-annotate-display-select) ;; If BUF is specified, we presume the caller maintains current line, ;; so we don't need to do it here. This implementation may give -- 2.34.1 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-New-option-vc-parent-buffer-name-format-function.patch >From bdfa9d64850e4b7de6b77dd16280a840ed0735fc Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Tue, 22 Nov 2022 16:50:35 -0300 Subject: [PATCH 1/1] New option vc-parent-buffer-name-format-function' * lisp/vc/vc-dispatcher.el (vc-parent-buffer-name-format-function): New user option to compute the parent buffer name identitication in mode-line of VC buffers. (vc-parent-buffer-name-format-default): New function to compute the default parent buffer name identitication in mode-line of VC buffers. (vc-setup-buffer, vc-start-logentry): Use `vc-parent-buffer-name-format-function'. * etc/NEWS: Announce the new user option. --- etc/NEWS | 5 +++++ lisp/vc/vc-dispatcher.el | 22 ++++++++++++++++++++-- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 5a65896d69..31bc22ab9e 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1973,6 +1973,11 @@ your mail user agent. The behavior of 'vc-prepare-patch' can be modified by the user options 'vc-prepare-patches-separately' and 'vc-default-patch-addressee'. ++++ +*** New user option 'vc-parent-buffer-name-format-function'. +It allows setting a custom function to format the parent buffer name +identitication in mode-line of VC buffers. + ** Message --- diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el index dc3ed52650..e45d4d16ef 100644 --- a/lisp/vc/vc-dispatcher.el +++ b/lisp/vc/vc-dispatcher.el @@ -142,6 +142,22 @@ vc-suppress-confirm :type 'boolean :group 'vc) +(defcustom vc-parent-buffer-name-format-function #'vc-parent-buffer-name-format-default + "Function to compute the parent buffer name identitication in +mode-line of VC buffers. +The function receives one argument, the parent buffer. It should +return the parent buffer name identitication as string." + :type 'function + :group 'vc + :version "29.1") + +(defun vc-parent-buffer-name-format-default (buffer) + "Function to compute the default parent buffer name identitication +in mode-line of VC buffers. +See `vc-parent-buffer-name-format-function'." + (format " from %s" + (buffer-name buffer))) + ;; Variables the user doesn't need to know about. (defvar vc-log-operation nil) @@ -188,7 +204,8 @@ vc-setup-buffer (kill-all-local-variables) (setq-local vc-parent-buffer camefrom) (setq-local vc-parent-buffer-name - (concat " from " (buffer-name camefrom))) + (funcall vc-parent-buffer-name-format-function + camefrom)) (setq default-directory olddir) (let ((buffer-undo-list t) (inhibit-read-only t)) @@ -748,7 +765,8 @@ vc-start-logentry (pop-to-buffer (get-buffer-create logbuf))) (setq-local vc-parent-buffer parent) (setq-local vc-parent-buffer-name - (concat " from " (buffer-name vc-parent-buffer))) + (funcall vc-parent-buffer-name-format-function + vc-parent-buffer)) (when patch-string (setq-local vc-patch-string patch-string)) (vc-log-edit files mode backend) -- 2.34.1 --=-=-= Content-Type: text/plain Please share your suggestions. --- Gabriel --=-=-=--