From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Newsgroups: gmane.emacs.bugs Subject: bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type Date: Sat, 12 Nov 2022 05:56:22 -0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32253"; mail-complaints-to="usenet@ciao.gmane.io" To: 59212@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 12 09:57:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otmKJ-00089c-JU for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Nov 2022 09:57:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otmK1-0008Bz-3j; Sat, 12 Nov 2022 03:57:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otmJz-0008Ar-0A for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 03:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otmJy-00067U-JR for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 03:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otmJy-0002lf-1I for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 03:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Nov 2022 08:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166824339710603 (code B ref -1); Sat, 12 Nov 2022 08:57:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Nov 2022 08:56:37 +0000 Original-Received: from localhost ([127.0.0.1]:47291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otmJY-0002kw-Km for submit@debbugs.gnu.org; Sat, 12 Nov 2022 03:56:37 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:57892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otmJW-0002ko-Fp for submit@debbugs.gnu.org; Sat, 12 Nov 2022 03:56:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otmJW-0007iC-AJ for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 03:56:34 -0500 Original-Received: from mail-mw2nam04olkn2033.outbound.protection.outlook.com ([40.92.46.33] helo=NAM04-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otmJU-000654-4F for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 03:56:34 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JNle5bSVthvz8VYjFp8mwUdkb8kOoUgRq8LD5vh2OziFIaNZoS72dlBE51h5GtfOkpThVWplJt85T5QXFDr8S0edmhDdyQZMWf4HqbATYGbOFDYcKWmIkmLe3hj7qwvSm16/i2G8exkrYY3n+SHMTds1bkqslH3g1JEyntWQ7ff9N4KHZQAyoAZZc+nx0U3uw1fPPP45okfEtLPCyQ03n8P8jb34wkHJck9RjBnGNp8in0V8P/6hyo/gKthYsWwXk5DA7xrZtFI+dOyy25DpSPViOaecnHiE58GaTV/4+/LfxFSdOGcYpRscwZivQpwM2Vkg3pr6fDY/7c8ojQY21A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ORQryZZDiV5/RtU7IBAbXNbvi/EPWLYGj55uKRqeWLg=; b=appAG4n2wkj4MAMvwdxG0p4OQWRs6lMtSVEMkDgWE6xDtV3r9ripuY6y8qhLktnmScq5WfqEgd24WOv0ClYZy+FI9WVps2KDqMvkVSskp/5H/YV6uylMiehlRr2C1eCboCNaYIEFgzTM+BtdcdSWYnhocY1MTHEFYpu4YPPZoSnVX04R+CXZCbgUaJLElQjvs5njOFbkUHmlhLnPpITnc6oDJZ3lCIKaDP7PBPyRdlCgrJZH2A6kZyEfQH2GpYjqrGkL/QG1ZlCBP5nEQkxs5tuBUcYT8rqYdo8R/KZ1RCN6Ok6UJrZ1+Vmm4WA1sWd7TCPO9FgpM3XUD4SHzVg4Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ORQryZZDiV5/RtU7IBAbXNbvi/EPWLYGj55uKRqeWLg=; b=ffF+GzCBeH9vDq7fEQHORS1wlDieqc78I3a12gkE2M3qZ+w4DEJcu0zPZOB1W0PE2DdFJD4pvlu/if0VMdxg32ZsSdqnWsfiDazGFMPxFLNCjim+7+4VGE94VMUXzA36L0vUWK26Gql3bnN/JKXhZ4USVvl426eoxXcnihACX3+UFA241egSKYANSsP0bSlCmdJN284xXXFQmealg3TlnisGKy6wnGKOSoh7IUZsWXplKRJUiGDpYVDTrObRRuHxYJKvn7lnMGZZqPB9GwEE6Ug2CiEWM7nrXVL+djPXxnxdDLrpYrm51bgKbV2TbUeIhVtOQuHfykhMq4eG1OABnQ== Original-Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by SJ0PR06MB8389.namprd06.prod.outlook.com (2603:10b6:a03:387::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Sat, 12 Nov 2022 08:56:29 +0000 Original-Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5813.011; Sat, 12 Nov 2022 08:56:29 +0000 X-TMN: [MlnRs9njefASRnW7OSAaJu9xtlUCG+DgRtD7hDqzdJDw0HZV+BFNyNJvcdqrF+1i] X-ClientProxiedBy: CP4P284CA0031.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:126::10) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <871qq83615.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|SJ0PR06MB8389:EE_ X-MS-Office365-Filtering-Correlation-Id: 7556b668-ac5a-4ded-0f60-08dac48bc9c4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1TkY3iAsboyp/VKO/aDIhFGw69ENqHxojGZNNUjR97pUMuBBck8lJgM+Hj9Ug+5ygHRZ7XwV2oD/7apelVy17NBlDQ7lBlbUxsRhmM/+aH4wZdQEU8SzV1OSx2BDtD19SWYzZwemT4+MGhG+ZQ3WTbfrZnjz3DZMkjjvUNbReZ71q4dmt+JHbat1BQtu/pF3VJaKQIMuZhbtOMcw3lZWHsL2nRlBUjhu3jbpQb2qo1+QhdVyOF+BLx/XX9d3x+AfkVoKOdKKGDtTawlyj0vb5/s14OV9ZJqV4Qi73ZoVNIxdhwxqghmYnKTQ69R+o/nFX7QrSsEUDXpmLcCMyMi95Rn1q+LQOqOMeVQWUpFiMxDdBgDq5eVn5rEeBkNzG78f7JYbQG4G+tSzjbouoaLJCfMqqwX0zchQptMWbLkuDOyAGCfyS4H21ku7y/kH94gyMy9l/br2cCCAVuZG9RlhfAW+whHfIlsOXjnh+BjEOOc+hh46k7ofMfnkhpFZ2jP2QtwBnZc+yeqew08zMbmcrl5nL+NSNvKp/CLKm6qzbd2/0KkXDjTtm3FDj1E2WYStmWVeKxXUDEv4gtUTzE8XoujJ+yMNC4qoisM+1HBJQvnQe75KZANl6bu5pFvsGCL6Xp0+rT0tG06YyrAbuDtjKw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: T02JYQB25jrAI9BQCITbWUYjYsxK3ZFLUeb/eJWbZksLWl8vZT2EuHmV4CcyGnji18qlLkgf9ZdS+q7eNgmCWYIdKCJ3jOEB3VsCkcMKEuW3VMebwFQLbPz5VpOIg535WWAKQhLdZnHmtm1jCLYDVw7LGs9FmceE46r/AR7SYZkyAs34xxBAKLLIvSzQG+XqJXdl2AfzChHQO+wOd4514PXTZuxNk16CD702NCudwxpqW8NU6yfYr5bLc8buYgpO557fr174qasWl70tGKjJLrRImVrO60hq9Kf457Io5FQigzXgGaYviPNqTecqIuQEW6nOilINgPl+xaY4k/kphJ0PiXQrovvzWuBEQo4u/k+1cnfPKDyWfvWsKwRmF6TwnnaYeo9evpALyj4Grkoz8MLeF9lX88Q3Qg1SRv2M75e3PBCTpP6RgMBjqlMpKvA4wQ7a2K3sqrlw9f3eT8DxqeaOOWzMoRHN9xGBfBAd1XvVL+7bgn6tmwNfyV2QGAVS/dasssev7jj/B81UdoYqTBK/24QL9w6m5U7tAZRgoqIF6VclV48tGhwEL2nM4xcSees8eoqH46Caiep0YzKJs+PzWM6kLiX1cwYTTcYgiaPlaXsrOzbVIs0jfb3qixq8yQPeB41tS3hVQnXbTnPZrGUOtLvAhbCQoztIn3fEc90o4bmZq82KPD93ST6Lj9/DwAaK4FG4Bkz6KBnUDQkp+Y/d8KcMZHLKG3OqAzJhFTTouOPAROkKkNSdGK jn8G/o8wB3jfGOkOjIYTvOxduxNbGHCh5/hm/AftqaMvWE5JIcKWZQqvDu0ARb7QWTD5+2dRaQKAmEpooyMGG9HI6Zfduy6cCp X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 7556b668-ac5a-4ded-0f60-08dac48bc9c4 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2022 08:56:29.5756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR06MB8389 Received-SPF: pass client-ip=40.92.46.33; envelope-from=gabriel376@hotmail.com; helo=NAM04-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247639 Archived-At: --=-=-= Content-Type: text/plain Description: Not a bug per se, but a suggestion for improvement in how Bookmark displays the Type (added by commit 7c995264359824cc1aca40ca37201db5ed44e659). Currently, bookmark-bmenu-list (C-x r l) displays a column named Type, which has a proper value for all handlers (e.g.: Eshell, VC, EWW etc) except for regular files, in which an empty string is displayed. I believe the current behavior could be improved by displaying a default value ("Files") to make the interface more uniform, explicit and to avoid confusion. Steps: 1) emacs -Q 2) M-x eshell 3) C-x r m 4) C-x C-f ~/foo.bar 5) C-x r m 6) C-x r b These steps will add two bookmarks (eshell and foo.bar) and will open the Bookmarks list. The Type column will have values "" and "Eshell". After the patch below is applied, the Type column will have values "File" and "Eshell". --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Set-default-value-of-bookmark-Type.patch >From 0d9379e2d470239e2da6369d27979672ab10a719 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Sat, 12 Nov 2022 05:13:36 -0300 Subject: [PATCH 1/1] Set default value of bookmark Type * lisp/bookmark.el (bookmark-type-from-full-record): Return default value "File" when type handler is missing. (bookmark-bmenu--revert): Remove conditional around type. --- lisp/bookmark.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index b57ad12986..ad1a1f1acf 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -372,9 +372,9 @@ bookmark-type-from-full-record (let ((handler (bookmark-get-handler bookmark-record))) (when (autoloadp (symbol-function handler)) (autoload-do-load (symbol-function handler))) - (if (symbolp handler) - (get handler 'bookmark-handler-type) - ""))) + (or (and (symbolp handler) + (get handler 'bookmark-handler-type)) + "File"))) (defun bookmark-all-names () "Return a list of all current bookmark names." @@ -1889,7 +1889,7 @@ bookmark-bmenu--revert 'follow-link t 'help-echo "mouse-2: go to this bookmark in other window") name) - ,(or type "") + ,type ,@(if bookmark-bmenu-toggle-filenames (list location))]) entries))) -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=--