From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Newsgroups: gmane.emacs.bugs Subject: bug#59266: 29.0.50; [PATCH] Add flat-button to set-face-attribute docstring Date: Tue, 15 Nov 2022 19:49:29 -0300 Message-ID: References: <83tu30iegi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14912"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 59266@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 15 23:50:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ov4l2-0003Zu-8P for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Nov 2022 23:50:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ov4kn-0000Fe-QB; Tue, 15 Nov 2022 17:50:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ov4kl-0000EZ-Ey for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 17:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ov4kk-0004Tx-IY for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 17:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ov4kk-0004qT-6t for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 17:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2022 22:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59266 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166855258618598 (code B ref -1); Tue, 15 Nov 2022 22:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Nov 2022 22:49:46 +0000 Original-Received: from localhost ([127.0.0.1]:55466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov4kT-0004pu-Rx for submit@debbugs.gnu.org; Tue, 15 Nov 2022 17:49:46 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:46096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ov4kO-0004ph-PH for submit@debbugs.gnu.org; Tue, 15 Nov 2022 17:49:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ov4kO-0000BR-Jz for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 17:49:40 -0500 Original-Received: from mail-bn8nam11olkn2010.outbound.protection.outlook.com ([40.92.20.10] helo=NAM11-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ov4kM-00045N-6u for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2022 17:49:40 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QfJ1z1G3fSFVFeD8KV7MYtEvtLnnkmoblOHDfYkCEN0WRXDlWXjHm+bwYu6xcfIABGU9epDGSfmrjZV3mgjDugAQNfa7Jpk6U/2z90pF+m+nQbNT+mijMh1nanKflmsQAec8ABDq/Pxjz1ow1BYuHicMHZjdsM7wDiOLWdjl0Jq5KdmeZQP1+coKPAZB4l2kuNkaTPCSMqETosW+0IIBn+GbLkiseDeQrCG1d5sqz3CqzU4+EiqT4sHjUgStmmTfPhr0faZDLS8CpxGbWmZZ1IASIr1eOyn7fiLsUilmMopcAviCxCr26mvZbWTTjVZHhf3SyD6dsiSp3qDtedEs2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hHXLFex5MvM0EX+pUrfFjO3yvxL4sGjBb8Oy88n4zn4=; b=fq+ICwdCMOaER9LmqRvZPOBPR/E6KnZBzxDS3kFVvuOghx2SO8niJIiwhd4J+B5AFgU4ogpgv4dAqiS4jrbDHQ9MSCwiBZj63WOx3jNVBuoK5Wie4PtjaBByqLgmROo/Ie7HZ1cQHIxIiJofEwAsSOwA6z76A/hsvhvjFeJacHuMaT8xgtvkDEuQoLTOT9YvDJelC46DVlonaZ3pKqsaU9ZLJ3zgmeomNMziR+6AYVopHKhMkx9OYux4haxRX2DFlEg4bw7Gp27cE/iomHWHg1X2ji5srqGwhQJnHn1wDicohjVhoyGzrck8D4bEBwEvK37okfcG/tpnRG3a0maLaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hHXLFex5MvM0EX+pUrfFjO3yvxL4sGjBb8Oy88n4zn4=; b=OTm4X4MwtmRtGNZrzlB2z6RgKTPuMsW+J62jczaqho1r9j2SpT7l/2FwebNib1t4KSfaHpP59AB+RvZxjadzBiBPu1ErNqvMakBibwmRZkwSXRe5ULoAtFzNCvPaZYsb/QFt9GuQ5oSbYlXwuln5WU9PWxPTp0iPLt9x5PWTzam0F7bGFuzZbnyuBZ6QMF2EpSkEnI+s/0V7LvKNwgR0cNhM1i/yU//X333r41IuB4T6K/oTcRf4wUC3jECrXigDv/jGQnfC3WwAurcHc7qpg1xwTia3dV8EwAN2SkNsKJLxYPKGjXR86c42IHeGY8bmu9nYiOg0HW4puG3X4x2Ytg== Original-Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by PH7PR06MB9017.namprd06.prod.outlook.com (2603:10b6:510:12c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Tue, 15 Nov 2022 22:49:35 +0000 Original-Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5813.011; Tue, 15 Nov 2022 22:49:35 +0000 In-Reply-To: <83tu30iegi.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Nov 2022 14:34:21 +0200") X-TMN: [LZQ1U2s8WlwYTQME0p9DMcN7iukS6W6n4XX5/qWcCDU6Fxw/Py1bTzSicRsRQ4VH] X-ClientProxiedBy: CPYP284CA0061.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:80::12) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <87edu3x286.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|PH7PR06MB9017:EE_ X-MS-Office365-Filtering-Correlation-Id: 86281755-0b8a-4730-6b5a-08dac75bab09 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xIt6Ctss4wBuFLRksb405DflN2Ow8RH8ECfWtzWGtwuX7Z8dE6z3nMuyI7lme+ZZDsQvGesLdg6LC+Rm5sauxuCvDTneF9vXWNt5HsH7NuM/4/hm+8I7i+cCFmg5rIpDEACkPihS5/zaQ/NrSTbWup8fe5nVnPA/8/MXYBNNmb+GPRT6q/7Zikeev/4X/+FkttZcvOcW//OUOP70w9jrHE99S0bEFiOsOqLlW9a9SjXE0F8ppKvB43eiFPGMFQbzuinOFHODDw4YZ0Y+2jjlLoI2J0y8IPURY3v+Zwcu4p2PQmF2Vz1C0+zTv+DmLu68Vr+oE0D7UrbSR4xJEiQKJaYO0LAlK94JvKG2n/ChxsV9yuf3q5mMfzueHR0pvv9I+xBt47hCvMIIQCMazk98hrl+p8ZhGT+2TulZieHiUv1cykqDn2mztC5YPQ/X/I9W3KQIIcmir0xKic6dej91XSz2F2qNI1DRpYmJtOFeoeOOHh87ZvvaDLGPRS6A+11bl0/wstt7f35lwi6kJx5Uxp1tfS0ME59tI5M/y9rOLJdxlU9dWOYSjm9j0PBCulD2018b/Okkt3Nz7Sxhv8eAL4jQ9WobivD4NyecMISMg9gcfKAcf+e2Su18WbxUoDRgDI2bIMaQc/tUzJRncM8+T0zUFuO/SaHfgFxASX6l22xcivERRELadxotYpR1HXOX7tTe/QX6Doug13An68/tMJ5a2QqAdjZ1Pj7JilCI2Jc= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: q7CQBjupKZ6GOUvOtWr03Z4ampV1mOM7YxNeeWQLs+8dmAKTLRO+q1y1l1VSZ7+1Ai9XQEsKVRDP4B2MhoTxrv0D2DJatu/lSiZFXpsCD701rX3pDiHhXZrBOhayJuO9CAiB3ONRyFI6e72USNxWg5IvlBFdUtiOmgZQGbgvkZByxV2tWV50IMmQmS8xFfQWfDI5JaLpoYr+Y2TikEhBmmr6b97OPcZvb6aYljcqJbeYmgd8ELjtweD+Lpk1t8mpT5IA3/c1g6/3ual/nEZ/qdsjLFmqfefyuwoSTuAD0UNng7bO1RYYelwWR5A4kR7NDYB4+eV/aTWOMJzmChDSGynMub1iGbuEu2T4iGF+5o5Ezl4tO80iCSiUp2YjTizd5LM6VQFhRniPqk1y6SpOjCvJuMTYNo3USbxpx8zOXkxA4E1Blekl98qkrTb3gVQbpR3NH81dPwaHbVZ91NdIHpoxvLqrfiS5KO8o232Tw4jAOv9BAvjLHDFTyoQi8AFVdtp10hiRhzaQ9fIpULtrfIVqdnnoQmYjvjsyEjwIeRNruvzlobKAU9pvN8eiyotGKtqwL32hBU4BJtR+2fYqoZ2ydkC0eYGJ0cmHeoUQsR3/enaAzVSsomJI89bKca4JX8X4bmFIh1gzyKqKEG5cHzcR16ORJXJx2Ny7sZ5gi2f0cPqU09dIy4JZvvX07bNKRyN9LIqimOdqu2uc5wUOpNeE0bO8mm6fpIRQvE4Q/lNeQiI1GF59IF68EU Yi0dy68/wzULeKKMNW55cr6PJP0weLR1HFrmoWzaKW+i2WwhhhnZf+O5MUuGZoQ+V+SEHQ1FTtjGl3UaxQ3rc+SZbePmdmA240 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 86281755-0b8a-4730-6b5a-08dac75bab09 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 22:49:35.6818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR06MB9017 Received-SPF: pass client-ip=40.92.20.10; envelope-from=gabriel376@hotmail.com; helo=NAM11-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247976 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > > Thanks, but can you rephrase so that `flat-button' appeared as one of > the values for STYLE, with an explicit (not implied) description of > what it does? For example, how does `flat-button' affect what COLOR > does for the button isn't clear from your suggested text. > > IOW, what I see in NEWS about this doesn't follow from the text you > propose, at least not easily. Hi Eli, Makes sense, thank you for pointing it out. I took another look at NEWS and display.texi, and rephrased the docstring to also mention the flat-button in the COLOR section. Here is a new patch. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-flat-button-to-set-face-attribute-docstring.patch >From 5456fbba9cfd3cd27dfc4db60f0729d7a79578c5 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Tue, 15 Nov 2022 19:42:01 -0300 Subject: [PATCH 1/1] Add flat-button to set-face-attribute docstring * lisp/faces.el (set-face-attribute): Add `flat-button' to COLOR and STYLE sections of docstring. --- lisp/faces.el | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lisp/faces.el b/lisp/faces.el index 09e8110449..5ae1c65a4d 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -787,13 +787,12 @@ set-face-attribute defaults to 1. If WIDTH is negative, the absolute value is the width of the lines, and draw top/bottom lines inside the characters area, not around it. COLOR is the name of the color to draw in, default is -the foreground color of the face for simple boxes, and the background -color of the face for 3D boxes. STYLE specifies whether a 3D box -should be draw. If STYLE is `released-button', draw a box looking -like a released 3D button. If STYLE is `pressed-button' draw a box -that appears like a pressed button. If STYLE is nil, the default if -the property list doesn't contain a style specification, draw a 2D -box. +the background color of the face for 3D boxes and `flat-button', and +the foreground color of the face for other boxes. STYLE specifies +whether a 3D box should be draw. If STYLE is `released-button', draw +a box looking like a released 3D button. If STYLE is `pressed-button' +draw a box that appears like a pressed button. If STYLE is nil, +`flat-button' or omitted, draw a 2D box. `:inverse-video' -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=--