Stefan Kangas writes: > I didn't really study the patch or the issue, but here are two nits. > > Gabriel writes: > >> * lisp/net/dictionary.el (goto-address-at-point): Call >> `browse-url-button-open-url', so a prefix argument uses >> `browse-url-secondary-browser-function'. > ^^ > > We do not indent the commit message like this. It should start at > column 0. > > >> ;;;###autoload >> (defun goto-address-at-point (&optional event) >> - "Send to the e-mail address or load the URL at point. >> -Send mail to address at point. See documentation for >> -`goto-address-find-address-at-point'. If no address is found >> -there, then load the URL at or before point." >> + "Compose a new message to the e-mail address or browse the URL at >> +point. > > The first line of a docstring should be a complete sentence (for > e.g. eldoc and apropos). Thanks for the quick review, Stefan. Please find attached an updated patch. I fixed the commit message indent and rephrased the first line of docstring to be a complete sentence (based on the docstring's of `compose-mail' and `browse-url-button-open-url').